[dpdk-dev] [PATCH 1/4] bus/dpaa: remove experimental tag and move to internal

[dpdk-dev] [PATCH 1/4] bus/dpaa: remove experimental tag and move to internal

[Nipun Gupta]

remove experimental tag from internal API dpaa_seqn.
This API was introduced in DPDK 20.11 and is now moved to
internal tag

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/dpaa/rte_dpaa_bus.h | 5 +----
 drivers/bus/dpaa/version.map    | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/dpaa/rte_dpaa_bus.h b/drivers/bus/dpaa/rte_dpaa_bus.h
index 48d5cf4625..ecc66387f6 100644
--- a/drivers/bus/dpaa/rte_dpaa_bus.h
+++ b/drivers/bus/dpaa/rte_dpaa_bus.h
@@ -28,15 +28,12 @@ typedef uint32_t dpaa_seqn_t;
 extern int dpaa_seqn_dynfield_offset;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Read dpaa sequence number from mbuf.
  *
  * @param mbuf Structure to read from.
  * @return pointer to dpaa sequence number.
  */
-__rte_experimental
+__rte_internal
 static inline dpaa_seqn_t *
 dpaa_seqn(struct rte_mbuf *mbuf)
 {
diff --git a/drivers/bus/dpaa/version.map b/drivers/bus/dpaa/version.map
index 1bd5a01ec5..900635b210 100644
--- a/drivers/bus/dpaa/version.map
+++ b/drivers/bus/dpaa/version.map
@@ -18,6 +18,7 @@ INTERNAL {
 	dpaa_update_link_speed;
 	dpaa_intr_disable;
 	dpaa_intr_enable;
+	dpaa_seqn;
 	dpaa_svr_family;
 	dpaa_update_link_status;
 	fman_dealloc_bufs_mask_hi;
-- 
2.17.1

[dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[Nipun Gupta]

This API was introduced in 19.08, therefore removing
experimental tag to promote them to stable state.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/fslmc/fslmc_vfio.h | 1 -
 drivers/bus/fslmc/version.map  | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h
index bc7c6f62d7..133606a9fd 100644
--- a/drivers/bus/fslmc/fslmc_vfio.h
+++ b/drivers/bus/fslmc/fslmc_vfio.h
@@ -58,7 +58,6 @@ int fslmc_vfio_process_group(void);
 char *fslmc_get_container(void);
 int fslmc_get_container_group(int *gropuid);
 int rte_fslmc_vfio_dmamap(void);
-__rte_experimental
 int rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size);
 
 #endif /* _FSLMC_VFIO_H_ */
diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
index f44c1a7988..4e53ea048d 100644
--- a/drivers/bus/fslmc/version.map
+++ b/drivers/bus/fslmc/version.map
@@ -1,7 +1,9 @@
-EXPERIMENTAL {
+DPDK_22 {
 	global:
 
 	rte_fslmc_vfio_mem_dmamap;
+
+	local: *;
 };
 
 INTERNAL {
-- 
2.17.1

[dpdk-dev] [PATCH 3/4] bus/fslmc: remove experimental and move to internal

[Nipun Gupta]

remove experimental tag from internal API dpaa2_seqn.
This API was introduced in DPDK 20.11 and is now moved to
internal tag

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/fslmc/rte_fslmc.h | 5 +----
 drivers/bus/fslmc/version.map | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h
index 37d45dffe5..a71cac7a9f 100644
--- a/drivers/bus/fslmc/rte_fslmc.h
+++ b/drivers/bus/fslmc/rte_fslmc.h
@@ -45,15 +45,12 @@ typedef uint32_t dpaa2_seqn_t;
 extern int dpaa2_seqn_dynfield_offset;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Read dpaa2 sequence number from mbuf.
  *
  * @param mbuf Structure to read from.
  * @return pointer to dpaa2 sequence number.
  */
-__rte_experimental
+__rte_internal
 static inline dpaa2_seqn_t *
 dpaa2_seqn(struct rte_mbuf *mbuf)
 {
diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
index 4e53ea048d..79b29746b6 100644
--- a/drivers/bus/fslmc/version.map
+++ b/drivers/bus/fslmc/version.map
@@ -22,6 +22,7 @@ INTERNAL {
 	dpaa2_get_mcp_ptr;
 	dpaa2_io_portal;
 	dpaa2_seqn_dynfield_offset;
+	dpaa2_seqn;
 	dpaa2_svr_family;
 	dpaa2_virt_mode;
 	dpbp_disable;
-- 
2.17.1

[dpdk-dev] [PATCH 4/4] net/dpaa2: remove experimental tag from API

[Nipun Gupta]

These APIs were introduced in 19.02, therefore removing
experimental tag to promote them to stable state.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/net/dpaa2/rte_pmd_dpaa2.h | 12 ------------
 drivers/net/dpaa2/version.map     |  8 +++++++-
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2.h b/drivers/net/dpaa2/rte_pmd_dpaa2.h
index 84ac9d38d1..a68244c974 100644
--- a/drivers/net/dpaa2/rte_pmd_dpaa2.h
+++ b/drivers/net/dpaa2/rte_pmd_dpaa2.h
@@ -9,18 +9,11 @@
  * @file rte_pmd_dpaa2.h
  *
  * NXP dpaa2 PMD specific functions.
- *
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  */
 
 #include <rte_flow.h>
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Create a flow rule to demultiplex ethernet traffic to separate network
  * interfaces.
  *
@@ -34,7 +27,6 @@
  * @return
  *    A valid handle in case of success, NULL otherwise.
  */
-__rte_experimental
 struct rte_flow *
 rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id,
 			      struct rte_flow_item *pattern[],
@@ -57,9 +49,6 @@ int
 rte_pmd_dpaa2_mux_rx_frame_len(uint32_t dpdmux_id, uint16_t max_rx_frame_len);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Create a custom hash key on basis of offset of start of packet and size.
  * for e.g. if we need GRE packets (non-vlan and without any extra headers)
  * to be hashed on basis of inner IP header, we will provide offset as:
@@ -78,7 +67,6 @@ rte_pmd_dpaa2_mux_rx_frame_len(uint32_t dpdmux_id, uint16_t max_rx_frame_len);
  *   - 0 if successful.
  *   - Negative in case of failure.
  */
-__rte_experimental
 int
 rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,
 			      uint16_t offset,
diff --git a/drivers/net/dpaa2/version.map b/drivers/net/dpaa2/version.map
index 49f69dacd2..3ab96344c4 100644
--- a/drivers/net/dpaa2/version.map
+++ b/drivers/net/dpaa2/version.map
@@ -1,9 +1,15 @@
-EXPERIMENTAL {
+DPDK_22 {
 	global:
 
 	rte_pmd_dpaa2_mux_flow_create;
 	rte_pmd_dpaa2_set_custom_hash;
 
+	local: *;
+};
+
+EXPERIMENTAL {
+	global:
+
 	# added in 21.05
 	rte_pmd_dpaa2_mux_rx_frame_len;
 	# added in 21.08
-- 
2.17.1

Re: [dpdk-dev] [PATCH 1/4] bus/dpaa: remove experimental tag and move to internal

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> -----Original Message-----
> From: Nipun Gupta <nipun.gupta@nxp.com>
> Sent: Friday, September 3, 2021 12:47 PM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin
> Saxena (OSS) <sachin.saxena@oss.nxp.com>; david.marchand@redhat.com;
> Nipun Gupta <nipun.gupta@nxp.com>
> Subject: [PATCH 2/4] bus/fslmc: remove experimental tag from API
> Importance: High
> 
> This API was introduced in 19.08, therefore removing experimental tag to
> promote them to stable state.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  drivers/bus/fslmc/fslmc_vfio.h | 1 -
>  drivers/bus/fslmc/version.map  | 4 +++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h
> index bc7c6f62d7..133606a9fd 100644
> --- a/drivers/bus/fslmc/fslmc_vfio.h
> +++ b/drivers/bus/fslmc/fslmc_vfio.h
> @@ -58,7 +58,6 @@ int fslmc_vfio_process_group(void);  char
> *fslmc_get_container(void);  int fslmc_get_container_group(int *gropuid);
> int rte_fslmc_vfio_dmamap(void); -__rte_experimental  int
> rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size);
> 
>  #endif /* _FSLMC_VFIO_H_ */
> diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
> index f44c1a7988..4e53ea048d 100644
> --- a/drivers/bus/fslmc/version.map
> +++ b/drivers/bus/fslmc/version.map
> @@ -1,7 +1,9 @@
> -EXPERIMENTAL {
> +DPDK_22 {
>  	global:
> 
>  	rte_fslmc_vfio_mem_dmamap;
> +
> +	local: *;
>  };
> 
>  INTERNAL {
> --
> 2.17.1

Re: [dpdk-dev] [PATCH 3/4] bus/fslmc: remove experimental and move to internal

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH 4/4] net/dpaa2: remove experimental tag from API

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[David Marchand]

On Fri, Sep 3, 2021 at 9:17 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> This API was introduced in 19.08, therefore removing
> experimental tag to promote them to stable state.

The only user is an in-tree driver.
Do we need to export this symbol to applications?


-- 
David Marchand

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[Nipun Gupta]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, September 9, 2021 1:21 PM
> To: Nipun Gupta <nipun.gupta@nxp.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev <dev@dpdk.org>; Hemant
> Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena (OSS)
> <sachin.saxena@oss.nxp.com>; Ray Kinsella <mdr@ashroe.eu>
> Subject: Re: [PATCH 2/4] bus/fslmc: remove experimental tag from API
> 
> On Fri, Sep 3, 2021 at 9:17 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> >
> > This API was introduced in 19.08, therefore removing
> > experimental tag to promote them to stable state.
> 
> The only user is an in-tree driver.
> Do we need to export this symbol to applications?

Yes, we intend to export this PMD API to applications.

Regards,
Nipun

> 
> 
> --
> David Marchand

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[David Marchand]

On Thu, Sep 9, 2021 at 9:54 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> > > This API was introduced in 19.08, therefore removing
> > > experimental tag to promote them to stable state.
> >
> > The only user is an in-tree driver.
> > Do we need to export this symbol to applications?
>
> Yes, we intend to export this PMD API to applications.

Thanks for confirming.


-- 
David Marchand

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

[Thomas Monjalon]

09/09/2021 10:01, David Marchand:
> On Thu, Sep 9, 2021 at 9:54 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> > > > This API was introduced in 19.08, therefore removing
> > > > experimental tag to promote them to stable state.
> > >
> > > The only user is an in-tree driver.
> > > Do we need to export this symbol to applications?
> >
> > Yes, we intend to export this PMD API to applications.
> 
> Thanks for confirming.

Series applied, thanks.