DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/proc-info: fix security context info
Date: Fri, 15 Jan 2021 12:25:07 +0100	[thread overview]
Message-ID: <8754871.pTA5GFj9IM@thomas> (raw)
In-Reply-To: <20201224075133.15020-1-hemant.agrawal@nxp.com>

24/12/2020 08:51, Hemant Agrawal:
>  static void
> -show_security_context(uint16_t portid)
> +show_security_context(uint16_t portid, uint8_t inline_offload)
>  {
> -	void *p_ctx = rte_eth_dev_get_sec_ctx(portid);
> +	void *p_ctx;
>  	const struct rte_security_capability *s_cap;
>  
> +	if (inline_offload)
> +		p_ctx = rte_eth_dev_get_sec_ctx(portid);
> +	else
> +		p_ctx = rte_cryptodev_get_sec_ctx(portid);
> +
>  	if (p_ctx == NULL)
>  		return;
>  
> @@ -859,7 +864,7 @@ show_port(void)
>  		}
>  
>  #ifdef RTE_LIB_SECURITY
> -		show_security_context(i);
> +		show_security_context(i, 1);
>  #endif
>  	}
>  }
> @@ -1224,7 +1229,7 @@ show_crypto(void)
>  		}
>  
>  #ifdef RTE_LIB_SECURITY
> -		show_security_context(i);
> +		show_security_context(i, 0);
>  #endif

It seems this new parameter would better be a boolean.




  reply	other threads:[~2021-01-15 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24  7:51 Hemant Agrawal
2021-01-15 11:25 ` Thomas Monjalon [this message]
2021-01-20  5:17 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2021-01-26 13:06   ` [dpdk-dev] [PATCH v3 1/1] app/procinfo: " Thomas Monjalon
2021-01-26 13:08     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8754871.pTA5GFj9IM@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).