From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 291905689 for ; Tue, 6 Jun 2017 09:16:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E49D20CC5; Tue, 6 Jun 2017 03:16:35 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 06 Jun 2017 03:16:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=50bV6KZ//uUimIV ncDXTswtXQvmqNI7L6tyDZJALMdA=; b=EsbAMEAUZUSNAeRmkauhqRXFx3O468b YaOUjRn7cJMkgBcb1PjWh4ghy0SBk99+Z1DFKcKLElpWUqPM5hRvrolTjgAP+vJz /AejqUmUoGIv9AaTZTkUIRyMEcqco1S6tX446lr83myc0XME7JiqLfFNfccFn067 HYrhaOUU0XrI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=50bV6KZ//uUimIVncDXTswtXQvmqNI7L6tyDZJALMdA=; b=Omb5FTPm kjYRECMzklH4tvzksfMcoIH6FMb4sR5ANedp4T8uKl8x6gKrjg8rFZLR7CXKm/Hn Kqm96ak1dF00KeBRiwPdN19rsroxTmb7PC2g99GRM0r0oioUjdVjcOximJ6yhyPL 5IaftDCoCil6hWj1pxUW+p1XPkV8ZbjEFyv2qlDG0+19EYBNJ8eFkpi7wlXcN+fI FLQCEWBKPIXrFLdK3u6walqzLMFjft2Cw4GEAA6dAmsVq0dt6wxAial9zbW5d5mH wK8dWlgORFIKyyra5L3KOwGtm5cGv4w+iHjxra3tRv1TZy893JMwBz+6AFHxDbsB 7fxJDaGPqmNXjA== X-ME-Sender: X-Sasl-enc: dq75+0nJhL4mHPL3o1yjXH5tnwm3jCYhnwdGooM85GeT 1496733395 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 121117E815; Tue, 6 Jun 2017 03:16:35 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org Date: Tue, 06 Jun 2017 09:16:34 +0200 Message-ID: <8755040.9J4WnU9ERX@xps> In-Reply-To: <20170606070213.GA32334@jerin> References: <20170606063650.31434-1-jerin.jacob@caviumnetworks.com> <1514064.RDqP8U0lKr@xps> <20170606070213.GA32334@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: allow exec-env specific targets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 07:16:36 -0000 06/06/2017 09:02, Jerin Jacob: > From: Thomas Monjalon > > 06/06/2017 08:36, Jerin Jacob: > > > Add a hook in generic rte.sdkbuild.mk file > > > to include exec-env specific targets. > > > > > > Signed-off-by: Jerin Jacob > > > --- > > > Useful in integrating some custom targets in nonstandard execution environments. > > > For example, a bare-metal-simulator exec execution environment may need > > > a target to run the dpdk applications. > > > --- > > > > This patch is just including an empty file. > > Do you like to add check for the file is present or not ? and if present, > invoke the file. The dash prefixing does the check: -include > > Please explain how it can help with a real example. > > We are evaluating on running DPDK on a nonstandard execution environment like > bare metal where I would to keep all my execution environment specific > change at following location. So that I can easy move around different > version of DPDK without merge conflict. > > $(RTE_SDK)mk/exec-env/my-exec-env > $(RTE_SDK)lib/librte_eal/my-exec-env > > I believe, The existing target like "exec-env-appinstall" in mk/exec-env/linuxapp/rte.app.mk, > solves the same purpose. I do not understand. If you want to add a new environment, why not just adding it?