From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 289EEA0547; Mon, 19 Apr 2021 03:39:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F033B40683; Mon, 19 Apr 2021 03:39:31 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id EF54240683 for ; Mon, 19 Apr 2021 03:39:30 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FNqF94pNNzlYTL; Mon, 19 Apr 2021 09:37:33 +0800 (CST) Received: from [10.78.49.194] (10.78.49.194) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 09:39:28 +0800 To: Ferruh Yigit , CC: , References: <1618562810-20304-1-git-send-email-oulijun@huawei.com> <1618628964-18913-1-git-send-email-oulijun@huawei.com> From: oulijun Message-ID: <87581b25-74be-eff2-7c01-0bc1aada8ca3@huawei.com> Date: Mon, 19 Apr 2021 09:39:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.49.194] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/18 6:00, Ferruh Yigit 写道: > On 4/17/2021 4:09 AM, Lijun Ou wrote: >> Currently, upper-layer application could get queue state only >> through pointers such as dev->data->tx_queue_state[queue_id], >> this is not the recommended way to access it. So this patch >> add get queue state when call rte_eth_rx_queue_info_get and >> rte_eth_tx_queue_info_get API. >> >> Note: After add queue_state field, the 'struct rte_eth_rxq_info' size >> remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so >> it could be ABI compatible. >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Lijun Ou >> Acked-by: Konstantin Ananyev >> --- >> V4->V5: >> - Add acked-by >> - add a note to the "New features" section to annouce the new feature. >> >> V3->V4: >> - update libabigail.abignore for removing the CI warnings >> >> V2->V3: >> - rewrite the commit log and delete the part Note >> - rewrite tht comments for queue state >> - move the queue_state definition locations >> >> V1->V2: >> - move queue state defines to public file >> --- >> doc/guides/rel_notes/release_21_05.rst | 6 ++++++ >> lib/librte_ethdev/ethdev_driver.h | 7 ------- >> lib/librte_ethdev/rte_ethdev.c | 3 +++ >> lib/librte_ethdev/rte_ethdev.h | 9 +++++++++ >> 4 files changed, 18 insertions(+), 7 deletions(-) > > missing 'libabigail.abignore' that was in v4? > . Yes. the CI is warning after I send the V3 with fix some comments. Then I update liabigail.bignore, taking into account your comments with thomas and send the V4. >