From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Joyce Kong <joyce.kong@arm.com>,
stephen@networkplumber.org, xiaolong.ye@intel.com,
tiwei.bie@intel.com, zhihong.wang@intel.com, thomas@monjalon.net,
jerinj@marvell.com, yinan.wang@intel.com,
honnappa.nagarahalli@arm.com, gavin.hu@arm.com
Cc: nd@arm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/2] one way barrier for split vring idx
Date: Thu, 30 Apr 2020 11:09:06 +0200 [thread overview]
Message-ID: <875c6c82-4460-b25d-fc7a-4f6d800f4c60@redhat.com> (raw)
In-Reply-To: <397e7aa5-f355-9790-6df6-91504be2b0ad@intel.com>
On 4/29/20 7:45 PM, Ferruh Yigit wrote:
> On 4/24/2020 4:39 AM, Joyce Kong wrote:
>> This patchset replaces the two-way barriers with C11 one-way barriers
>> for split vring idx, when the frontend and backend are implemented
>> in software.
>>
>> By doing PVP benchmarking, the test result of 2c1q showed the throughput
>> increased 20% with the 0.001% of acceptable loss rate on Thunderx2
>> platform.[1]
>>
>> By doing vhost-user + virtio-user case benchmarking, 4% performance gain
>> was measured on Thunderx2 platform by 2c1q RFC2544 test of 0.001% loss,
>> and 4.7% performance was improved on Dell platform by 1c1q RFC2544 test
>> of zero packet loss.[2]
>>
>> [1]https://doc.dpdk.org/guides/howto/pvp_reference_benchmark.html
>> [2]https://doc.dpdk.org/dts/test_plans/pvp_multi_paths_performance_test_plan.html
>> PVP test with virtio 1.0 normal path
>>
>> v4:
>> Remove some duplicated code comment.
>>
>> v3:
>> Modify some style error.
>>
>> v2:
>> Add test performance statistics.
>>
>> Joyce Kong (2):
>> virtio: one way barrier for split vring used idx
>> virtio: one way barrier for split vring avail idx
>>
>
> Hi Joyce,
>
> When 'CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=y' enabled, build fails. Can you
> please check it?
Hi Joyce,
I will need the fix today, just send a v5 for the series.
If not possible to do it today, please let me know.
Maxime
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2020-04-30 9:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 9:24 [dpdk-dev] [PATCH v1 " Joyce Kong
2020-02-12 9:24 ` [dpdk-dev] [PATCH v1 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-02-12 9:24 ` [dpdk-dev] [PATCH v1 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 0/2] one way barrier for split vring idx Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-02 15:47 ` Stephen Hemminger
2020-04-03 8:55 ` Gavin Hu
2020-04-16 4:40 ` Honnappa Nagarahalli
2020-04-16 6:46 ` Joyce Kong
2020-04-02 2:57 ` [dpdk-dev] [PATCH v2 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 0/2] one way barrier for split vring idx Joyce Kong
2020-04-16 9:08 ` Ye Xiaolong
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-17 6:51 ` Ye Xiaolong
2020-04-17 8:14 ` Joyce Kong
2020-04-06 15:26 ` [dpdk-dev] [PATCH v3 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 0/2] one way barrier for split vring idx Joyce Kong
2020-04-28 16:06 ` Maxime Coquelin
2020-04-29 17:45 ` Ferruh Yigit
2020-04-30 9:09 ` Maxime Coquelin [this message]
2020-04-30 9:16 ` Joyce Kong
2020-04-30 9:24 ` Maxime Coquelin
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-27 9:03 ` Maxime Coquelin
2020-04-24 3:39 ` [dpdk-dev] [PATCH v4 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
2020-04-27 9:03 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 0/2] one way barrier for split vring idx Joyce Kong
2020-04-30 20:54 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 1/2] virtio: one way barrier for split vring used idx Joyce Kong
2020-04-30 22:58 ` Ferruh Yigit
2020-05-04 10:04 ` Maxime Coquelin
2020-04-30 9:14 ` [dpdk-dev] [PATCH v5 2/2] virtio: one way barrier for split vring avail idx Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875c6c82-4460-b25d-fc7a-4f6d800f4c60@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=yinan.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).