From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DC8841B91; Tue, 31 Jan 2023 18:05:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 093B14067B; Tue, 31 Jan 2023 18:05:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E79F040041 for ; Tue, 31 Jan 2023 18:05:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675184710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m/zdXBh3iuOAAjhPkI1tkje533+azbJfBepWxySq7jE=; b=XOlYyKrlHL00SB6BPSjg4sn/lnYvZwOklZ1qZW+aTWeZSEVr60CWbGiecLutfTP8tk9WnS CcaUhUnpdAf91UWEg1HYyTL4GGD2BZRXHmPkktAm+GC9Yhuczhbh2LmJB4FnDRIPmxuUj+ Aaku6sfP2gcJgweGjPFNIWEGIULHhk0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-494-Prup5zeoPoGCngyhHAZWbA-1; Tue, 31 Jan 2023 12:05:07 -0500 X-MC-Unique: Prup5zeoPoGCngyhHAZWbA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2948685A588; Tue, 31 Jan 2023 17:05:07 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E0A6714171B6; Tue, 31 Jan 2023 17:05:05 +0000 (UTC) Message-ID: <875cdf20-d4a3-53d7-526c-2920bce6ed2b@redhat.com> Date: Tue, 31 Jan 2023 18:05:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4 7/9] vhost: annotate IOTLB lock To: David Marchand , dev@dpdk.org Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-8-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20230119184620.3195267-8-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/23 19:46, David Marchand wrote: > The starting point for this is __vhost_iova_to_vva() which requires the > lock to be taken. Annotate all the code leading to a call to it. > > vdpa and vhost_crypto code are annotated but they end up not taking > a IOTLB lock and have been marked with a FIXME at the top level. > > Signed-off-by: David Marchand > --- > Changes since RFC v3: > - rebased, > - moved unconditionnal lock acquire in separate patch, > - fixed annotations, > > --- > lib/vhost/iotlb.h | 4 ++++ > lib/vhost/vdpa.c | 1 + > lib/vhost/vhost.c | 8 +++----- > lib/vhost/vhost.h | 22 ++++++++++++++++------ > lib/vhost/vhost_crypto.c | 8 ++++++++ > lib/vhost/virtio_net.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 72 insertions(+), 11 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime