Re: [PATCH 1/4] lib/power: add get and set API for emptypoll max

[Ray Kinsella <mdr@ashroe.eu>]

Kevin Laatz <kevin.laatz@intel.com> writes:

> Add new get/set APIs to configure emptypoll max which is used to
> determine when a queue can go into sleep state.
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
>  lib/power/rte_power_pmd_mgmt.c | 21 ++++++++++++++++++---
>  lib/power/rte_power_pmd_mgmt.h | 27 +++++++++++++++++++++++++++
>  lib/power/version.map          |  4 ++++
>  3 files changed, 49 insertions(+), 3 deletions(-)
>
> diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
> index 39a2b4cd23..dfb7ca9187 100644
> --- a/lib/power/rte_power_pmd_mgmt.c
> +++ b/lib/power/rte_power_pmd_mgmt.c
> @@ -11,7 +11,7 @@
>  
>  #include "rte_power_pmd_mgmt.h"
>  
> -#define EMPTYPOLL_MAX  512
> +unsigned int emptypoll_max;
>  
>  /* store some internal state */
>  static struct pmd_conf_data {
> @@ -206,7 +206,7 @@ queue_can_sleep(struct pmd_core_cfg *cfg, struct queue_list_entry *qcfg)
>  	qcfg->n_empty_polls++;
>  
>  	/* if we haven't reached threshold for empty polls, we can't sleep */
> -	if (qcfg->n_empty_polls <= EMPTYPOLL_MAX)
> +	if (qcfg->n_empty_polls <= emptypoll_max)
>  		return false;
>  
>  	/*
> @@ -290,7 +290,7 @@ clb_umwait(uint16_t port_id, uint16_t qidx, struct rte_mbuf **pkts __rte_unused,
>  	/* this callback can't do more than one queue, omit multiqueue logic */
>  	if (unlikely(nb_rx == 0)) {
>  		queue_conf->n_empty_polls++;
> -		if (unlikely(queue_conf->n_empty_polls > EMPTYPOLL_MAX)) {
> +		if (unlikely(queue_conf->n_empty_polls > emptypoll_max)) {
>  			struct rte_power_monitor_cond pmc;
>  			int ret;
>  
> @@ -661,6 +661,18 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
>  	return 0;
>  }
>  
> +void
> +rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max)
> +{
> +	emptypoll_max = max;
> +}
> +
> +unsigned int
> +rte_power_pmd_mgmt_get_emptypoll_max(void)
> +{
> +	return emptypoll_max;
> +}
> +
>  RTE_INIT(rte_power_ethdev_pmgmt_init) {
>  	size_t i;
>  
> @@ -669,4 +681,7 @@ RTE_INIT(rte_power_ethdev_pmgmt_init) {
>  		struct pmd_core_cfg *cfg = &lcore_cfgs[i];
>  		TAILQ_INIT(&cfg->head);
>  	}
> +
> +	/* initialize config defaults */
> +	emptypoll_max = 512;
>  }
> diff --git a/lib/power/rte_power_pmd_mgmt.h b/lib/power/rte_power_pmd_mgmt.h
> index 444e7b8a66..d5a94f8187 100644
> --- a/lib/power/rte_power_pmd_mgmt.h
> +++ b/lib/power/rte_power_pmd_mgmt.h
> @@ -90,6 +90,33 @@ int
>  rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
>  		uint16_t port_id, uint16_t queue_id);
>  
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
> + *
> + * Set a emptypoll_max to specified value. Used to specify the number of empty
> + * polls to wait before entering sleep state.
> + *
> + * @param max
> + *   The value to set emptypoll_max to.
> + */
> +__rte_experimental
> +void
> +rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max);
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
> + *
> + * Get the current value of emptypoll_max.
> + *
> + * @return
> + *   The current emptypoll_max value
> + */
> +__rte_experimental
> +unsigned int
> +rte_power_pmd_mgmt_get_emptypoll_max(void);
> +
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/lib/power/version.map b/lib/power/version.map
> index 6ec6d5d96d..8bcd497e06 100644
> --- a/lib/power/version.map
> +++ b/lib/power/version.map
> @@ -38,4 +38,8 @@ EXPERIMENTAL {
>  	# added in 21.02
>  	rte_power_ethdev_pmgmt_queue_disable;
>  	rte_power_ethdev_pmgmt_queue_enable;
> +
> +	# added in 22.07
> +	rte_power_pmd_mgmt_set_emptypoll_max;
> +	rte_power_pmd_mgmt_get_emptypoll_max;

minor niggle, get then set. 

>  };


-- 
Regards, Ray K