From: fengchengwen <fengchengwen@huawei.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Subject: Re: [PATCH] argparse: fix parser callback type name
Date: Fri, 8 Mar 2024 08:49:04 +0800 [thread overview]
Message-ID: <87770ef7-a4b4-f08b-8510-d3366da2310d@huawei.com> (raw)
In-Reply-To: <20240307161402.1460071-1-david.marchand@redhat.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/8 0:14, David Marchand wrote:
> All types exposed in a public header must be prefixed with rte_.
>
> Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/argparse/rte_argparse.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/argparse/rte_argparse.h b/lib/argparse/rte_argparse.h
> index 47e231bef9..5e5936f96c 100644
> --- a/lib/argparse/rte_argparse.h
> +++ b/lib/argparse/rte_argparse.h
> @@ -144,7 +144,7 @@ struct rte_argparse_arg {
> * @return
> * 0 on success. Otherwise negative value is returned.
> */
> -typedef int (*arg_parser_t)(uint32_t index, const char *value, void *opaque);
> +typedef int (*rte_arg_parser_t)(uint32_t index, const char *value, void *opaque);
>
> /**
> * A structure used to hold argparse's configuration.
> @@ -161,7 +161,7 @@ struct rte_argparse {
> /** Whether exit when error. */
> bool exit_on_error;
> /** User callback for parsing arguments. */
> - arg_parser_t callback;
> + rte_arg_parser_t callback;
> /** Opaque which used to invoke callback. */
> void *opaque;
> /** Reserved field used for future extension. */
>
prev parent reply other threads:[~2024-03-08 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 16:14 David Marchand
2024-03-07 17:50 ` Tyler Retzlaff
2024-03-21 17:20 ` Thomas Monjalon
2024-03-08 0:49 ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87770ef7-a4b4-f08b-8510-d3366da2310d@huawei.com \
--to=fengchengwen@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).