From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB93E43B97; Fri, 8 Mar 2024 01:49:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 741E640291; Fri, 8 Mar 2024 01:49:10 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 2B62F40284 for ; Fri, 8 Mar 2024 01:49:07 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TrSG01xwgz1vwBG; Fri, 8 Mar 2024 08:48:24 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 2FA711A0172; Fri, 8 Mar 2024 08:49:05 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 8 Mar 2024 08:49:04 +0800 Subject: Re: [PATCH] argparse: fix parser callback type name To: David Marchand , References: <20240307161402.1460071-1-david.marchand@redhat.com> From: fengchengwen Message-ID: <87770ef7-a4b4-f08b-8510-d3366da2310d@huawei.com> Date: Fri, 8 Mar 2024 08:49:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20240307161402.1460071-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2024/3/8 0:14, David Marchand wrote: > All types exposed in a public header must be prefixed with rte_. > > Fixes: e3e579f5bab5 ("argparse: introduce argparse library") > > Signed-off-by: David Marchand > --- > lib/argparse/rte_argparse.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/argparse/rte_argparse.h b/lib/argparse/rte_argparse.h > index 47e231bef9..5e5936f96c 100644 > --- a/lib/argparse/rte_argparse.h > +++ b/lib/argparse/rte_argparse.h > @@ -144,7 +144,7 @@ struct rte_argparse_arg { > * @return > * 0 on success. Otherwise negative value is returned. > */ > -typedef int (*arg_parser_t)(uint32_t index, const char *value, void *opaque); > +typedef int (*rte_arg_parser_t)(uint32_t index, const char *value, void *opaque); > > /** > * A structure used to hold argparse's configuration. > @@ -161,7 +161,7 @@ struct rte_argparse { > /** Whether exit when error. */ > bool exit_on_error; > /** User callback for parsing arguments. */ > - arg_parser_t callback; > + rte_arg_parser_t callback; > /** Opaque which used to invoke callback. */ > void *opaque; > /** Reserved field used for future extension. */ >