From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7CD4F1B28B for ; Mon, 29 Jan 2018 12:56:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2F42E20AC6; Mon, 29 Jan 2018 06:56:23 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 29 Jan 2018 06:56:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=I1NZnBOKGrPlZwJkbveczZ27/g pleE/tY+xuzPZUgDA=; b=B2FUlIjuksxlGpT0oJHKr4q6JxyPlseLogNO7nh3DJ 667kEHNABaaZ6cyfSnLug1iHjdg+2dwSqHGjIU54Lj3hye/ekn1x6elftaJlDa/q K0PpBGU0UwbvH0LUvtblu0aSrmpj4+dqUxCFak+wsLzzSW1wzERLVK6YkJ5XXC1S w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=I1NZnB OKGrPlZwJkbveczZ27/gpleE/tY+xuzPZUgDA=; b=dJfAG21lHDgTeuiOPP+5IU HTFSjl5+ECcxd6EaeTOPcH09nR+K0JNGo+NPynw2/jQPUq+tDEOsO2yk9hoPTXG7 9mDHQ+i+m44g+3qcRTwlDRZ19ZC897XSYtWcJpdBOBbeXdcokFMbaex4htNfrSRI H9Jo4bHTeWgLQ1JoK6KK4Umh0TBH3I+MeAKxLbC/Q27Pd2ZIyZWzHTHdH8dMWZLJ vwVBoCY4q76310xEZQRNPpk9O98MyAMzV1oEotI5OiKds88Ae7w+cSAKLIBOI/5+ Hfd9BJOOsRO2dwOV3TouCUAob8JYllhLZPFh8XbJWvsud+GlvexXUItQ0l3CKhPQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5BDA7E650; Mon, 29 Jan 2018 06:56:22 -0500 (EST) From: Thomas Monjalon To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "Varghese, Vipin" Date: Mon, 29 Jan 2018 12:55:35 +0100 Message-ID: <8777922.WAhnjB1RAy@xps> In-Reply-To: References: <1517077877-53654-1-git-send-email-harry.van.haaren@intel.com> <3800883.jMHuFJQnlm@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] eal: add function to release internal resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 11:56:23 -0000 29/01/2018 12:10, Van Haaren, Harry: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Monday, January 29, 2018 10:56 AM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Varghese, Vipin > > Subject: Re: [PATCH v2 2/4] eal: add function to release internal resources > > > > 29/01/2018 11:45, Harry van Haaren: > > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > > +Finalizing and Cleanup > > > +~~~~~~~~~~~~~~~~~~~~~~ > > > + > > > +During the initialization of EAL resources such as hugepage backed memory > > can be > > > +allocated by core components. The memory allocated during > > ``rte_eal_init()`` > > > +can be released by calling the ``rte_eal_finalize()`` function. Refer to > > the > > > +API documentation for details. > > > > About naming, what is better between > > rte_eal_finalize() and > > rte_eal_cleanup() ? > > I tend to think that "cleanup" is more descriptive. > > Sure cleanup() is fine for me, I'll spin a v3 with the function name change. Harry, it is a real question! If someone thinks "finalize" is better, I would like to hear it because we may use the same wording in more DPDK functions.