From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9227143C3B; Thu, 29 Feb 2024 15:50:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7FFC342D78; Thu, 29 Feb 2024 15:50:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 072F9402B4 for ; Thu, 29 Feb 2024 15:50:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709218210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kEdib4uFZKzbAhsl7YNJ3xMD6EN/VqRjspEVyktoC9s=; b=AhHrcvn0V2uLmFIRi9wc225tTWu/XfWMmGbwEyM3+Ogl0Y4c8mouyRW7Yw178qK/V+u599 ztQX3uKPD0tn636XIKorr30miI7L0h9O22yR/gYakcvcqp8CTeZk8QtDCjSpIg2qy3nsbA GdelzIK89V4ZeOFholl4Bww5tYC1+Y4= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-rW0i6Yk4NB-B5F7v58Rjbg-1; Thu, 29 Feb 2024 09:50:09 -0500 X-MC-Unique: rW0i6Yk4NB-B5F7v58Rjbg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6901eddd100so10319486d6.1 for ; Thu, 29 Feb 2024 06:50:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709218209; x=1709823009; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:organization:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B6MYPuqTgOa4ckaswOr7aiB5TLazu/E0u2mGGZ67kPs=; b=eklrOFIB0zWNHtiT3wSGkFHoyMuOx4+g1j+ZuauycmYlgTa+EXe8Zj9vNlu+q6fgQB NyMpnyUkZFSpvCRUy8AFemrA44aD9IdAull9iINF9fHg0ixP2Y67/2vUfSpD8EuNF1cd g9tDhM6po6Tkt0dbaULHmwVuIeAvhULQzKKg6fl7DCS3eKAyBzkV1ZXvCw7cuEbzzQ2Z onDxA5qE0Wsich40/yE3qTNj81Wx5RouJgUiOOJUg413pGoiV+2w/BQJJTgJcJdv3zxC rOfcgRyjcHP00J9YzBdS+nAqhJHlH9WPiG0FDWEV72d+W5n7JcIsHwggUXwYJREVRo5e JAMw== X-Gm-Message-State: AOJu0Yy9gN2RwKLCdZQny+ivVyR4ERQGStYVYKsoF8dZiu49+S8G3G4M i4vJ21Rvdh1cjQuG5EVhr7yVePEVoX1SNyUtY0hzPTEnWJqGIVYvi1Xbd1KKmRuiKou7e8glwXp q+7I0Qm9iko3gnN1uaHl57mPCkMeTLVLu0mVDL80q X-Received: by 2002:a0c:de01:0:b0:68f:e87e:6be5 with SMTP id t1-20020a0cde01000000b0068fe87e6be5mr2538072qvk.39.1709218208917; Thu, 29 Feb 2024 06:50:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEd3FughlnBvuVj2B1EJf/28gbhiCSRF8ourNHuQgKXUxrKqz0EoHiOayd+QzNHr2OH6yVbUQ== X-Received: by 2002:a0c:de01:0:b0:68f:e87e:6be5 with SMTP id t1-20020a0cde01000000b0068fe87e6be5mr2538039qvk.39.1709218208637; Thu, 29 Feb 2024 06:50:08 -0800 (PST) Received: from localhost (88-120-130-27.subs.proxad.net. [88.120.130.27]) by smtp.gmail.com with ESMTPSA id nc3-20020a0562142dc300b006903ffb71ebsm816031qvb.17.2024.02.29.06.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 06:50:08 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id EA8BDB4FCA; Thu, 29 Feb 2024 15:50:05 +0100 (CET) From: Dodji Seketeli To: David Marchand Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com, Tyler Retzlaff , Thomas Monjalon Subject: Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields Organization: Red Hat / France References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com> <87cysgd6sy.fsf@redhat.com> X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Thu, 29 Feb 2024 15:50:05 +0100 In-Reply-To: (David Marchand's message of "Wed, 28 Feb 2024 15:43:46 +0100") Message-ID: <877cincoki.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > On Wed, Feb 28, 2024 at 3:04=E2=80=AFPM Dodji Seketeli = wrote: >> > Btw, I see no way to suppress this (except a global [suppress_type] >> > name =3D rte_mbuf)... >> >> Right. >> >> To avoid having subsequent changes to that type from being "overly" >> suppressed, maybe do something like: >> >> [suppress_type] >> name =3D rte_mbuf >> has_size_change =3D no >> has_data_member =3D {cacheline0, rearm_data, rx_descriptor_fields1,= cacheline1} >> >> That way, only size-impacting changes to struct rte_mbuf in its form >> that predates this patch would be suppressed, hopefully. > > Do you mean, only changes *not* size-impacting would be suppressed? Yes, of course. Sorry for the typo. You are right. > This is slightly better than the suppression on the whole rte_mbuf > object, but it won't catch field reordering iiuc. Indeed. > > On the other hand, now that I try reordering fields (to test this > suggestion of yours), I get build failures all over the DPDK tree > because we have many build checks to ensure those fields are at known > locations... > So maybe we can relax and just go with the full suppression. Yes, that would make sense. Thanks! --=20 =09=09Dodji