From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A01AEA0565; Tue, 10 Mar 2020 11:36:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 518991BFF8; Tue, 10 Mar 2020 11:36:29 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3BE981BFF5 for ; Tue, 10 Mar 2020 11:36:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583836587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z3J+ejg4RhDs47QhDE86j4tct+EP6hiRgaEuyehKtvA=; b=GSOniI/VJ+He9VHBJ3WqumyFjqTsPmQEgiZSxrSr0ueX5NdTh9btcWs6HP8yuKSkBsJY40 WufQe7WZIUAPoyb0e5o2ajVSsUyNGzupHFFAJMyIG+U/joYYQSlRLyXvj9GA68ZldXDshC XJfnBJ9lcV1QfI7qvQ9lBUbBL8A14O8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-iXH3R8qfOAegwQJj47Gzqw-1; Tue, 10 Mar 2020 06:36:24 -0400 X-MC-Unique: iXH3R8qfOAegwQJj47Gzqw-1 Received: by mail-wr1-f72.google.com with SMTP id w11so6586308wrp.20 for ; Tue, 10 Mar 2020 03:36:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=v37/ItYZyyX2VC/lIL85Q6IKb2e5d5ai8sHGfLzb9FU=; b=I/UhWe+KeNVp+1LnNJ7L/zPOfaxVXuI12JQfsGYPkbfaGHAqLJV843LIgVE+juK55f qEcH+tRVUjX+3qxazbr+DyxGwicDfOB3/AKk9nPgIjf8Wq6EXM4cW7bn+4VNKHMyMJNa qhfXBeG7yNXukocVyaasX3Tsf8k02IlEcJ5TIChg4OspAghLrip+s0TGxHmAwaqlwTah OSrC8eJNlYpgvjM+Axz6Bn4BYcT2jBQiPCymIIrJpYkUbeJkvFaVj1qzC+CBECRSzKvn pKvoSaZBhpMFcimOp9aEvpTb859TBEE3b27W8mlfXTEGqpVXEZHXpZQuApEEGZth+fHX whQA== X-Gm-Message-State: ANhLgQ2EotNa10HZuT6UiXqIGg0JnHr9knRsH8wOVB8wd00Q3c2nsbnq X9Ky/dL3Q4QKSR6eMQJjse+x55VJwkTzLU8fJm3TRW6diDLgDXHFwSVL1n5bb9t7Ac8+UBnxHw3 0XKo= X-Received: by 2002:a5d:4d10:: with SMTP id z16mr28397306wrt.271.1583836582719; Tue, 10 Mar 2020 03:36:22 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtbCc4K941Pls6KtESyu8nvE+b1rMbAapiLfcqtnQbEC9Hc408DzTzfXG2b46ER6brym5ED9Q== X-Received: by 2002:a5d:4d10:: with SMTP id z16mr28397272wrt.271.1583836582304; Tue, 10 Mar 2020 03:36:22 -0700 (PDT) Received: from localhost ([2a01:e0a:1a0:e090:ca5b:76ff:fecd:dce]) by smtp.gmail.com with ESMTPSA id 98sm4065468wrm.64.2020.03.10.03.36.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2020 03:36:21 -0700 (PDT) From: Dodji Seketeli X-Google-Original-From: Dodji Seketeli Received: by localhost (Postfix, from userid 1000) id 33CB318009B0; Tue, 10 Mar 2020 11:36:20 +0100 (CET) To: David Marchand Cc: "Hemant Agrawal \(OSS\)" , "Yigit\, Ferruh" , dev , Neil Horman , Thomas Monjalon Organization: Red Hat / France References: <20200302145829.27808-1-hemant.agrawal@nxp.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.redhat.com Date: Tue, 10 Mar 2020 11:36:20 +0100 In-Reply-To: (David Marchand's message of "Fri, 6 Mar 2020 11:12:07 +0100") Message-ID: <877dzscx97.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, David Marchand writes: > On Thu, Mar 5, 2020 at 10:19 AM Hemant Agrawal (OSS) > wrote: >> > On Thu, Mar 5, 2020 at 10:06 AM Hemant Agrawal (OSS) >> > wrote: >> > > >> > > Hi David, >> > > > On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal >> > > > wrote: >> > > > > >> > > > > This patch series add various patches for enhancing and fixing N= XP >> > > > > fslmc bus, dpaa bus, and dpaax. >> > > > > >> > > > > - the main change is support to allow thread migration across >> > > > > lcores >> > > > > - improving the multi-process support >> > > > >> > > > This series triggers an ABI warning that must be investigated. >> > > >https://travis-ci.com/ovsrobot/dpdk/jobs/292904119#L2233 >> > > >> > > [Hemant] >> > > As per the logs: >> > > >> > > Variables changes summary: 1 Removed, 2 Changed, 0 Added variables >> > > 1 Removed variable: >> > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs' >> > {per_lcore_dpaa2_held_bufs@@DPDK_20.0} >> > > 2 Changed variables: >> > > [C]'dpaa2_io_portal_t dpaa2_io_portal[128]' was changed at >> > dpaa2_hw_dpio.h:40:1: size of symbol changed from 5120 to 2048 >> > > [C]'dpaa2_io_portal_t per_lcore__dpaa2_io' was changed at >> > > dpaa2_hw_dpio.h:20:1: size of symbol changed from 40 to 16 >> > > >> > > Error: ABI issue reported for 'abidiff --suppr devtools/libabigail.a= bignore -- >> > no-added-syms --headers-dir1 reference/usr/local/include --headers-dir= 2 >> > install/usr/local/include reference/dump/librte_bus_fslmc.dump >> > install/dump/librte_bus_fslmc.dump' >> > > >> > > --------------- >> > > >> > > These changes are w.r.t modifications in internal structures and var= iables. >> > They may be ignored. >> > >> > The ABI check considers symbol exposed in headers available to final u= sers. >> > If those are internal, why are the headers public? >> > >> >> [Hemant] These symbols are not part of any public header files, but >> they are part of *.map files to share them between different driver >> libs i.e bus_fslmc and net_dpaa2 > > I would expect libabigail to skip those symbols, so there is something > I have missed in how --headers-dirX work. In libabigail speak, we make a difference between *ELF symbols* and types. --header-dirX is about telling the tool what the public *types* are. As you rightfully implied, types that are defined in files that are not found in the directories specified by --header-dirX are considered to be private types and are thus not shown in the ABI change report. ELF symbols however are a different matter. Header files don't usually define ELF symbols, be they variable of function symbols. Header files can at most declare variables or functions that would be actually defined elsewhere in source code, leading to the definition of ELF variable or function symbols in the final binary. At this point, we aren't talking about types anymore, as the ELF format doesn't know what types (in C or any other language) are. So --header-dirX don't deal with ELF symbols. And from what I understand from the message quoted above, the changes we are talking about have to do with EFL variable symbols which size have changed. So in practise, these are global arrays (exposed by at the binary level as an ELF variable symbol of a given size) with public visibility which size have changed. So my guess would be that if you guys don't want these arrays to be part the binary interface of this library, they should probably be declared static at the C level and accessed through some accessor function or something like that. At least, that's my humble uninformed opinion. In the mean time, the tooling can be tought to ignore changes to these ELF symbols, as you you guys all know already. > Anyway, all of those symbols in dpaa are part of the driver ABI. > We are still missing a way to mark internal symbols. > Neil had posted a framework for this > http://patchwork.dpdk.org/project/dpdk/list/?series=3D5004. > > In order to get this series passing the checks, I recommend NXP > rebasing Neil scripts (I will help reviewing this part), then mark all > those symbols as internal in its drivers. > Other vendor will convert their drivers later, as there is no need at > the moment. > > Thanks. Cheers, --=20 =09=09Dodji