DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] lib/librte_eal: Fix compile issue with gcc 5.3.1
Date: Thu, 28 Jan 2016 09:30:43 +0100	[thread overview]
Message-ID: <8781190.9aSToTMefL@xps13> (raw)
In-Reply-To: <1453966234-10577-1-git-send-email-michael.qiu@intel.com>

2016-01-28 15:30, Michael Qiu:
> In fedora 22 with GCC version 5.3.1, when compile,
> will result an error:
> 
>     include/rte_memcpy.h:309:7: error: "RTE_MACHINE_CPUFLAG_AVX2"
>                                 is not defined [-Werror=undef]
>     #elif RTE_MACHINE_CPUFLAG_AVX2
> 
> Fixes: 9484092baad3 ("eal/x86: optimize memcpy for AVX512 platforms")

Thanks for the quick fix.

Note about the title formatting:
As you see in the "Fixes:" line, the title of the original commit
was starting with "eal/x86". Yours should adopt the same convention.
A lot of patches are sent with "lib/librte_eal" which was never used
in the git history. If not sure when writing the title, please check
the history to keep it consistent.
As usual, I will reword it.
Thanks for your attention

  parent reply	other threads:[~2016-01-28  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  7:30 Michael Qiu
2016-01-28  8:01 ` Wang, Zhihong
2016-01-28  8:34   ` Thomas Monjalon
2016-01-28  8:30 ` Thomas Monjalon [this message]
2016-01-28  8:37   ` Qiu, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8781190.9aSToTMefL@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=michael.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).