From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0CB4AA0096 for ; Tue, 4 Jun 2019 23:12:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 209351B997; Tue, 4 Jun 2019 23:12:35 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 885B91B995 for ; Tue, 4 Jun 2019 23:12:33 +0200 (CEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x54L2Ca5132545 for ; Tue, 4 Jun 2019 17:12:32 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sx074rcpp-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 04 Jun 2019 17:12:32 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Jun 2019 22:12:31 +0100 Received: from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 4 Jun 2019 22:12:28 +0100 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x54LCRwF28836276 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Jun 2019 21:12:27 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4EBB6136053; Tue, 4 Jun 2019 21:12:27 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1CD9913604F; Tue, 4 Jun 2019 21:12:27 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.16.170.189]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 4 Jun 2019 21:12:27 +0000 (GMT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 04 Jun 2019 14:13:26 -0700 From: dwilder To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , pradeep@us.ibm.com, drc@ibm.com In-Reply-To: <2400087.3yNoXGUXWg@xps> References: <20190524160404.15896-1-dwilder@us.ibm.com> <1864604.tGcSgmW0Rt@xps> <2400087.3yNoXGUXWg@xps> X-Sender: dwilder@us.ibm.com User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 19060421-0020-0000-0000-00000EF437F4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011215; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01213277; UDB=6.00637671; IPR=6.00994344; MB=3.00027185; MTD=3.00000008; XFM=3.00000015; UTC=2019-06-04 21:12:29 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19060421-0021-0000-0000-00006618EBBD Message-Id: <8796da061923771665304cd0da62ff4d@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-04_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=802 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906040133 Subject: Re: [dpdk-dev] [PATCH] meson: Update flags and values for ppc_64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019-06-04 14:04, Thomas Monjalon wrote: > 04/06/2019 22:25, dwilder: >> On 2019-06-03 15:30, Thomas Monjalon wrote: >> > 27/05/2019 11:41, Bruce Richardson: >> >> On Fri, May 24, 2019 at 09:04:04AM -0700, David Wilder wrote: >> >> > Setting RTE_MAX_LCORE to reflect the largest available configuration. >> >> > Adding defines for missing RTE_MACHINE_CPUFLAGs. >> >> > >> >> > Signed-off-by: David Wilder >> >> > --- >> >> > --- a/config/ppc_64/meson.build >> >> > +++ b/config/ppc_64/meson.build >> >> > # overrides specific to ppc64 >> >> > -dpdk_conf.set('RTE_MAX_LCORE', 256) >> >> > +dpdk_conf.set('RTE_MAX_LCORE', 1536) >> >> > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) >> >> > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128) >> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1) >> >> > +dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1) >> >> >> >> Acked-by: Bruce Richardson >> > >> > >> > Suggested title: >> > config: update for ppc build with meson >> > >> > Why config/defconfig_ppc_64-power8-linuxapp-gcc is not updated as well >> > for RTE_MAX_LCORE? >> >> Hi Thomas >> I am taking the opportunity to update RTE_MAX_LCORE for future >> releases >> of dpdk. As we are switching to meson builds soon so this is an >> appropriate opportunity to update the value and keep in step with the >> hardware. Older stable release can continue to use the smaller value >> found in deconfig.. > > I don't understand the logic. > You are updating only the new release. > Some users may use make and others meson. > There is no reason they don't have the same config. Fair enough, if make will continue to be supported then both methods need updating. I will resubmit with you suggestions.