From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E3EC72C30 for ; Mon, 6 Jun 2016 10:31:49 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 06 Jun 2016 01:31:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,426,1459839600"; d="scan'208";a="116733848" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by fmsmga004.fm.intel.com with ESMTP; 06 Jun 2016 01:31:46 -0700 To: Yuanhan Liu References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <1464861277-130265-1-git-send-email-jianfeng.tan@intel.com> <1464861277-130265-7-git-send-email-jianfeng.tan@intel.com> <20160606080102.GZ10038@yliu-dev.sh.intel.com> Cc: dev@dpdk.org, Huawei Xie , rich.lane@bigswitch.com, mst@redhat.com, nakajima.yoshihiro@lab.ntt.co.jp, p.fedin@samsung.com, ann.zhuangyanying@huawei.com, mukawa@igel.co.jp, nhorman@tuxdriver.com From: "Tan, Jianfeng" Message-ID: <87a1a5cd-c07f-f16e-97c6-16648edf3ea3@intel.com> Date: Mon, 6 Jun 2016 16:31:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160606080102.GZ10038@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 6/7] virtio-user: add new virtual pci driver for virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2016 08:31:50 -0000 Hi Yuanhan, On 6/6/2016 4:01 PM, Yuanhan Liu wrote: > On Thu, Jun 02, 2016 at 09:54:36AM +0000, Jianfeng Tan wrote: >> + >> + desc_addr = (uint64_t)vq->mz->addr; >> + avail_addr = desc_addr + vq->vq_nentries * sizeof(struct vring_desc); >> + used_addr = RTE_ALIGN_CEIL(avail_addr + offsetof(struct vring_avail, >> + ring[vq->vq_nentries]), >> + VIRTIO_PCI_VRING_ALIGN); >> + >> + dev->vrings[queue_idx].num = vq->vq_nentries; >> + dev->vrings[queue_idx].desc = (void *)desc_addr; >> + dev->vrings[queue_idx].avail = (void *)avail_addr; >> + dev->vrings[queue_idx].used = (void *)used_addr; > That would break 32 bit build. please also do more build and function > test, with and without CONFIG_RTE_VIRTIO_VDEV enabled, to make sure > we will not break anything. I'm sure you will meet build error without > that option enabled. Yes, thanks for pointing this out. > > BTW, let's be consistent with using VIRTIO_USER_DEV instead of VDEV > or VIRTIO_VDEV? OK. > > Another thing that might be a bit late to ask is that how about > removing the vhost-net support? I mean, it's DPDK; if user stick > to using DPDK virtio-user, he will stick to using DPDK vhost-user > as well, but not the vhost-net. So, let's keep it being simple > first. And if there is really a need for vhost-net, we can add it > back later, easily. Makes sense? Yes, it makes sense, because from an initial test, I see low performance. Or anyone who are willing to use it can comment? Thanks, Jianfeng > > I also would suggest you do a rebase based on my latest tree. No problem. Thanks, Jianfeng > > --yliu