From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57305A0524; Fri, 5 Feb 2021 18:51:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FF171888EE; Fri, 5 Feb 2021 18:51:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5CA76188715 for ; Fri, 5 Feb 2021 18:51:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612547466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qiynEPMXalgbWRmSOI+x2vx6qRnA0k7X/Ek+tpp+Mq8=; b=ZNJpvrtC5r9kA9iCqyQWKTb5UDQssq1G3m5gwcCUWe5+9hyi1cCk99ud47hK8etQcX/WWL kjfj4Hb66bWCJCndtRMSdP0HTQuHs+9C6FIKWCb93kdCXorXUgziwaXFPU0RN/XKQ27g1x DEUZPEylSbJN3gX/Tj3kcDUPT+5VWfY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-IzuiCp8IMy-0w-29d_Skdw-1; Fri, 05 Feb 2021 12:51:02 -0500 X-MC-Unique: IzuiCp8IMy-0w-29d_Skdw-1 Received: by mail-wr1-f70.google.com with SMTP id j8so5728504wrx.17 for ; Fri, 05 Feb 2021 09:51:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=qiynEPMXalgbWRmSOI+x2vx6qRnA0k7X/Ek+tpp+Mq8=; b=ZmzA3H5AU4iTUusnS5pDuC3DR0mNW96GtapijzhO3oLk4NG7uLUJzpPnluYshFwhsk BAyZ9g9LUMq81bbG0dDXapCgkI4H6bZZyHimJZgn56fQt/LxsZM9+Zn6xLipsybD3MH4 cg+bap2byaJyAwIMBNsrALF42Lpox87dBzukX3gWYRl3/V4pXiZ+qGSmqPPe0uzdx3A1 EloEiQcfM0q+44+UvyufXAhNEREJAIAMLZ6ho+5Q3G3KbWcXxhZVxvqB8PTTdNQXx0/d nhHEe7deOJM26C+h91U9esCvdoeYpRYvmJ3KfxNX461IuHhEUKmf676mSEoYZVDq3L7D jCPQ== X-Gm-Message-State: AOAM530Vhk8Tu9tfQ7VJ3lexYgQZMDEZwOVi8VCxusI2k2aiXqRoXy6j E39rVxRRgxMgkQtfihus6+b30e3Q6x34DQYFAarMtcZC5GJQeCmd4DUpdWkHxnEkk+ev3VVnIuL 4v+s= X-Received: by 2002:a05:600c:35c9:: with SMTP id r9mr552017wmq.0.1612547461656; Fri, 05 Feb 2021 09:51:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5W+yqUlo+FIyXNr2RnoPympDs5lVePC5gbuvLsciv3EVqkKI47SuE4NPLDy1ZalmryNelPQ== X-Received: by 2002:a05:600c:35c9:: with SMTP id r9mr552010wmq.0.1612547461280; Fri, 05 Feb 2021 09:51:01 -0800 (PST) Received: from localhost (net-37-116-32-78.cust.vodafonedsl.it. [37.116.32.78]) by smtp.gmail.com with ESMTPSA id n4sm12792462wrt.47.2021.02.05.09.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 09:51:00 -0800 (PST) From: Paolo Valerio To: Haiyue Wang , dev@dpdk.org Cc: aconole@redhat.com, david.marchand@redhat.com, qi.z.zhang@intel.com, leyi.rong@intel.com, Lijuan.Tu@intel.com, Ruifeng.Wang@arm.com, Feifei.Wang2@arm.com, Haiyue Wang , stable@dpdk.org, Jeff Guo , Bruce Richardson , Konstantin Ananyev Cc: In-Reply-To: <20210204143949.22827-1-haiyue.wang@intel.com> References: <20210202070652.145861-1-haiyue.wang@intel.com> <20210204143949.22827-1-haiyue.wang@intel.com> Date: Fri, 05 Feb 2021 18:50:56 +0100 Message-ID: <87a6siz9mn.fsf@fed.void> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pvalerio@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Haiyue, Haiyue Wang writes: > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, > so the software application will then have to recompute the checksum > itself if needed. > > Bugzilla ID: 629 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Reported-by: Paolo Valerio > Signed-off-by: Haiyue Wang > --- > v3: Update the hardware errata doc name and session > v2: Change the always GOOD checksum to UNKOWN if BAD. > --- > doc/guides/nics/ixgbe.rst | 10 ++++++++ > drivers/net/ixgbe/ixgbe_rxtx.c | 30 ++++++++++++++++++++---- > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 32 +++++++++++++++++++++++--- > 4 files changed, 67 insertions(+), 7 deletions(-) Tested it successfully with OvS ct() action and testpmd. Thanks, Paolo