From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id E9C351B938;
 Fri, 14 Dec 2018 10:15:50 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 06586C05251D;
 Fri, 14 Dec 2018 09:15:50 +0000 (UTC)
Received: from [10.36.112.58] (ovpn-112-58.ams2.redhat.com [10.36.112.58])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id BCF17662F3;
 Fri, 14 Dec 2018 09:15:46 +0000 (UTC)
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, przemyslawx.lal@intel.com,
 kuralamudhan.ramakrishnan@intel.com, ivan.coughlan@intel.com,
 tiwei.bie@intel.com, ray.kinsella@intel.com, stable@dpdk.org
References: <cover.1544701282.git.anatoly.burakov@intel.com>
 <633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <87ac960b-9836-d461-36c0-b0484d9fc5fb@redhat.com>
Date: Fri, 14 Dec 2018 10:15:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <633b56ce7ee5551bfc456bd2f7968fd2f61b7529.1544701282.git.anatoly.burakov@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.31]); Fri, 14 Dec 2018 09:15:50 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v3 1/5] mem: fix error code for segment fd
 API for external segs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 09:15:51 -0000



On 12/13/18 12:43 PM, Anatoly Burakov wrote:
> Segment fd API does not support getting segment fd's from
> externally allocated memory, so return proper error code
> on any attempts to do so. This changes API behavior, so
> document the change as well.
> 
> Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> 
> Notes:
>      The API is experimental, no deprecation notice needed.
> 
>   doc/guides/rel_notes/release_19_02.rst    |  6 ++++++
>   lib/librte_eal/common/eal_common_memory.c | 12 ++++++++++++
>   2 files changed, 18 insertions(+)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime