From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A797AA0579; Wed, 7 Apr 2021 12:19:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25377140ED1; Wed, 7 Apr 2021 12:19:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AF991406A3 for ; Wed, 7 Apr 2021 12:19:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617790758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLf9kLGmvxqDlyJfvpnjK2jdd9JqnehCxsal0hJC0KI=; b=SCnmNdCRffdfh2RO6aynp/AoNAfcfYwbugQBsG1JQNiwlqEKlx/f4PFIuAChzFdOz5RsMC fb6jbwyEJGOVd47+liV/eo1TasSvY3xs2Kx8Zvy8J6mAYrESCXkszwY3r+k0wdot7OcS+e 2icP20wC9avV2WgqcUja4qNCw8HNZeA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-RLBo8HOTNgm2Bvo8BYWuig-1; Wed, 07 Apr 2021 06:19:16 -0400 X-MC-Unique: RLBo8HOTNgm2Bvo8BYWuig-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AF9210054F6 for ; Wed, 7 Apr 2021 10:19:16 +0000 (UTC) Received: from bnemeth.users.ipa.redhat.com (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A9005D9CA; Wed, 7 Apr 2021 10:19:15 +0000 (UTC) From: Balazs Nemeth To: bnemeth@redhat.com, dev@dpdk.org Date: Wed, 7 Apr 2021 12:17:20 +0200 Message-Id: <87be741c28c8d93a4cf93dc1af556cd4ead687ed.1617790501.git.bnemeth@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bnemeth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2 3/4] vhost: allocate and free packets in bulk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that all allocation and freeing has been moved together, use the faster bulk versions instead of handling packets one by one. Signed-off-by: Balazs Nemeth --- lib/librte_vhost/virtio_net.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 496f750e3..2f0c97b91 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -2469,10 +2469,10 @@ virtio_dev_tx_packed(struct virtio_net *dev, { uint32_t pkt_idx = 0; uint32_t remained = count; - uint16_t i; - for (i = 0; i < count; ++i) - pkts[i] = rte_pktmbuf_alloc(mbuf_pool); + if (rte_pktmbuf_alloc_bulk(mbuf_pool, pkts, count)) { + return 0; + } do { rte_prefetch0(&vq->desc_packed[vq->last_avail_idx]); @@ -2497,8 +2497,9 @@ virtio_dev_tx_packed(struct virtio_net *dev, } while (remained); - for (i = pkt_idx; i < count; ++i) - rte_pktmbuf_free(pkts[i]); + if (pkt_idx != count) { + rte_pktmbuf_free_bulk(&pkts[pkt_idx], count - pkt_idx); + } if (vq->shadow_used_idx) { do_data_copy_dequeue(vq); -- 2.30.2