From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34AABA0511; Fri, 15 Apr 2022 16:36:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C02E34067E; Fri, 15 Apr 2022 16:36:18 +0200 (CEST) Received: from mail-108-mta217.mxroute.com (mail-108-mta217.mxroute.com [136.175.108.217]) by mails.dpdk.org (Postfix) with ESMTP id 767234067C for ; Fri, 15 Apr 2022 16:36:16 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta217.mxroute.com (ZoneMTA) with ESMTPSA id 1802da7300f000fe85.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 15 Apr 2022 14:36:13 +0000 X-Zone-Loop: 56ce4fe1ae94f257609cd294ec050b8bfcc358a3b9ec X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aV4BrPs120P3AqAfqBzxuTqBE8rw2eI5XYo2kGgDRE4=; b=K4Qf/YCTQHKe6CUpcRX94f7jbF w74FNOyBMvu3ba36A/wV0SJKLRUW3h5xsG67VRwCYVufff0IpxMNKzyPac/1lT32YnEOnwebhP7Mi eH2+aUp6xzH4lvJaFrp0hzcbDz8VibMR2xQTu8FbVMk1C49k+pbMzKiJQAUiGEkq3K5auIh7Ycrl5 ZzNjyjAX1pMK14XBibOZ5hs5etgrT29I/wRUoERBAZUnhu/gY4CnAmJyvXLYu4u1s6mI4M+mryOY9 W8AsBdpRZVaJA5ldB4jBlJYEFQlWEpEGaH0+KQ4PAk2Bt4/lO0csWYbZNjMfrCfVrhB5rkokSvkg5 Ft74gQ3w==; References: <20220412161605.837191-1-zhichaox.zeng@intel.com> <20220412175602.965278-1-zhichaox.zeng@intel.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: zhichaox.zeng@intel.com Cc: dev@dpdk.org, Haiyue Wang , David Marchand Subject: Re: [DPDK v3] net/ixgbe: promote MDIO API In-reply-to: <20220412175602.965278-1-zhichaox.zeng@intel.com> Date: Fri, 15 Apr 2022 10:36:10 -0400 Message-ID: <87bkx2pg6d.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org zhichaox.zeng@intel.com writes: > From: zhichao zeng > > Promote the MDIO APIs to be stable. > > Signed-off-by: zhichao zeng > --- > drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 ----- > drivers/net/ixgbe/version.map | 10 +++++----- > 2 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h > index eef6f6661c..426fe5845b 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h > @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port); > * - (-ENODEV) if *port* invalid. > * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed > */ > -__rte_experimental > int > rte_pmd_ixgbe_mdio_lock(uint16_t port); > > @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port); > * - (-ENOTSUP) if hardware doesn't support. > * - (-ENODEV) if *port* invalid. > */ > -__rte_experimental > int > rte_pmd_ixgbe_mdio_unlock(uint16_t port); > > @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port); > * - (-ENODEV) if *port* invalid. > * - (IXGBE_ERR_PHY) If PHY read command failed > */ > -__rte_experimental > int > rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr, > uint32_t dev_type, uint16_t *phy_data); > @@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr, > * - (-ENODEV) if *port* invalid. > * - (IXGBE_ERR_PHY) If PHY read command failed > */ > -__rte_experimental > int > rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr, > uint32_t dev_type, uint16_t phy_data); > @@ -725,7 +721,6 @@ enum { > * - (-ENODEV) if *port* invalid. > * - (-ENOTSUP) if hardware doesn't support this feature. > */ > -__rte_experimental > int > rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable); > > diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map > index bca5cc5826..f0f29d8749 100644 > --- a/drivers/net/ixgbe/version.map > +++ b/drivers/net/ixgbe/version.map > @@ -16,6 +16,10 @@ DPDK_22 { > rte_pmd_ixgbe_macsec_enable; > rte_pmd_ixgbe_macsec_select_rxsa; > rte_pmd_ixgbe_macsec_select_txsa; Promoted APIs should be part of the DPDK_23 ABI, not DPDK_22. David - I just did some checking and noted that we have been promoting directly from experimental to DPDK 22, and that we did the same for DPDK 21. However in the DPDK_20 we (rightly) promoted to DPDK_21, new APIs are promoted to being stable in the next ABI release. Was that I conscious decision? I don't thinking there is impact by the error / change, beyond house keeping. > + rte_pmd_ixgbe_mdio_lock; > + rte_pmd_ixgbe_mdio_unlock; > + rte_pmd_ixgbe_mdio_unlocked_read; > + rte_pmd_ixgbe_mdio_unlocked_write; > rte_pmd_ixgbe_ping_vf; > rte_pmd_ixgbe_set_all_queues_drop_en; > rte_pmd_ixgbe_set_tc_bw_alloc; > @@ -31,6 +35,7 @@ DPDK_22 { > rte_pmd_ixgbe_set_vf_vlan_filter; > rte_pmd_ixgbe_set_vf_vlan_insert; > rte_pmd_ixgbe_set_vf_vlan_stripq; > + rte_pmd_ixgbe_upd_fctrl_sbp; > > local: *; > }; > @@ -40,9 +45,4 @@ EXPERIMENTAL { > > rte_pmd_ixgbe_get_fdir_info; > rte_pmd_ixgbe_get_fdir_stats; > - rte_pmd_ixgbe_mdio_lock; > - rte_pmd_ixgbe_mdio_unlock; > - rte_pmd_ixgbe_mdio_unlocked_read; > - rte_pmd_ixgbe_mdio_unlocked_write; > - rte_pmd_ixgbe_upd_fctrl_sbp; > }; -- Regards, Ray K