From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65572A2E1B for ; Wed, 4 Sep 2019 21:21:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42DA41E977; Wed, 4 Sep 2019 21:21:33 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 5164B1E965 for ; Wed, 4 Sep 2019 21:21:31 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4EAEF680080; Wed, 4 Sep 2019 19:21:29 +0000 (UTC) Received: from [192.168.1.192] (188.242.181.57) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 4 Sep 2019 20:21:22 +0100 To: Thomas Monjalon , Ferruh Yigit , David Marchand CC: References: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> <6fd3bec6-15e4-33ed-4bd2-88d2ecaf6706@intel.com> <3044851.BoT7FmBCyV@xps> From: Andrew Rybchenko Message-ID: <87c65c82-87c8-374d-1b62-36e5bd02335a@solarflare.com> Date: Wed, 4 Sep 2019 22:21:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3044851.BoT7FmBCyV@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [188.242.181.57] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24888.003 X-TM-AS-Result: No-11.142000-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2qi6/VcDv9f0PZvT2zYoYOwofZV/2Xa0cIqWn7FcUtB0Lbm PrU3umuKMe0DVYEEbmz14S+auGbk+5ruKFYZRy6lcaD+wPaBYtZ6i696PjRPiC6tRzC7Nk0Txr9 BVGX2SHwNrQyInIkKQAH/6CIQ6zHMPXdZx1sZHpAFZev51JnVPWgII9q1LGOVwz01TBtmz96gqp 1qDDw0LuZsxEfXt9yMBWB/VcrYtAZfcD94Q+3uKO9VsdrlGzy3fS0Ip2eEHny+qryzYw2E8LLn+ 0Vm71Lcda/BQWxdCOYLbigRnpKlKSPzRlrdFGDwxhHnoLoYN/rZoP7ZsGVQ77FNprrmtRlcbETG wShK2nApiacUgrjWZA== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.142000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24888.003 X-MDID: 1567624890-qhctXoqPHgqY Subject: Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/4/19 8:45 PM, Thomas Monjalon wrote: > 03/09/2019 10:47, Ferruh Yigit: >> On 9/3/2019 9:06 AM, David Marchand wrote: >>> On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: >>>> On 8/19/2019 12:41 PM, David Marchand wrote: >>>>> The function rte_log_register_type_and_pick_level() fills a gap for >>>>> dynamically loaded code (especially drivers) who would not pick up >>>>> the log level passed at startup. >>>>> >>>>> Let's promote it to stable and export it for use by drivers via >>>>> a wrapper. >>>>> >>>>> Signed-off-by: David Marchand >>>>> --- > [...] >>>>> /** >>>>> - * @warning >>>>> - * @b EXPERIMENTAL: this API may change without prior notice >>>>> - * >>>>> * Register a dynamic log type and try to pick its level from EAL options > [...] >>>>> -__rte_experimental >>>>> int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def); >>>> +1 to remove experimental from the API. > I am not sure about this function API. > Why we combined register and level setting in one function? See [1] [1] http://git.dpdk.org/dpdk/commit/?id=b22e77c026