From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68F8943B7C; Wed, 28 Feb 2024 15:04:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5568F43332; Wed, 28 Feb 2024 15:04:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 515E64328B for ; Wed, 28 Feb 2024 15:04:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709129045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hIUn5nE1xV3XcoFpVsz/2fXkpKrW6i00+ShXSFY34HE=; b=F60K0LQW+zWnrVonH2/y2DrLLWDe2lcHKCYgk4uj9EXzJOM1wUQRZE8Bp3eyDaPO5RCf3a Dy+Z9RYa7iMOblgwRFOqEptopSFcRQBlAfeJpU1YaJfzigDg+repmk2PmGVrNi40r3lBAg Ml0Ld1JzIgY6qDtEK60W2qV6ARdDvxQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-_VQspEnnM9KSAyVqRv_MWQ-1; Wed, 28 Feb 2024 09:04:03 -0500 X-MC-Unique: _VQspEnnM9KSAyVqRv_MWQ-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-42e2506ac53so89903421cf.0 for ; Wed, 28 Feb 2024 06:04:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709129042; x=1709733842; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hIUn5nE1xV3XcoFpVsz/2fXkpKrW6i00+ShXSFY34HE=; b=P+K56qxqgiazxpyWSLyGuQ8C8QA2xN7CyhB/5Zxkx9DN1DsSU33OWcri9n0rBV5Rmo Nv2zasKxT+HDQB8siRqFf3CaTrcTRi38HTb30zvvEWElZ97KURXSVvC6ag8Agao+OLnk 5MRT0Efn/OABzdMDJklIfiuUT2lZO0NeOZbL6UFwyXs9vhMDi0D0do3cTxIrV+LkfW4e 44uHcXQtFe/UxdfklHaDQg+PTqqvsU+dxA8zZ2aRGNj2AkFs5bVA5/6el1rXcwERRSXo 3n4eC6k+jccDXirbxLZQ0yQ7jYunDYYhMQCLR8k8ixE47Zi7LcOBFk0iDSk2s319jLNy 3oRg== X-Forwarded-Encrypted: i=1; AJvYcCXmuE9dBhTdCIhnl7J86AEA2FP36j7N/qv+oiO4R8ePeT9I79YFqAKo7Zf4d3wZSF2awkIjh7yfAuLvunc= X-Gm-Message-State: AOJu0YwzglVRyD1xMeZthKLHn1CfiqngUxJHZCCUzETHS7mmmQ33+SW9 h1wCWbE71t5bimlLEKvmON4rpUthqhcqlsptIxvzjMLDW5hipyNFEjGDuu1Iuw08AsxL48PDVf/ sAZ/dGiG2zo5Ct0KZ11b4xGG1Of0CmZpSaTyaO+sB X-Received: by 2002:a05:622a:13cc:b0:42e:a497:7d3d with SMTP id p12-20020a05622a13cc00b0042ea4977d3dmr4005471qtk.22.1709129041666; Wed, 28 Feb 2024 06:04:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFN3QzbnS0BD697H96SIXfi2KEYydPO1rTbrYvH8a5LenQWxxsVjafytCYPlCT2bTX3zHZNJQ== X-Received: by 2002:a05:622a:13cc:b0:42e:a497:7d3d with SMTP id p12-20020a05622a13cc00b0042ea4977d3dmr4005416qtk.22.1709129041341; Wed, 28 Feb 2024 06:04:01 -0800 (PST) Received: from localhost (88-120-130-27.subs.proxad.net. [88.120.130.27]) by smtp.gmail.com with ESMTPSA id o2-20020ac872c2000000b0042a9d64396esm4598940qtp.74.2024.02.28.06.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 06:04:00 -0800 (PST) Received: by localhost (Postfix, from userid 1000) id DBBC9B4FCA; Wed, 28 Feb 2024 15:03:57 +0100 (CET) From: Dodji Seketeli To: David Marchand Cc: Dodji Seketeli , dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com, Tyler Retzlaff Subject: Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields Organization: Red Hat / France References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-1-git-send-email-roretzla@linux.microsoft.com> <1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com> X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Wed, 28 Feb 2024 15:03:57 +0100 In-Reply-To: (David Marchand's message of "Tue, 27 Feb 2024 16:18:10 +0100") Message-ID: <87cysgd6sy.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, David Marchand writes: > Hello Dodji, o/ [...] > This change is reported as a potential ABI change. > > For the context, this patch > https://patchwork.dpdk.org/project/dpdk/patch/1709012499-12813-21-git-send-email-roretzla@linux.microsoft.com/ > removes null-sized markers (those fields were using RTE_MARKER, see > https://git.dpdk.org/dpdk/tree/lib/eal/include/rte_common.h#n583) from > the rte_mbuf struct. Thank you for the context. [...] > As reported by the CI: [...] > [C] 'function const rte_eth_rxtx_callback* > rte_eth_add_first_rx_callback(uint16_t, uint16_t, rte_rx_callback_fn, > void*)' at rte_ethdev.c:5768:1 has some indirect sub-type changes: > parameter 3 of type 'typedef rte_rx_callback_fn' has sub-type changes: [...] > in pointed to type 'struct rte_mbuf' at rte_mbuf_core.h:470:1: > type size hasn't changed > 4 data member deletions: > 'RTE_MARKER cacheline0', at offset 0 (in bits) at > rte_mbuf_core.h:467:1 > 'RTE_MARKER64 rearm_data', at offset 128 (in bits) > at rte_mbuf_core.h:490:1 > 'RTE_MARKER rx_descriptor_fields1', at offset 256 > (in bits) at rte_mbuf_core.h:517:1 > 'RTE_MARKER cacheline1', at offset 512 (in bits) at > rte_mbuf_core.h:598:1 > no data member change (1 filtered); [...] > I would argue this change do not impact ABI as the layout of the mbuf > object is not impacted. I agree that on the /particular platform/ that the checker runs on, there is no incompatible ABI change because no data member offset from the 'struct rte_mbuf' type got modified and the size of the type hasn't changed either. > > Error: ABI issue reported for abidiff --suppr > /home/runner/work/dpdk/dpdk/devtools/libabigail.abignore > --no-added-syms --headers-dir1 reference/usr/local/include > --headers-dir2 install/usr/local/include > reference/usr/local/lib/librte_ethdev.so.24.0 > install/usr/local/lib/librte_ethdev.so.24.1 > ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged > this as a potential issue). > > Opinions? > > Btw, I see no way to suppress this (except a global [suppress_type] > name = rte_mbuf)... Right. To avoid having subsequent changes to that type from being "overly" suppressed, maybe do something like: [suppress_type] name = rte_mbuf has_size_change = no has_data_member = {cacheline0, rearm_data, rx_descriptor_fields1, cacheline1} That way, only size-impacting changes to struct rte_mbuf in its form that predates this patch would be suppressed, hopefully. [...] Cheers, -- Dodji