DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Morten Brørup" <mb@smartsharesystems.com>, chenbox@nvidia.com
Cc: stephen@networkplumber.org, dev@dpdk.org
Subject: Re: [PATCH v5] virtio: optimize stats counters performance
Date: Tue, 10 Sep 2024 17:01:16 +0200	[thread overview]
Message-ID: <87d187b1-85b3-403a-b845-8ba4a6c778fb@redhat.com> (raw)
In-Reply-To: <20240801160312.205281-1-mb@smartsharesystems.com>



On 8/1/24 18:03, Morten Brørup wrote:
> Optimized the performance of updating the virtio statistics counters by
> reducing the number of branches.
> 
> Ordered the packet size comparisons according to the probability with
> typical internet traffic mix.
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> v5:
> * Do not inline the function. (Stephen)
> v4:
> * Consider multicast/broadcast packets unlikely.
> v3:
> * Eliminated a local variable.
> * Note: Substituted sizeof(uint32_t)*4 by 32UL, using unsigned long type
>    to keep optimal offsetting in generated assembler output.
> * Removed unnecessary curly braces.
> v2:
> * Fixed checkpatch warning about line length.
> ---
>   drivers/net/virtio/virtio_rxtx.c | 39 ++++++++++++--------------------
>   drivers/net/virtio/virtio_rxtx.h |  4 ++--
>   2 files changed, 16 insertions(+), 27 deletions(-)
>

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2024-09-10 15:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 13:17 [PATCH] " Morten Brørup
2024-07-31 14:04 ` [PATCH v2] " Morten Brørup
2024-07-31 15:13 ` [PATCH v3] " Morten Brørup
2024-07-31 22:58 ` [PATCH v4] " Morten Brørup
2024-07-31 23:45   ` Stephen Hemminger
2024-07-31 23:51     ` Morten Brørup
2024-08-01 16:03 ` [PATCH v5] " Morten Brørup
2024-08-01 16:17   ` Stephen Hemminger
2024-08-01 20:38     ` Morten Brørup
2024-08-02 14:49       ` Morten Brørup
2024-08-02  2:23   ` lihuisong (C)
2024-08-02  2:42     ` Stephen Hemminger
2024-08-02  3:17       ` lihuisong (C)
2024-08-02 11:27     ` Morten Brørup
2024-08-05  1:14       ` lihuisong (C)
2024-08-05  1:19   ` lihuisong (C)
2024-08-06  8:23   ` Chenbo Xia
2024-09-10 15:01   ` Maxime Coquelin [this message]
2024-09-19 12:04   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d187b1-85b3-403a-b845-8ba4a6c778fb@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).