From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F01AA0C43; Fri, 24 Sep 2021 09:14:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 173B04122D; Fri, 24 Sep 2021 09:14:07 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 2C60140142 for ; Fri, 24 Sep 2021 09:14:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632467645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DwvSWw9XqE5CDjHpA7iig3msOx+pKmwr3bka6Lplvh0=; b=DvMV10Xckc/KCvMQDYXMImDeoNlPlATZ8KjpZXTu+gL2+R9ywuayRMI0slj24pJV0/p0ie +9FCtox2qqwYxX0gOO5YYK7RRv4Axw3RpNyH0cVM+4Moza0Gw9mrSojnYknp4pSkmkjmz1 oB/ZNmJVZ9Vc1I1CLkGAsmNYG2BQkQU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-XLlVyC05NCypUXl1A794XQ-1; Fri, 24 Sep 2021 03:14:04 -0400 X-MC-Unique: XLlVyC05NCypUXl1A794XQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 649115721D; Fri, 24 Sep 2021 07:14:02 +0000 (UTC) Received: from [10.39.208.17] (unknown [10.39.208.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42C565DF2F; Fri, 24 Sep 2021 07:14:00 +0000 (UTC) Message-ID: <87dab10c-5744-f569-6367-53ba11cdb789@redhat.com> Date: Fri, 24 Sep 2021 09:13:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: "Xia, Chenbo" , "Hu, Jiayu" , "Ding, Xuan" , "dev@dpdk.org" , "Burakov, Anatoly" Cc: "Jiang, Cheng1" , "Richardson, Bruce" , "Pai G, Sunil" , "Wang, Yinan" , "Yang, YvonneX" References: <20210901053044.109901-1-xuan.ding@intel.com> <20210917052546.23883-1-xuan.ding@intel.com> <20210917052546.23883-3-xuan.ding@intel.com> <917d6068d3cc484b95e9e884cc9a4f3b@intel.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] vhost: enable IOMMU for async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/21 03:53, Xia, Chenbo wrote: >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, September 23, 2021 10:56 PM >> To: Hu, Jiayu ; Ding, Xuan ; >> dev@dpdk.org; Burakov, Anatoly ; Xia, Chenbo >> >> Cc: Jiang, Cheng1 ; Richardson, Bruce >> ; Pai G, Sunil ; Wang, >> Yinan ; Yang, YvonneX >> Subject: Re: [PATCH v2 2/2] vhost: enable IOMMU for async vhost >> >> >> >> On 9/23/21 16:39, Hu, Jiayu wrote: >>> Hi Xuan, >>> >>>> -----Original Message----- >>>> From: Ding, Xuan >>>> Sent: Friday, September 17, 2021 1:26 PM >>>> To: dev@dpdk.org; Burakov, Anatoly ; >>>> maxime.coquelin@redhat.com; Xia, Chenbo >>>> Cc: Hu, Jiayu ; Jiang, Cheng1 ; >>>> Richardson, Bruce ; Pai G, Sunil >>>> ; Wang, Yinan ; Yang, >>>> YvonneX ; Ding, Xuan >>>> Subject: [PATCH v2 2/2] vhost: enable IOMMU for async vhost >>>> >>>> The use of IOMMU has many advantages, such as isolation and address >>>> translation. This patch extends the capbility of DMA engine to use IOMMU if >>>> the DMA engine is bound to vfio. >>>> >>>> When set memory table, the guest memory will be mapped into the default >>>> container of DPDK. >>>> >>>> Signed-off-by: Xuan Ding >>>> --- >>>> lib/vhost/rte_vhost.h | 1 + >>>> lib/vhost/vhost_user.c | 57 >>>> +++++++++++++++++++++++++++++++++++++++++- >>>> 2 files changed, 57 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index >>>> 8d875e9322..e0537249f3 100644 >>>> --- a/lib/vhost/rte_vhost.h >>>> +++ b/lib/vhost/rte_vhost.h >>>> @@ -127,6 +127,7 @@ struct rte_vhost_mem_region { >>>> void *mmap_addr; >>>> uint64_t mmap_size; >>>> int fd; >>>> + uint64_t dma_map_success; >>> >>> How about using bool for dma_map_success? >> >> The bigger problem here is that you are breaking the ABI. > > Maybe this kind of driver-facing structs/functions should be removed > from ABI, since we are refactoring DPDK ABI recently. It has actually been exposed for SPDK, we cannot just remove it from API. Maxime > /Chenbo > >> >>>> }; >>>> >>>> /** >