From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13191A0C4A; Fri, 11 Jun 2021 12:36:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CDA04067C; Fri, 11 Jun 2021 12:36:07 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C823F4014F for ; Fri, 11 Jun 2021 12:36:05 +0200 (CEST) IronPort-SDR: u7pXRUPA0jaW2qWEPRENXTzCnj/wq2kbQQwUw2TBmjNmey8qT9jmk/Iwuto1vZoUltLVRqtFMj 5LEZwwg4pZFQ== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="185193210" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="185193210" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 03:36:04 -0700 IronPort-SDR: vTfrIL7Z3cqkeyP8D68zUos0FO+JhCHIs74eUUg2pzSY5zJd7/yl4pjIdUW20A15tuEHBwIVr1 X2rWG4nnPs/g== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="483219030" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.234.156]) ([10.213.234.156]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 03:36:03 -0700 To: Andrew Rybchenko , "Li, Xiaoyun" Cc: "dev@dpdk.org" References: <20210527162452.1568351-1-andrew.rybchenko@oktetlabs.ru> <1f419fbb-b951-1a84-3329-97701c32c956@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <87dd3fd0-9dab-8079-d135-50d966d6a5cd@intel.com> Date: Fri, 11 Jun 2021 11:35:59 +0100 MIME-Version: 1.0 In-Reply-To: <1f419fbb-b951-1a84-3329-97701c32c956@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: send failure logs to stderr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/11/2021 10:19 AM, Andrew Rybchenko wrote: > On 6/11/21 5:06 AM, Li, Xiaoyun wrote: >> Hi >> -----Original Message----- >> From: Andrew Rybchenko >> Sent: Friday, May 28, 2021 00:25 >> To: Li, Xiaoyun >> Cc: dev@dpdk.org >> Subject: [PATCH] app/testpmd: send failure logs to stderr >> >> Running with stdout suppressed or redirected for further processing is very confusing in the case of errors. >> >> Signed-off-by: Andrew Rybchenko >> --- >> >> This patch looks good to me. >> But what do you think about make it as a fix and backport to stable branches? >> Anyway works for me. > > I have no strong opinion on the topic. > > @Ferruh, what do you think? > Same here, no strong opinion. Sending errors to 'stderr' looks correct thing to do, but changing behavior in the LTS may cause some unexpected side affect, if it is scripted and testpmd output is parsed etc... For this possibility I would wait for the next LTS. And because of same reason perhaps a release note can be added. Also there is 'TESTPMD_LOG' macro for logs in testpmd, (as well as 'RTE_LOG' macro), I don't know if we should switch all logs, including 'printf', to 'TESTPMD_LOG' macro? Later stdout/sderr can be managed in rte_log level, instead of any specific logic for the testpmd. Even there was a defect for this in the rte_log level, that logs should go to stderr: https://bugs.dpdk.org/show_bug.cgi?id=8 >> Acked-by: Xiaoyun Li >