From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ADD443C90; Tue, 12 Mar 2024 13:05:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 421B3402D8; Tue, 12 Mar 2024 13:05:32 +0100 (CET) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 9617C40282 for ; Tue, 12 Mar 2024 13:05:30 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TvC442stDz1vwYr; Tue, 12 Mar 2024 20:04:20 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 3B06D14040F; Tue, 12 Mar 2024 20:05:03 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 12 Mar 2024 20:05:02 +0800 Subject: Re: [EXTERNAL] Re: [v11 0/4] PCI Dev and SG copy support To: Thomas Monjalon CC: , Anoob Joseph , Cheng Jiang , Kevin Laatz , Bruce Richardson , Pavan Nikhilesh Bhagavatula , Amit Prakash Shukla , Jerin Jacob , Gowrishankar Muthukrishnan References: <20240227183555.3932711-1-amitprakashs@marvell.com> <75bad518-b6ce-04e7-7b2d-81dd484ed8b1@huawei.com> <23430837.6Emhk5qWAg@thomas> From: fengchengwen Message-ID: <87ece82b-9855-c318-c942-fee5eb8f32cb@huawei.com> Date: Tue, 12 Mar 2024 20:05:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <23430837.6Emhk5qWAg@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, On 2024/3/12 17:15, Thomas Monjalon wrote: > 07/03/2024 14:55, Gowrishankar Muthukrishnan: >> Hi Fengchengwen, >> >>>> Waiting for a confirmation that this series is good to go. >>> >>> In the discuss of thread [1], I hope this patchset continue take a step forward >>> (means new version) to support bi-direction test just by modify config.ini file. >>> >> >> This patch set already exposes all configuration via config.ini. I didn't follow what is missing. For bi-direction, we can better continue discussing on that patch. > > Chengwen, please can you confirm whether you require a new version? > Which change exactly is missing? This patchset is OK with one sub-test only tackle one DMA direction. But there is a later patch [1] which will support multiple DMA directions within one sub-test. it will add a entry "xfer_mode", but I think it complicate the test, I prefer we do more in this patchset to support some like bi-direction just by modify config.ini, some like this: 1. extend lcore_dma: current lcore_dma is: lcore10@0000:00:04.2 extend it support: lcore10@0000:00:04.2,dir=m2d,coreid=1,pfid=2,vfid=3,raddr=0xXXXX 2. to fix one entry can't hold too many dma device, support entrys: lcore_dma_1, lcore_dma_2 which value is same with lcore_dma. So for bi-direction, we just define config.ini as: lcore_dma=lcore10@0000:00:04.2,dir=m2d,coreid=1,pfid=2,vfid=3,raddr=0xXXXX, lcore10@0000:00:04.2,dir=d2m,coreid=1,pfid=2,vfid=3,raddr=0xXXXX [1] https://patches.dpdk.org/project/dpdk/patch/20240229141426.4188428-1-amitprakashs@marvell.com/ >