From: Dodji Seketeli <dodji@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Phil Yang <phil.yang@arm.com>, Ray Kinsella <mdr@ashroe.eu>,
Harman Kalra <hkalra@marvell.com>, dev <dev@dpdk.org>,
stefan.puiu@gmail.com, Aaron Conole <aconole@redhat.com>,
David Christensen <drc@linux.vnet.ibm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"Ruifeng Wang \(Arm Technology China\)" <Ruifeng.Wang@arm.com>,
nd <nd@arm.com>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal: use c11 atomic built-ins for interrupt status
Date: Fri, 10 Jul 2020 09:18:55 +0200 [thread overview]
Message-ID: <87eepjq1ls.fsf@redhat.com> (raw)
In-Reply-To: <CAJFAV8wLj6pykwhRT7ja4yjPBDnVoyUwgQN27i_N_HhE4QDTKw@mail.gmail.com> (David Marchand's message of "Thu, 9 Jul 2020 12:30:09 +0200")
David Marchand <david.marchand@redhat.com> writes:
[...]
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/libabigail.abignore
>> @@ -48,6 +48,10 @@
>> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END
>> [suppress_variable]
>> name = rte_crypto_aead_algorithm_strings
>> +; Ignore updates of epoll event
>> +[suppress_type]
>> + type_kind = struct
>> + name = rte_epoll_event
>
> In general, ignoring all changes on a structure is risky.
> But the risk is acceptable as long as we remember this for the rest of
> the 20.08 release (and we will start from scratch for 20.11).
Right, I thought about this too when I saw that change. If that struct
is inherently *not* part of the logically exposed ABI, the risk is
really minimal as well. In that case, maybe a comment saying so in the
.abignore file could be useful for future reference.
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-07-10 7:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:24 [dpdk-dev] [PATCH 1/2] eal: remove redundant code Phil Yang
2020-06-11 10:24 ` [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status Phil Yang
2020-07-08 5:24 ` Honnappa Nagarahalli
2020-07-08 11:41 ` Harman Kalra
2020-07-09 5:17 ` Phil Yang
2020-07-08 12:29 ` David Marchand
2020-07-08 13:43 ` Aaron Conole
2020-07-08 13:59 ` David Marchand
2020-07-08 20:48 ` Aaron Conole
2020-07-08 15:04 ` Kinsella, Ray
2020-07-09 5:21 ` Phil Yang
2020-07-08 5:14 ` [dpdk-dev] [PATCH 1/2] eal: remove redundant code Honnappa Nagarahalli
2020-07-08 5:20 ` Phil Yang
2020-07-09 6:46 ` [dpdk-dev] [PATCH v2] eal: use c11 atomic built-ins for interrupt status Phil Yang
2020-07-09 8:02 ` Stefan Puiu
2020-07-09 8:07 ` Phil Yang
2020-07-09 8:34 ` [dpdk-dev] [PATCH v3] " Phil Yang
2020-07-09 10:30 ` David Marchand
2020-07-10 7:18 ` Dodji Seketeli [this message]
2020-07-10 6:32 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eepjq1ls.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=hkalra@marvell.com \
--cc=mdr@ashroe.eu \
--cc=nd@arm.com \
--cc=nhorman@tuxdriver.com \
--cc=phil.yang@arm.com \
--cc=stefan.puiu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).