From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01878A0526; Fri, 10 Jul 2020 09:19:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 538FC1DC73; Fri, 10 Jul 2020 09:19:04 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 320A71DC57 for ; Fri, 10 Jul 2020 09:19:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594365541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bMMNTqRmYSfrfOtcFcbh+gBMTOfP9QJqJjd2j2dptYg=; b=SlUS5oKU7e+1v8yVpHMru+GIVPCbsfbMhNvDLg8QNX/X00QS7ozBnFcrgY25MXaS0Tyx9e xtjtgR8BtY+FDouqSaCk0+mhN7MvrKvTI9MaT5moJkEVh0VkJajQfso47bsEUbWiqqnKDA MTbTfhh061CWZzCQIoHLFmJ5avNM0us= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-0uppg8r0NM-Z6ThhQVaeIQ-1; Fri, 10 Jul 2020 03:18:59 -0400 X-MC-Unique: 0uppg8r0NM-Z6ThhQVaeIQ-1 Received: by mail-wr1-f72.google.com with SMTP id y18so4973159wrq.4 for ; Fri, 10 Jul 2020 00:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bMMNTqRmYSfrfOtcFcbh+gBMTOfP9QJqJjd2j2dptYg=; b=XO/muqnwG0i4wRsj4SsD8P7Raqc7vRSfXDKaBY8td85K+IOKq8EQpq7iYE9CFALIFb J4eKF/Qt8aDb2VUViN3KyxY8vRQhgT3fnEHRenJzkcV/671f/RVRd/p6EWh3wa6+WyO+ RHV7Bp+yUF6bv6DMcij0PHOf4f0g8VGEl+VY/6EGz1xDb2xj0NY5pLvFnMYH0OymURW+ nmsaw66j0jeQ2VGv7+zChdYSuMWCyc7pqiwx8c2S2tM9kCJXrtqWg6akxrSFK2zf1EVy uFQLzXdyO3EiWF1Rf+MpsdTMYcg50adLMVlhxeueksZIXlYOjJJPWebRV3iHQx+DsKu4 O0xQ== X-Gm-Message-State: AOAM532828slFZm5qqnTVda1D6gojFYVVhRg+34FF8oDzkqBOmOGgaCx UdGP+bFAQQcKGq+byfJVmNqow3XmsBMsDW7wouffcnkGmEyX6ewRb16PSh1xiBNljjVhU/T1i4C BCYg= X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr3661857wmm.168.1594365538554; Fri, 10 Jul 2020 00:18:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjIPl9CtRhVvtGRbYvaYa0xb86B31Ceyo4uptqXwRtJLvLe8a9vrPC5p27YtvNyLlsky+o6Q== X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr3661815wmm.168.1594365537922; Fri, 10 Jul 2020 00:18:57 -0700 (PDT) Received: from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130]) by smtp.gmail.com with ESMTPSA id g82sm8426032wma.37.2020.07.10.00.18.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2020 00:18:57 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id AF2FF1800867; Fri, 10 Jul 2020 09:18:55 +0200 (CEST) From: Dodji Seketeli To: David Marchand Cc: Phil Yang , Ray Kinsella , Harman Kalra , dev , stefan.puiu@gmail.com, Aaron Conole , David Christensen , Honnappa Nagarahalli , "Ruifeng Wang \(Arm Technology China\)" , nd , Neil Horman Organization: Red Hat / France References: <1594277162-15021-1-git-send-email-phil.yang@arm.com> <1594283675-15965-1-git-send-email-phil.yang@arm.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.redhat.com Date: Fri, 10 Jul 2020 09:18:55 +0200 In-Reply-To: (David Marchand's message of "Thu, 9 Jul 2020 12:30:09 +0200") Message-ID: <87eepjq1ls.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v3] eal: use c11 atomic built-ins for interrupt status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: [...] >> --- a/devtools/libabigail.abignore >> +++ b/devtools/libabigail.abignore >> @@ -48,6 +48,10 @@ >> changed_enumerators = RTE_CRYPTO_AEAD_LIST_END >> [suppress_variable] >> name = rte_crypto_aead_algorithm_strings >> +; Ignore updates of epoll event >> +[suppress_type] >> + type_kind = struct >> + name = rte_epoll_event > > In general, ignoring all changes on a structure is risky. > But the risk is acceptable as long as we remember this for the rest of > the 20.08 release (and we will start from scratch for 20.11). Right, I thought about this too when I saw that change. If that struct is inherently *not* part of the logically exposed ABI, the risk is really minimal as well. In that case, maybe a comment saying so in the .abignore file could be useful for future reference. [...] Cheers, -- Dodji