DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Andy Moreton <amoreton@xilinx.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	ferruh.yigit@intel.com,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH 5/8] common/sfc_efx/base: support selecting RSS table entry count
Date: Wed, 02 Feb 2022 06:51:12 -0500	[thread overview]
Message-ID: <87fsp11o7j.fsf@mdr78.vserver.site> (raw)
In-Reply-To: <20220201085002.320102-6-ivan.malov@oktetlabs.ru>


Ivan Malov <ivan.malov@oktetlabs.ru> writes:

> On Riverhead boards, the client can control how many entries
> to have in the indirection table of an exclusive RSS context.
>
> Provide the new parameter to clients and indicate its bounds.
> Extend the API for writing the table to have the flexibility.
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> ---
>  drivers/common/sfc_efx/base/ef10_impl.h  |   1 +
>  drivers/common/sfc_efx/base/ef10_nic.c   |  13 +++
>  drivers/common/sfc_efx/base/ef10_rx.c    | 136 +++++++++++++++++++++--
>  drivers/common/sfc_efx/base/efx.h        |  18 +++
>  drivers/common/sfc_efx/base/efx_impl.h   |   3 +-
>  drivers/common/sfc_efx/base/efx_mcdi.h   |  11 ++
>  drivers/common/sfc_efx/base/efx_rx.c     |  38 ++++++-
>  drivers/common/sfc_efx/base/rhead_impl.h |   1 +
>  drivers/common/sfc_efx/base/rhead_rx.c   |   4 +-
>  drivers/common/sfc_efx/version.map       |   1 +
>  10 files changed, 212 insertions(+), 14 deletions(-)
>
>  
> diff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map
> index 97dd943ec4..9510897b83 100644
> --- a/drivers/common/sfc_efx/version.map
> +++ b/drivers/common/sfc_efx/version.map
> @@ -216,6 +216,7 @@ INTERNAL {
>  	efx_rx_qpost;
>  	efx_rx_qpush;
>  	efx_rx_scale_context_alloc;
> +	efx_rx_scale_context_alloc_v2;
>  	efx_rx_scale_context_free;
>  	efx_rx_scale_default_support_get;
>  	efx_rx_scale_hash_flags_get;

So this internal, so ordinarly I have little enough to do or say about
it. In this case, I do have to ask is the _v2 version of the function
avoidable?

-- 
Regards, Ray K

  reply	other threads:[~2022-02-02 11:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  8:49 [PATCH 0/8] net/sfc: improve flow action RSS support on EF100 boards Ivan Malov
2022-02-01  8:49 ` [PATCH 1/8] net/sfc: rework flow action RSS support Ivan Malov
2022-02-01  8:49 ` [PATCH 2/8] common/sfc_efx/base: query RSS queue span limit on Riverhead Ivan Malov
2022-02-01  8:49 ` [PATCH 3/8] net/sfc: use non-static queue span limit in flow action RSS Ivan Malov
2022-02-01  8:49 ` [PATCH 4/8] common/sfc_efx/base: revise name of RSS table entry count Ivan Malov
2022-02-01  8:49 ` [PATCH 5/8] common/sfc_efx/base: support selecting " Ivan Malov
2022-02-02 11:51   ` Ray Kinsella [this message]
2022-02-02 12:24     ` Ivan Malov
2022-02-01  8:50 ` [PATCH 6/8] net/sfc: use adaptive table entry count in flow action RSS Ivan Malov
2022-02-01  8:50 ` [PATCH 7/8] common/sfc_efx/base: support the even spread RSS mode Ivan Malov
2022-02-01  8:50 ` [PATCH 8/8] net/sfc: use the even spread mode in flow action RSS Ivan Malov
2022-02-02 17:41 ` [PATCH 0/8] net/sfc: improve flow action RSS support on EF100 boards Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsp11o7j.fsf@mdr78.vserver.site \
    --to=mdr@ashroe.eu \
    --cc=amoreton@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).