From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3E25A00BE; Tue, 19 Apr 2022 17:56:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D26CD4068E; Tue, 19 Apr 2022 17:56:02 +0200 (CEST) Received: from mail-108-mta27.mxroute.com (mail-108-mta27.mxroute.com [136.175.108.27]) by mails.dpdk.org (Postfix) with ESMTP id B442540687 for ; Tue, 19 Apr 2022 17:56:00 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta27.mxroute.com (ZoneMTA) with ESMTPSA id 180428997b4000fe85.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 19 Apr 2022 15:55:55 +0000 X-Zone-Loop: 2aefc5ab167b86de8ca7039971b1d3121d8a8d7e3da0 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ATJKviO4XCFm6eAy55h+AgtbLUgi8cG9yeeSn7bSjPM=; b=KemHYGeVqON9OHb46sxQizFcKg 6YbtZlCIuM2Jo4wGuP/RYDhEmByVzL3p5/GPA1ccVI5rqf2Rob2r544wI38sGnHwklDlCWsGyKusc Pq6g6cw0HYZVTRlRYHHc76wQQebuvMZ2DFcpCj55PVsDIaD95mg1g8ygq2OGFjjaA2OfT5mvJxkFj OkVJcQV8Qli8Sw9s+CsG4ikp50pKgDUiowtIqYBEqmyLySByc83VWOAvBitu8mkx5/610UmKrl+7P V+G5oWDufjBaeXnMlvdsdeUMxFBvGxFFpeeK1UpYPyk1v8/Fekympb55Bd8BRmGcByH58rgsm2cgt MxVAOHsg==; References: <20220414062510.207983-1-peng1x.zhang@intel.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: peng1x.zhang@intel.com Cc: dev@dpdk.org, Qiming Yang , Qi Zhang , Bruce Richardson Subject: Re: [PATCH] net/ice: promote dynflag API In-reply-to: <20220414062510.207983-1-peng1x.zhang@intel.com> Date: Tue, 19 Apr 2022 11:55:52 -0400 Message-ID: <87k0blnk3b.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org peng1x.zhang@intel.com writes: > From: Peng Zhang > > Promote dynflag APIs to be stable. > > Signed-off-by: Peng Zhang > --- > drivers/net/ice/rte_pmd_ice.h | 1 - > drivers/net/ice/version.map | 15 +++++++++------ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ice/rte_pmd_ice.h b/drivers/net/ice/rte_pmd_ice.h > index 9a436a140b..13604bf9e2 100644 > --- a/drivers/net/ice/rte_pmd_ice.h > +++ b/drivers/net/ice/rte_pmd_ice.h > @@ -149,7 +149,6 @@ extern uint64_t rte_net_ice_dynflag_proto_xtr_ip_offset_mask; > * @return > * True if registered, false otherwise. > */ > -__rte_experimental > static __rte_always_inline int > rte_net_ice_dynf_proto_xtr_metadata_avail(void) > { > diff --git a/drivers/net/ice/version.map b/drivers/net/ice/version.map > index cc837f1c00..4cbe33a40d 100644 > --- a/drivers/net/ice/version.map > +++ b/drivers/net/ice/version.map > @@ -1,16 +1,19 @@ > DPDK_22 { > - local: *; > -}; > + global: > > -EXPERIMENTAL { > - global: > - > - # added in 19.11 > rte_net_ice_dynfield_proto_xtr_metadata_offs; > rte_net_ice_dynflag_proto_xtr_vlan_mask; > rte_net_ice_dynflag_proto_xtr_ipv4_mask; > rte_net_ice_dynflag_proto_xtr_ipv6_mask; > rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask; > rte_net_ice_dynflag_proto_xtr_tcp_mask; Folks, these are all exported variables, we should be removing these not promoting these to stable. After looking at them closely, can't we just make them local, do they need to be exported at all? -- Regards, Ray K