From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C099A054D; Thu, 26 May 2022 13:03:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CA6B40151; Thu, 26 May 2022 13:03:02 +0200 (CEST) Received: from mail-108-mta76.mxroute.com (mail-108-mta76.mxroute.com [136.175.108.76]) by mails.dpdk.org (Postfix) with ESMTP id 03F0440150 for <dev@dpdk.org>; Thu, 26 May 2022 13:02:59 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta76.mxroute.com (ZoneMTA) with ESMTPSA id 1810008a56f000c327.001 for <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 26 May 2022 11:02:55 +0000 X-Zone-Loop: ef14d64701a825d8d4b9bed31f25f608a7e78a95dd3c X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=20tQiSLTQW2VYxM4EPPYtdbRlQn0vYvziDOJ/J3b42w=; b=FNY4lnwlsW24OdXCOJpJoZQP2z HMhFKm0BfmYJPUjaCBFyRkhwsYpC8o3vdsH/uKX6b6VKqw+FFbljuy+LcPp9UODQbq9dOs9GTFMrp GaQVwrK9YyZhQoFyxWj6o+4Jcee1Akurf+KqUZXG4vCeBM+y8D63KgqwsfxpH0TVuMwW6ELAaQYl+ 0XjpLLA01+XOQvil/XmyTvL6GGinpdLTmssCmi4YPen9lKJKWS/tObDrryXG7UB7s1oWDTjgjxpHO HHIvF3+pKgHc19x1Lk/khkmRriMdd2JoFx0g57RdRRyBwE4eRQvHWG6j+sPHLThVepK8TeitQ5AJO 4lEEwgSA==; References: <20220525095307.675312-1-thomas@monjalon.net> <878rqpze0j.fsf@mdr78.vserver.site> <20220525183459.GA24690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <3966769.zXnORWrf4K@thomas> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella <mdr@ashroe.eu> To: Thomas Monjalon <thomas@monjalon.net> Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org, David Christensen <drc@linux.vnet.ibm.com> Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector In-reply-to: <3966769.zXnORWrf4K@thomas> Date: Thu, 26 May 2022 12:02:51 +0100 Message-ID: <87leuoblpg.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Thomas Monjalon <thomas@monjalon.net> writes: > 25/05/2022 20:34, Tyler Retzlaff: >> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: >> > Thomas Monjalon <thomas@monjalon.net> writes: >> > > 25/05/2022 13:48, Ray Kinsella: >> > >> Thomas Monjalon <thomas@monjalon.net> writes: >> > >> >> > >> > The AltiVec header file is defining "vector", except in C++ build. >> > >> > The keyword "vector" may conflict easily. >> > >> > As a rule, it is better to use the alternative keyword "__vector". >> > >> > >> > >> > The DPDK header file rte_altivec.h takes care of undefining "vector", >> > >> > so the applications and dependencies are free to define the name "vector". >> > >> > >> > >> > This is a compatibility breakage for applications which were using >> > >> > the keyword "vector" for its AltiVec meaning. >> > >> > >> > >> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >> > >> > --- >> > >> > doc/guides/rel_notes/release_22_07.rst | 5 +++++ >> > >> > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ >> > >> > 2 files changed, 12 insertions(+) >> > >> > >> > >> >> > >> Acked-by: Ray Kinsella <mdr@ashroe.eu> >> > > >> > > Just to make sure, we are all OK to break compatibility of rte_altivec.h? >> > > It means the keyword vector is not available anymore with this #include. >> > > Please confirm it is OK to merge in DPDK 22.07. >> > >> > I did think about it yes ;-). >> > I can't see how it would break the ABI in the short term. >> > And it makes sense to preclude this keyword in the long term. >> > >> > So I ack'ed - did I miss something? >> >> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com> >> >> double ack, impact of break is understood as follows. >> >> * this is not an issue with abi it is an issue with api. >> * the break will cause a compile failure, the action to resolve is to >> replace vector with __vector. > > Exactly > > I'll wait few days or acks from the techboard, and will apply. +1 -- Regards, Ray K