From: Ray Kinsella <mdr@ashroe.eu>
To: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, rbalu@marvell.com,
dev@dpdk.org
Subject: Re: [PATCH v2 1/4] crypto: add dsa random number k
Date: Fri, 11 Feb 2022 05:55:37 -0500 [thread overview]
Message-ID: <87mtixiseu.fsf@mdr78.vserver.site> (raw)
In-Reply-To: <20220207113555.8431-2-arkadiuszx.kusztal@intel.com>
Arek Kusztal <arkadiuszx.kusztal@intel.com> writes:
> This commit adds random number 'k' to dsa
> op param struct.
>
> This parameter is crucial in stituation where:
situation
> - PMD cannot generate random number
> - user would like to provide random source
>
> Addtionally it makes DSA consistent with ECDSA
additionally
> in terms of 'k' which includes this parameter.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> lib/cryptodev/rte_crypto_asym.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index 9c866f553f..e0def3d9ab 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -547,6 +547,10 @@ struct rte_crypto_dsa_op_param {
> /**< Signature Generation or Verification */
> rte_crypto_param message;
> /**< input message to be signed or verified */
> + rte_crypto_param k;
> + /**< Per-message secret number, which is an integer
> + * in the interval (1, q-1)
> + */
> rte_crypto_param r;
> /**< dsa sign component 'r' value
> *
Please run a spell check on your commit messages.
--
Regards, Ray K
next prev parent reply other threads:[~2022-02-11 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:35 [PATCH v2 0/4] Clarify asymmetric random, add 'k' and crypto uint Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 1/4] crypto: add dsa random number k Arek Kusztal
2022-02-11 10:55 ` Ray Kinsella [this message]
2022-02-07 11:35 ` [PATCH v2 2/4] crypto: clarify usage of random numbers in asym Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 3/4] crypto: use rte macro instead of direct attribute Arek Kusztal
2022-02-07 11:35 ` [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Arek Kusztal
2022-02-10 10:17 ` [EXT] " Akhil Goyal
2022-02-10 16:38 ` Zhang, Roy Fan
2022-02-10 21:08 ` Akhil Goyal
2022-02-11 10:54 ` Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtixiseu.fsf@mdr78.vserver.site \
--to=mdr@ashroe.eu \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=rbalu@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).