From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55B91A00BE; Fri, 11 Feb 2022 11:55:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4158241144; Fri, 11 Feb 2022 11:55:46 +0100 (CET) Received: from mail-108-mta62.mxroute.com (mail-108-mta62.mxroute.com [136.175.108.62]) by mails.dpdk.org (Postfix) with ESMTP id 759F240150 for ; Fri, 11 Feb 2022 11:55:44 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta62.mxroute.com (ZoneMTA) with ESMTPSA id 17ee86ca5160005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 11 Feb 2022 10:55:41 +0000 X-Zone-Loop: 9b38ee6b1eef9b540f78d8d4dff7bdb1771bcff4ef5f X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7jcBf643tYCNPXZc65Ex/QmfURRizGrTrOljShJjEio=; b=J6tOPQVvEv5YntMwj2t+cjdjqu HYysYOtLnMQdnsV4ZxvVGMiHIXB8cOfQejR+lgg0BEIWrH03201ufQXp/YNqy/z8YY4TZCSYIvtDl idYf93FvRn2+hB3CqJOtPwQRdYkdN15l2UdujfxWRGpuBuCASk+axt1Mk47GkVYk8K4AK7fZVUqni lCMCP8Kn84RgFxtwp8gvXavQSk6CcLFu7iegFMgPMHyqDuRghga0zmYp4Tog6YaY6OxeMxtYqrFZ7 uGDV1foFDeRsC0hGp/CRpVuD2Ur96U7wlKzdpXyku0QUTha88lFN6zcKF7Qs4LcI4vE7kQ4JFiB2X 21cRJoRg==; References: <20220207113555.8431-1-arkadiuszx.kusztal@intel.com> <20220207113555.8431-2-arkadiuszx.kusztal@intel.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Arek Kusztal Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, rbalu@marvell.com, dev@dpdk.org Subject: Re: [PATCH v2 1/4] crypto: add dsa random number k In-reply-to: <20220207113555.8431-2-arkadiuszx.kusztal@intel.com> Date: Fri, 11 Feb 2022 05:55:37 -0500 Message-ID: <87mtixiseu.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Arek Kusztal writes: > This commit adds random number 'k' to dsa > op param struct. > > This parameter is crucial in stituation where: situation > - PMD cannot generate random number > - user would like to provide random source > > Addtionally it makes DSA consistent with ECDSA additionally > in terms of 'k' which includes this parameter. > > Signed-off-by: Arek Kusztal > --- > lib/cryptodev/rte_crypto_asym.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h > index 9c866f553f..e0def3d9ab 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -547,6 +547,10 @@ struct rte_crypto_dsa_op_param { > /**< Signature Generation or Verification */ > rte_crypto_param message; > /**< input message to be signed or verified */ > + rte_crypto_param k; > + /**< Per-message secret number, which is an integer > + * in the interval (1, q-1) > + */ > rte_crypto_param r; > /**< dsa sign component 'r' value > * Please run a spell check on your commit messages. -- Regards, Ray K