From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A8C3A00BE; Fri, 11 Feb 2022 11:54:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 496A341144; Fri, 11 Feb 2022 11:54:21 +0100 (CET) Received: from mail-108-mta135.mxroute.com (mail-108-mta135.mxroute.com [136.175.108.135]) by mails.dpdk.org (Postfix) with ESMTP id C8A8B40150 for ; Fri, 11 Feb 2022 11:54:18 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta135.mxroute.com (ZoneMTA) with ESMTPSA id 17ee86b5c7b0005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 11 Feb 2022 10:54:17 +0000 X-Zone-Loop: 92bb5faa025ad2f6085004f00d3193e5198370f82c7c X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oF7EFc10yfQiBLlPnAkiImMGU/5E3klSdt8XrBID3Xo=; b=XRAZo+Jh33ZzMHRkWFgw1oe2rX z9NIFVMuuL64m/JyahPmkNo71OELuysIcdK1kQWgmoVqgbapwMerUiB35gp8XOI0ZJfGZVnqMieF7 QCQPX+u5bTauMmj5Xc8BD/7Vu18417wwxFNYQJMtlwlXSECf3DOm1fvFwhE9f18uxzr96WpjZRao5 4/a7cvkJYKXT/Scf/qOb0wiEkM4iEI1L/F35/t5QTYnuvhyg9w66PzLVbSSKfkkwTQkVKrCxKndIw QMwsN45/M3tqX8Yei4GX7XuRoSL81HOtmjvhxLJi67OGQ9m/qKtooX5j2unon/CCJ9ehs4MY0wRcK sfaXLM0Q==; References: <20220207113555.8431-1-arkadiuszx.kusztal@intel.com> <20220207113555.8431-5-arkadiuszx.kusztal@intel.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Akhil Goyal Cc: "Zhang, Roy Fan" , "Kusztal, ArkadiuszX" , David Marchand , "ray.kinsella@intel.com" , Ramkumar Balu , dev@dpdk.org Subject: Re: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint In-reply-to: Date: Fri, 11 Feb 2022 05:54:13 -0500 Message-ID: <87pmntish6.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Akhil Goyal writes: > Hi Fan, >> Hi Akhil, >> >> I assume everything in asym crypto is under experimental tag at the moment >> right? >> The goal is to have them updated and fixed before DPDK 22.11 so the >> experimental tag can be removed. >> > Asymmetric crypto APIs are marked as experimental, but the structures are not > explicitly marked experimental. > rte_crypto_asym_op is part of union in rte_crypto_op which is definitely not experimental. > So a change in asym_op will result in ABI issues in rte_crypto_op. > > David/Ray: Can you review the patch 1/4 of this series from ABI compatibility point of view. > http://patches.dpdk.org/project/dpdk/patch/20220207113555.8431-2-arkadiuszx.kusztal@intel.com/ > IMO, as per current experimental tags, we cannot change parameters inside rte_crypto_asym_op > and subsequently in struct rte_crypto_dsa_op_param. What do you suggest? > However, I remember, some exception was added to ignore ABI issues related to asymmetric > crypto. Could you please check why that exception is not working in this case? > > Regards, > Akhil So rte_crypto_asym_op is at the end of the rte_crypto_op struct, so any changes there are safe. http://mails.dpdk.org/archives/test-report/2022-February/257617.html The warning above is complaining about changes to rte_crypto_asym_op. IMHO it is safe to condone these warnings in the libabigail.ignore. libabigail.ignore exceptions was reset at the 21.11 release, although I took a look and don't see anything related to asymmetric crypto prior to that. -- Regards, Ray K