From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66ED6A0509; Wed, 4 May 2022 10:52:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E79A4069F; Wed, 4 May 2022 10:52:44 +0200 (CEST) Received: from mail-108-mta120.mxroute.com (mail-108-mta120.mxroute.com [136.175.108.120]) by mails.dpdk.org (Postfix) with ESMTP id A73EB40694 for ; Wed, 4 May 2022 10:52:41 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta120.mxroute.com (ZoneMTA) with ESMTPSA id 1808e456b75000926a.011 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 04 May 2022 08:52:35 +0000 X-Zone-Loop: 6acaeba19cf432c1b54b499891a2293431e55c789b6e X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=l3OgJLrc2k5W4UzTNgwTVU8yaPNOiEQ5kqcs/sIVbSM=; b=K/zQcmrQ2FxiF/QKr4hoFkwrJp GRLGP4QJchRzXbsSib2MMOfnmSKX18rxCnjfzNw2+3Q7aPwrJ2+jMH7xM7Udg7zW6ycxOBJ40BtTR fLxFmjF1CxWegoKbggOy9u1s4JhMEYKw5sxCW6i/XB0nIiS8IAMPAykicWvN/NYTLt1GS55mp96ib y/KD0V0DpQAf9aOA9XPB/yPFY63RhERVe7i8m2Z6iSsrsaCuCWWxYSvEHax8Ai9O+GZDL0yTeShiF se6WJ8xpp/lyJ+1Tyyv9dKwdshl6cwzjdbuERHqbryCF6CY7vHo/qdu+65FOhxkuPPkLvRbgSOFyp BMmurCAQ==; References: <20220421180241.514767-1-jerinj@marvell.com> <20220501144637.3757757-1-jerinj@marvell.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: jerinj@marvell.com Cc: dev@dpdk.org, Cristian Dumitrescu , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , ajit.khaparde@broadcom.com, aboyer@pensando.io, beilei.xing@intel.com, bruce.richardson@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com Subject: Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection In-reply-to: <20220501144637.3757757-1-jerinj@marvell.com> Date: Wed, 04 May 2022 09:52:28 +0100 Message-ID: <87r159k7cj.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org jerinj@marvell.com writes: > From: Jerin Jacob > > Currently, meter object supports only DSCP based on input color table, > The patch enhance that to support VLAN based input color table, > color table based on inner field for the tunnel use case, and > support for fallback color per meter if packet based on a different field. > > All of the above features are exposed through capability and added > additional capability to specify the implementation supports > more than one input color table per ethdev port. > > Suggested-by: Cristian Dumitrescu > Signed-off-by: Jerin Jacob > --- > > v5..v4: > > - Improved the Doxgen comments as per > http://patches.dpdk.org/project/dpdk/patch/20220421180241.514767-1-jerinj@marvell.com/ > - Removed input_color_proto_mask > - Renamed rte_mtr_color_in_protocol_priority_set() to rte_mtr_color_in_protocol_set() > - Introduced rte_mtr_color_in_protocol_get(), rte_mtr_color_in_protocol_priority_get() > for getting the configured input color protocol. > > v4..v3: > > - Aligned with community meeting call which is documented in > https://patches.dpdk.org/project/dpdk/patch/20220301085824.1041009-1-skori@marvell.com/ > as last message. With following exception, > - Used RTE_MTR_COLOR_IN_*_DSCP instead of RTE_MTR_COLOR_IN_*_IP as > there is already dscp_table and rte_mtr_meter_dscp_table_update() API. > Changing above symbols break existing application for no good. > - Updated 22.07 release notes > - Remove testpmd changes from series to finalize the API spec first and > then we can send testpmd changes. > > v3..v2: > > - Fix input color flags as a bitmask > - Add definitions for newly added API > > v2..v1: > - Fix seperate typo > > v1..RFC: > > Address the review comments by Cristian at > https://patches.dpdk.org/project/dpdk/patch/20210820082401.3778736-1-jerinj@marvell.com/ > > .../traffic_metering_and_policing.rst | 35 +++ > doc/guides/rel_notes/release_22_07.rst | 10 + > lib/ethdev/rte_mtr.c | 50 ++++ > lib/ethdev/rte_mtr.h | 216 +++++++++++++++++- > lib/ethdev/rte_mtr_driver.h | 38 +++ > lib/ethdev/version.map | 6 + > 6 files changed, 345 insertions(+), 10 deletions(-) > Acked-by: Ray Kinsella