DPDK patches and discussions
 help / color / mirror / Atom feed
* RE: [DPDK] drivers/net/ixgbe: remove expired symbols
  2022-04-12 14:27 [DPDK] drivers/net/ixgbe: remove expired symbols zhichaox.zeng
@ 2022-04-12  7:23 ` Wang, Haiyue
  2022-04-12  8:47   ` David Marchand
  2022-04-12  8:38 ` Bruce Richardson
  2022-04-12 16:16 ` [DPDK v2] net/ixgbe: promote MDIO API zhichaox.zeng
  2 siblings, 1 reply; 14+ messages in thread
From: Wang, Haiyue @ 2022-04-12  7:23 UTC (permalink / raw)
  To: Zeng, ZhichaoX; +Cc: dev

> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, April 12, 2022 22:27
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.

The git commit can be enhanced like:

Title: net/ixgbe: promote MDIO API

Promote the MDIO APIs to be stable.

> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 


> diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
> index bca5cc5826..b2063df1bb 100644
> --- a/drivers/net/ixgbe/version.map
> +++ b/drivers/net/ixgbe/version.map
> @@ -31,6 +31,11 @@ DPDK_22 {
>  	rte_pmd_ixgbe_set_vf_vlan_filter;
>  	rte_pmd_ixgbe_set_vf_vlan_insert;
>  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> +	rte_pmd_ixgbe_mdio_lock;
> +	rte_pmd_ixgbe_mdio_unlock;
> +	rte_pmd_ixgbe_mdio_unlocked_read;
> +	rte_pmd_ixgbe_mdio_unlocked_write;

Put the above under ' rte_pmd_ixgbe_macsec_select_txsa;'

This is in alphabet order.

> +	rte_pmd_ixgbe_upd_fctrl_sbp;
> 
>  	local: *;
>  };
> @@ -40,9 +45,4 @@ EXPERIMENTAL {
> 
>  	rte_pmd_ixgbe_get_fdir_info;
>  	rte_pmd_ixgbe_get_fdir_stats;
> -	rte_pmd_ixgbe_mdio_lock;
> -	rte_pmd_ixgbe_mdio_unlock;
> -	rte_pmd_ixgbe_mdio_unlocked_read;
> -	rte_pmd_ixgbe_mdio_unlocked_write;
> -	rte_pmd_ixgbe_upd_fctrl_sbp;
>  };
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [DPDK] drivers/net/ixgbe: remove expired symbols
  2022-04-12 14:27 [DPDK] drivers/net/ixgbe: remove expired symbols zhichaox.zeng
  2022-04-12  7:23 ` Wang, Haiyue
@ 2022-04-12  8:38 ` Bruce Richardson
  2022-04-12  8:52   ` Wang, Haiyue
  2022-04-12 16:16 ` [DPDK v2] net/ixgbe: promote MDIO API zhichaox.zeng
  2 siblings, 1 reply; 14+ messages in thread
From: Bruce Richardson @ 2022-04-12  8:38 UTC (permalink / raw)
  To: zhichaox.zeng; +Cc: haiyue.wang, dev

On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.
> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..4f1fe6029d 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
>   */
> -__rte_experimental
> -int
> -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
>  

I don't see the value in rewriting the prototypes to be all on one line as
part of this change. Just remove the experimental tag line in this patch,
to keep the diff as small as possible.

/Bruce

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [DPDK] drivers/net/ixgbe: remove expired symbols
  2022-04-12  7:23 ` Wang, Haiyue
@ 2022-04-12  8:47   ` David Marchand
  0 siblings, 0 replies; 14+ messages in thread
From: David Marchand @ 2022-04-12  8:47 UTC (permalink / raw)
  To: Wang, Haiyue, Zeng, ZhichaoX; +Cc: dev, Ray Kinsella

On Tue, Apr 12, 2022 at 9:23 AM Wang, Haiyue <haiyue.wang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Tuesday, April 12, 2022 22:27
> > To: Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> >
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
>
> The git commit can be enhanced like:
>
> Title: net/ixgbe: promote MDIO API
>
> Promote the MDIO APIs to be stable.

Please, use get-maintainer.sh when sending patches, it will
automatically Cc relevant people.
Adding Ray in the loop.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [DPDK] drivers/net/ixgbe: remove expired symbols
  2022-04-12  8:38 ` Bruce Richardson
@ 2022-04-12  8:52   ` Wang, Haiyue
  0 siblings, 0 replies; 14+ messages in thread
From: Wang, Haiyue @ 2022-04-12  8:52 UTC (permalink / raw)
  To: Richardson, Bruce, Zeng, ZhichaoX; +Cc: dev

> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Tuesday, April 12, 2022 16:39
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
> >
> > Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 10 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > index eef6f6661c..4f1fe6029d 100644
> > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> >   */
> > -__rte_experimental
> > -int
> > -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> > +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >
> 
> I don't see the value in rewriting the prototypes to be all on one line as
> part of this change. Just remove the experimental tag line in this patch,
> to keep the diff as small as possible.

+1, yes, clean patch. ;-)

> 
> /Bruce

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [DPDK] drivers/net/ixgbe: remove expired symbols
@ 2022-04-12 14:27 zhichaox.zeng
  2022-04-12  7:23 ` Wang, Haiyue
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: zhichaox.zeng @ 2022-04-12 14:27 UTC (permalink / raw)
  To: haiyue.wang; +Cc: dev, zhichao zeng

From: zhichao zeng <zhichaox.zeng@intel.com>

Remove expired experimental symbols.

Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..4f1fe6029d 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_lock(uint16_t port);
+int rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
 /**
  * Release swfw semaphore lock used for MDIO access
@@ -600,9 +598,7 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlock(uint16_t port);
+int rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
 /**
  * Read PHY register using MDIO without MDIO lock
@@ -622,9 +618,7 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
 
 /**
@@ -646,9 +640,7 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
 
 /**
@@ -725,9 +717,7 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
+int rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
 /**
  * Get port fdir info
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..b2063df1bb 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -31,6 +31,11 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [DPDK v2] net/ixgbe: promote MDIO API
  2022-04-12 14:27 [DPDK] drivers/net/ixgbe: remove expired symbols zhichaox.zeng
  2022-04-12  7:23 ` Wang, Haiyue
  2022-04-12  8:38 ` Bruce Richardson
@ 2022-04-12 16:16 ` zhichaox.zeng
  2022-04-12 17:56   ` [DPDK v3] " zhichaox.zeng
  2 siblings, 1 reply; 14+ messages in thread
From: zhichaox.zeng @ 2022-04-12 16:16 UTC (permalink / raw)
  To: haiyue.wang, dev; +Cc: zhichao zeng

From: zhichao zeng <zhichaox.zeng@intel.com>

Promote the MDIO APIs to be stable.

Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..4f1fe6029d 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_lock(uint16_t port);
+int rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
 /**
  * Release swfw semaphore lock used for MDIO access
@@ -600,9 +598,7 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlock(uint16_t port);
+int rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
 /**
  * Read PHY register using MDIO without MDIO lock
@@ -622,9 +618,7 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
 
 /**
@@ -646,9 +640,7 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
 
 /**
@@ -725,9 +717,7 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
+int rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
 /**
  * Get port fdir info
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
 	rte_pmd_ixgbe_macsec_enable;
 	rte_pmd_ixgbe_macsec_select_rxsa;
 	rte_pmd_ixgbe_macsec_select_txsa;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
 	rte_pmd_ixgbe_ping_vf;
 	rte_pmd_ixgbe_set_all_queues_drop_en;
 	rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [DPDK v3] net/ixgbe: promote MDIO API
  2022-04-12 16:16 ` [DPDK v2] net/ixgbe: promote MDIO API zhichaox.zeng
@ 2022-04-12 17:56   ` zhichaox.zeng
  2022-04-14  2:52     ` Wang, Haiyue
                       ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: zhichaox.zeng @ 2022-04-12 17:56 UTC (permalink / raw)
  To: dev; +Cc: zhichao zeng, Haiyue Wang, Ray Kinsella

From: zhichao zeng <zhichaox.zeng@intel.com>

Promote the MDIO APIs to be stable.

Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..426fe5845b 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
@@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
@@ -725,7 +721,6 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
 	rte_pmd_ixgbe_macsec_enable;
 	rte_pmd_ixgbe_macsec_select_rxsa;
 	rte_pmd_ixgbe_macsec_select_txsa;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
 	rte_pmd_ixgbe_ping_vf;
 	rte_pmd_ixgbe_set_all_queues_drop_en;
 	rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [DPDK v3] net/ixgbe: promote MDIO API
  2022-04-12 17:56   ` [DPDK v3] " zhichaox.zeng
@ 2022-04-14  2:52     ` Wang, Haiyue
  2022-04-15 14:36     ` Ray Kinsella
  2022-04-19 11:06     ` [DPDK v4] " zhichaox.zeng
  2 siblings, 0 replies; 14+ messages in thread
From: Wang, Haiyue @ 2022-04-14  2:52 UTC (permalink / raw)
  To: Zeng, ZhichaoX, dev, Ray Kinsella

> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Wednesday, April 13, 2022 01:56
> To: dev@dpdk.org
> Cc: Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Ray Kinsella
> <mdr@ashroe.eu>
> Subject: [DPDK v3] net/ixgbe: promote MDIO API
> 
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Promote the MDIO APIs to be stable.
> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 5 insertions(+), 10 deletions(-)
> 

LGTM from PMD's view,

Acked-by: Haiyue Wang <haiyue.wang@intel.com>


Ray,

What do you think ?



> --
> 2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [DPDK v3] net/ixgbe: promote MDIO API
  2022-04-12 17:56   ` [DPDK v3] " zhichaox.zeng
  2022-04-14  2:52     ` Wang, Haiyue
@ 2022-04-15 14:36     ` Ray Kinsella
  2022-04-18  6:41       ` Yang, Qiming
  2022-04-19 11:06     ` [DPDK v4] " zhichaox.zeng
  2 siblings, 1 reply; 14+ messages in thread
From: Ray Kinsella @ 2022-04-15 14:36 UTC (permalink / raw)
  To: zhichaox.zeng; +Cc: dev, Haiyue Wang, David Marchand


zhichaox.zeng@intel.com writes:

> From: zhichao zeng <zhichaox.zeng@intel.com>
>
> Promote the MDIO APIs to be stable.
>
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..426fe5845b 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
>   */
> -__rte_experimental
>  int
>  rte_pmd_ixgbe_mdio_lock(uint16_t port);
>  
> @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
>   *   - (-ENOTSUP) if hardware doesn't support.
>   *   - (-ENODEV) if *port* invalid.
>   */
> -__rte_experimental
>  int
>  rte_pmd_ixgbe_mdio_unlock(uint16_t port);
>  
> @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_PHY) If PHY read command failed
>   */
> -__rte_experimental
>  int
>  rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
>  				 uint32_t dev_type, uint16_t *phy_data);
> @@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_PHY) If PHY read command failed
>   */
> -__rte_experimental
>  int
>  rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
>  				  uint32_t dev_type, uint16_t phy_data);
> @@ -725,7 +721,6 @@ enum {
>   *   - (-ENODEV) if *port* invalid.
>   *   - (-ENOTSUP) if hardware doesn't support this feature.
>   */
> -__rte_experimental
>  int
>  rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
>  
> diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
> index bca5cc5826..f0f29d8749 100644
> --- a/drivers/net/ixgbe/version.map
> +++ b/drivers/net/ixgbe/version.map
> @@ -16,6 +16,10 @@ DPDK_22 {
>  	rte_pmd_ixgbe_macsec_enable;
>  	rte_pmd_ixgbe_macsec_select_rxsa;
>  	rte_pmd_ixgbe_macsec_select_txsa;

Promoted APIs should be part of the DPDK_23 ABI, not DPDK_22.

David - I just did some checking and noted that we have been promoting
directly from experimental to DPDK 22, and that we did the same for DPDK
21. However in the DPDK_20 we (rightly) promoted to DPDK_21, new APIs
are promoted to being stable in the next ABI release. 

Was that I conscious decision? I don't thinking there is impact by the
error / change, beyond house keeping.


> +	rte_pmd_ixgbe_mdio_lock;
> +	rte_pmd_ixgbe_mdio_unlock;
> +	rte_pmd_ixgbe_mdio_unlocked_read;
> +	rte_pmd_ixgbe_mdio_unlocked_write;
>  	rte_pmd_ixgbe_ping_vf;
>  	rte_pmd_ixgbe_set_all_queues_drop_en;
>  	rte_pmd_ixgbe_set_tc_bw_alloc;
> @@ -31,6 +35,7 @@ DPDK_22 {
>  	rte_pmd_ixgbe_set_vf_vlan_filter;
>  	rte_pmd_ixgbe_set_vf_vlan_insert;
>  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> +	rte_pmd_ixgbe_upd_fctrl_sbp;
>  
>  	local: *;
>  };
> @@ -40,9 +45,4 @@ EXPERIMENTAL {
>  
>  	rte_pmd_ixgbe_get_fdir_info;
>  	rte_pmd_ixgbe_get_fdir_stats;
> -	rte_pmd_ixgbe_mdio_lock;
> -	rte_pmd_ixgbe_mdio_unlock;
> -	rte_pmd_ixgbe_mdio_unlocked_read;
> -	rte_pmd_ixgbe_mdio_unlocked_write;
> -	rte_pmd_ixgbe_upd_fctrl_sbp;
>  };


-- 
Regards, Ray K

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [DPDK v3] net/ixgbe: promote MDIO API
  2022-04-15 14:36     ` Ray Kinsella
@ 2022-04-18  6:41       ` Yang, Qiming
  0 siblings, 0 replies; 14+ messages in thread
From: Yang, Qiming @ 2022-04-18  6:41 UTC (permalink / raw)
  To: Ray Kinsella, Zeng, ZhichaoX; +Cc: dev, Wang, Haiyue, David Marchand



> -----Original Message-----
> From: Ray Kinsella <mdr@ashroe.eu>
> Sent: 2022年4月15日 22:36
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; David
> Marchand <david.marchand@redhat.com>
> Subject: Re: [DPDK v3] net/ixgbe: promote MDIO API
> 
> 
> zhichaox.zeng@intel.com writes:
> 
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Promote the MDIO APIs to be stable.
> >
> > Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>

Your sign off should be Zhichao Zeng, upper case.

> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > index eef6f6661c..426fe5845b 100644
> > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t
> port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >
> > @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >   *   - (-ENOTSUP) if hardware doesn't support.
> >   *   - (-ENODEV) if *port* invalid.
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlock(uint16_t port);
> >
> > @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_PHY) If PHY read command failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
> >  				 uint32_t dev_type, uint16_t *phy_data);
> @@ -646,7 +643,6 @@
> > rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_PHY) If PHY read command failed
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
> >  				  uint32_t dev_type, uint16_t phy_data);
> @@ -725,7 +721,6 @@ enum
> > {
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (-ENOTSUP) if hardware doesn't support this feature.
> >   */
> > -__rte_experimental
> >  int
> >  rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
> >
> > diff --git a/drivers/net/ixgbe/version.map
> > b/drivers/net/ixgbe/version.map index bca5cc5826..f0f29d8749 100644
> > --- a/drivers/net/ixgbe/version.map
> > +++ b/drivers/net/ixgbe/version.map
> > @@ -16,6 +16,10 @@ DPDK_22 {
> >  	rte_pmd_ixgbe_macsec_enable;
> >  	rte_pmd_ixgbe_macsec_select_rxsa;
> >  	rte_pmd_ixgbe_macsec_select_txsa;
> 
> Promoted APIs should be part of the DPDK_23 ABI, not DPDK_22.
> 
> David - I just did some checking and noted that we have been promoting
> directly from experimental to DPDK 22, and that we did the same for DPDK
> 21. However in the DPDK_20 we (rightly) promoted to DPDK_21, new APIs
> are promoted to being stable in the next ABI release.
> 
> Was that I conscious decision? I don't thinking there is impact by the error /
> change, beyond house keeping.
> 
> 
> > +	rte_pmd_ixgbe_mdio_lock;
> > +	rte_pmd_ixgbe_mdio_unlock;
> > +	rte_pmd_ixgbe_mdio_unlocked_read;
> > +	rte_pmd_ixgbe_mdio_unlocked_write;
> >  	rte_pmd_ixgbe_ping_vf;
> >  	rte_pmd_ixgbe_set_all_queues_drop_en;
> >  	rte_pmd_ixgbe_set_tc_bw_alloc;
> > @@ -31,6 +35,7 @@ DPDK_22 {
> >  	rte_pmd_ixgbe_set_vf_vlan_filter;
> >  	rte_pmd_ixgbe_set_vf_vlan_insert;
> >  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> > +	rte_pmd_ixgbe_upd_fctrl_sbp;
> >
> >  	local: *;
> >  };
> > @@ -40,9 +45,4 @@ EXPERIMENTAL {
> >
> >  	rte_pmd_ixgbe_get_fdir_info;
> >  	rte_pmd_ixgbe_get_fdir_stats;
> > -	rte_pmd_ixgbe_mdio_lock;
> > -	rte_pmd_ixgbe_mdio_unlock;
> > -	rte_pmd_ixgbe_mdio_unlocked_read;
> > -	rte_pmd_ixgbe_mdio_unlocked_write;
> > -	rte_pmd_ixgbe_upd_fctrl_sbp;
> >  };
> 
> 
> --
> Regards, Ray K

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [DPDK v4] net/ixgbe: promote MDIO API
  2022-04-12 17:56   ` [DPDK v3] " zhichaox.zeng
  2022-04-14  2:52     ` Wang, Haiyue
  2022-04-15 14:36     ` Ray Kinsella
@ 2022-04-19 11:06     ` zhichaox.zeng
  2022-04-24  8:33       ` Zeng, ZhichaoX
  2 siblings, 1 reply; 14+ messages in thread
From: zhichaox.zeng @ 2022-04-19 11:06 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, haiyue.wang, mdr, Zhichao Zeng

From: Zhichao Zeng <zhichaox.zeng@intel.com>

Promote the MDIO APIs to be stable.

Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..426fe5845b 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
@@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
@@ -725,7 +721,6 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
 	rte_pmd_ixgbe_macsec_enable;
 	rte_pmd_ixgbe_macsec_select_rxsa;
 	rte_pmd_ixgbe_macsec_select_txsa;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
 	rte_pmd_ixgbe_ping_vf;
 	rte_pmd_ixgbe_set_all_queues_drop_en;
 	rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
-- 
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [DPDK v4] net/ixgbe: promote MDIO API
  2022-04-19 11:06     ` [DPDK v4] " zhichaox.zeng
@ 2022-04-24  8:33       ` Zeng, ZhichaoX
  2022-04-26 10:11         ` Ray Kinsella
  0 siblings, 1 reply; 14+ messages in thread
From: Zeng, ZhichaoX @ 2022-04-24  8:33 UTC (permalink / raw)
  To: dev; +Cc: Yang, Qiming, Wang, Haiyue, David Marchand, Ray Kinsella

Hi, Ray, David:

What is your opinion on this patch?

Regards,
Zhichao

-----Original Message-----
From: Zeng, ZhichaoX <zhichaox.zeng@intel.com> 
Sent: Tuesday, April 19, 2022 7:06 PM
To: dev@dpdk.org
Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
Subject: [DPDK v4] net/ixgbe: promote MDIO API

From: Zhichao Zeng <zhichaox.zeng@intel.com>

Promote the MDIO APIs to be stable.

Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..426fe5845b 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data); @@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data); @@ -725,7 +721,6 @@ enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
 int
 rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
 	rte_pmd_ixgbe_macsec_enable;
 	rte_pmd_ixgbe_macsec_select_rxsa;
 	rte_pmd_ixgbe_macsec_select_txsa;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
 	rte_pmd_ixgbe_ping_vf;
 	rte_pmd_ixgbe_set_all_queues_drop_en;
 	rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@ EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };
--
2.25.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [DPDK v4] net/ixgbe: promote MDIO API
  2022-04-24  8:33       ` Zeng, ZhichaoX
@ 2022-04-26 10:11         ` Ray Kinsella
  2022-04-27  1:07           ` Zhang, Qi Z
  0 siblings, 1 reply; 14+ messages in thread
From: Ray Kinsella @ 2022-04-26 10:11 UTC (permalink / raw)
  To: Zeng, ZhichaoX; +Cc: dev, Yang, Qiming, Wang, Haiyue, David Marchand


Zeng, ZhichaoX <zhichaox.zeng@intel.com> writes:

> Hi, Ray, David:
>
> What is your opinion on this patch?
>
> Regards,
> Zhichao
>
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com> 
> Sent: Tuesday, April 19, 2022 7:06 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Subject: [DPDK v4] net/ixgbe: promote MDIO API
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> Promote the MDIO APIs to be stable.
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 5 insertions(+), 10 deletions(-)
>

Acked-by: Ray Kinsella <mdr@ashroe.eu>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [DPDK v4] net/ixgbe: promote MDIO API
  2022-04-26 10:11         ` Ray Kinsella
@ 2022-04-27  1:07           ` Zhang, Qi Z
  0 siblings, 0 replies; 14+ messages in thread
From: Zhang, Qi Z @ 2022-04-27  1:07 UTC (permalink / raw)
  To: Ray Kinsella, Zeng, ZhichaoX
  Cc: dev, Yang, Qiming, Wang, Haiyue, David Marchand



> -----Original Message-----
> From: Ray Kinsella <mdr@ashroe.eu>
> Sent: Tuesday, April 26, 2022 6:12 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; David Marchand <david.marchand@redhat.com>
> Subject: Re: [DPDK v4] net/ixgbe: promote MDIO API
> 
> 
> Zeng, ZhichaoX <zhichaox.zeng@intel.com> writes:
> 
> > Hi, Ray, David:
> >
> > What is your opinion on this patch?
> >
> > Regards,
> > Zhichao
> >
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Tuesday, April 19, 2022 7:06 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>
> > Subject: [DPDK v4] net/ixgbe: promote MDIO API
> >
> > From: Zhichao Zeng <zhichaox.zeng@intel.com>
> >
> > Promote the MDIO APIs to be stable.
> >
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h |  5 -----
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 5 insertions(+), 10 deletions(-)
> >
> 
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-04-27  1:07 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12 14:27 [DPDK] drivers/net/ixgbe: remove expired symbols zhichaox.zeng
2022-04-12  7:23 ` Wang, Haiyue
2022-04-12  8:47   ` David Marchand
2022-04-12  8:38 ` Bruce Richardson
2022-04-12  8:52   ` Wang, Haiyue
2022-04-12 16:16 ` [DPDK v2] net/ixgbe: promote MDIO API zhichaox.zeng
2022-04-12 17:56   ` [DPDK v3] " zhichaox.zeng
2022-04-14  2:52     ` Wang, Haiyue
2022-04-15 14:36     ` Ray Kinsella
2022-04-18  6:41       ` Yang, Qiming
2022-04-19 11:06     ` [DPDK v4] " zhichaox.zeng
2022-04-24  8:33       ` Zeng, ZhichaoX
2022-04-26 10:11         ` Ray Kinsella
2022-04-27  1:07           ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).