From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A8A0A04F1; Mon, 9 Dec 2019 10:25:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 665432BAB; Mon, 9 Dec 2019 10:25:28 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id CB97423D for ; Fri, 6 Dec 2019 23:51:05 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id z124so4021509pgb.13 for ; Fri, 06 Dec 2019 14:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=upjZ15T36O05bA8GpOfozg6fmUfM/0hc6hfUb40rF0g=; b=Go+L6xT4Ha5HADV0pKpQ5vQcpIOeQ22dJfz4KNK4gKcftQScWouUXzZXH2RAU09bC2 CtG2yyIhwpQH6IM5iL+JR5bYvTsVWiCXkFBnkYXT2obUf3Ec/gzMtL80g7R4u+nJBDUa uUTUvkEJM5/4yFfhp4PNtygKraNoakaDF7TgRAcio2S7CznV4vfhg9G1s3LGZ8KPJOwX 600Y8lTR4PScjSkbatfkV3Oh7lSgm/1Ju8vhoeG1bChf750nTFkryHJUmPFzcGqAbCCu B3jABCJsWyNldlsEndH1vbGfOWxmumtRVFfVvEZD8VB8n9PKC9et/XvTeASAg9ptN/Ng Swmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=upjZ15T36O05bA8GpOfozg6fmUfM/0hc6hfUb40rF0g=; b=SUX6Ty0i4pY2+hNKnfHSIOwO2XskUm/OFfLKlwZRAPuJ6jXVdikrf0fC1GfQeEABmP dj38+LuJxNNP91EzWXgyEs10i7AgE7Km3NHtBtE2y3+Cmw+LR4HimT2kgOiPlGUjWB9I E2RIFuPa1s2QkDSIsDTt+eO7GywOPk4oqjJmzC8soQSvOoPiC6vJ12KOUKUVDizifNmx VxztdZxG5iXhWmpOFQ8Az4SFkasItYEe09nUGjxqe3anQlV3UwTuLl2cyNCf7QTeMntn r3q66L25K+awkoZSQjvkJWJNqMzVFk3Vvlb/PmCaKXHh8etDd/+5G8cIshpFiKEj0LlQ 78Eg== X-Gm-Message-State: APjAAAWxm/MkHrubwvVKz4Vg9tRkhO5ZMoW+hK+TA8xqKVQ9gCadZ2iO aTHUiH8ImBgSQBnVqSefrb+ZrqbgR5c= X-Google-Smtp-Source: APXvYqyCSsDc4leoXn2wypbp7/FUOP2W5U9exKa2+8ahlzevbofQ0FZDcy7JMuBF9AxzLkY7nXbI4w== X-Received: by 2002:a63:106:: with SMTP id 6mr6205679pgb.190.1575672664521; Fri, 06 Dec 2019 14:51:04 -0800 (PST) Received: from localhost (node-1w7jr9ss2r87ipezt91bdu6xx.ipv6.telus.net. [2001:569:bdb0:bb00::7a5]) by smtp.gmail.com with ESMTPSA id x197sm17932940pfc.1.2019.12.06.14.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 14:51:03 -0800 (PST) From: Rafael Avila de Espindola To: dev@dpdk.org Cc: Thomas Monjalon In-Reply-To: <20191025012013.118919-1-espindola@scylladb.com> References: <20191025012013.118919-1-espindola@scylladb.com> Date: Fri, 06 Dec 2019 14:51:03 -0800 Message-ID: <87sglxukyw.fsf@espindo.la> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 09 Dec 2019 10:25:26 +0100 Subject: Re: [dpdk-dev] [PATCH] Don't combine '-r' and '--export-dynamic' linker options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Are you the right maintainer fer reviewing this patch? Thanks, Rafael Rafael =C3=81vila de Esp=C3=ADndola writes: > Running ld with '-r' switches the linker to a very special mode where > some other linker options don't make sense. > > In particular, '--export-dynamic' normally requires that all global > symbols be included in the dynamic symbol table, but a .o file doesn't > even have a dynamic symbol table. > > When given both options it looks like the gnu linker just ignores > '--export-dynamic'. > > Unfortunately some versions of lld (https://lld.llvm.org/) have a bug > that causes it to try to create a dynamic symbol table in the output > .o file and ends up corrupting it > (https://bugs.llvm.org/show_bug.cgi?id=3D43552). Current (git) version > of lld now issues an error. > > This patch drops $(LDFLAGS) when using -r. With this patch I can build > dpdk with lld. > > Signed-off-by: Rafael =C3=81vila de Esp=C3=ADndola > --- > mk/internal/rte.compile-pre.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre= .mk > index 0cf3791b4..6cd7e559a 100644 > --- a/mk/internal/rte.compile-pre.mk > +++ b/mk/internal/rte.compile-pre.mk > @@ -61,7 +61,7 @@ CHECK_EXPERIMENTAL =3D $(EXPERIMENTAL_CHECK) $(SRCDIR)/= $(EXPORT_MAP) $@ >=20=20 > PMDINFO_GEN =3D $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c > PMDINFO_CC =3D $(CC) $(CPPFLAGS) $(CFLAGS) $(EXTRA_CFLAGS) -c -o $@.pmd.= o $@.pmd.c > -PMDINFO_LD =3D $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ > +PMDINFO_LD =3D $(CROSS)ld -r -o $@.o $@.pmd.o $@ > PMDINFO_TO_O =3D if grep -q 'RTE_PMD_REGISTER_.*(.*)' $<; then \ > echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ > $(PMDINFO_GEN) && \ > --=20 > 2.21.0