From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D0B545A2C; Wed, 25 Sep 2024 21:33:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30A694025D; Wed, 25 Sep 2024 21:33:20 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2071.outbound.protection.outlook.com [40.107.220.71]) by mails.dpdk.org (Postfix) with ESMTP id 214EA400EF for ; Wed, 25 Sep 2024 21:33:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mBKc1OEOWtwS7yW+PL4E3FqHc6QD/zHVUn2SDa3LhnllRG7ZJ8jKrb28zc4FlAsXdtHU7nLczLDY6xSb5bHx/GRwtGXBo7ZG5j4nlwDVlh2CARlcEBJeJcrgQqn+T9lK+1RiADUri3M9/vnoMpTbgz7Ixhtkg1FuHq4vJmyikRTjG7bLawfoMSZpQmva4Sj0F9Sys6LQ3qZcFOJWw8hs1cto05Q6rN4XAZBiPwnOldY8G+2Z1ogOiAuxgOCXp9/mmnKkzqZoe2zv4lAp8akQGOai0+02+NWD1ISH3NB812Bri7+jHsq1TWpEG3a1j0ksCmINvkkKTGXe6vYsu9hu0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JxFVo7Gr8FjhNji7YRCpcCN5XGfS7k1TCliJLKUX0g=; b=rO0qYoS+9K+6LCEOrrRFhi1EVAKmjwFrwrAShMybgE7WEzwf3YVbxgSqAxFMdgNHsHce7s9x2/dRghqET5A+hnceJpJxJSAl4OC1Nt8epX1vZRrJ05CKeKBFriuSRpnrl5bitYdjHJ9B+zwjGr8s3BArVQiB1lXTB7UivzYX9GQEMh6GBLhBi4lwHYdLXsN9vXSgPH98p7W4cj2rhNWWBDUCewZgAknR2ZOkNdIrMonj2P+UXb+UtMXm9WH0w9d6zsJvxqsBSP9ry3YywSAJqxEhNEKKGGZQ5y2m7zEfQWiYfgeMIuo919viX7J7n1B4I6l5Fecsjld3EijzB9z1FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+JxFVo7Gr8FjhNji7YRCpcCN5XGfS7k1TCliJLKUX0g=; b=B0ystrJCjjgfF5a0dLqRysCbHZa/5dj9oactXNfB/MHajrL1etxhzDhEZexvX6la335gCSf8KLJHJBtARE8KuCWG+jrBraOIv2Dv6tp8K4tqtE92OP/lhhioDpmZQ6Lhp+6zSndwql8iQ5PwKsSTPpabnG/JYmX7YMEd0X4Wd1E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CY8PR12MB7729.namprd12.prod.outlook.com (2603:10b6:930:84::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Wed, 25 Sep 2024 19:33:14 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.7982.022; Wed, 25 Sep 2024 19:33:12 +0000 Message-ID: <88159ce2-3b91-4eba-b13e-d0edb47ba4b4@amd.com> Date: Wed, 25 Sep 2024 20:33:07 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ethdev: add Rx packet type offload control flag To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , Long Wu References: <20240619101134.3480274-1-chaoyong.he@corigine.com> <20240619101134.3480274-2-chaoyong.he@corigine.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0058.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::19) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CY8PR12MB7729:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d774aeb-bd5c-45f1-85d2-08dcdd98e4e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R01ld2d5cTdiYWhvVmNWQnUwTXU3cTg1OG92cU9kL1laQVM2ZGdnc0orc1Bn?= =?utf-8?B?bFhSZUVZTm00UWNrb2tXVy83ODVpOHFuUUZrS0pMZ1k4UEtLR1Fmc3JXb3Rq?= =?utf-8?B?dG1CWkNhZWxNMXlSK2lXdG5YOWwwMmZiTjFDdHMzSTZVZVBhQmZVK3pSSlJu?= =?utf-8?B?amVIbXAzZ1hwUzg3UUJ5SzFES0pYa3Y3ZjJ4RGdyMVB6YmlNMk1TYzhkY1pE?= =?utf-8?B?UEE0RUdvbC8zd0ZTb1hBZXdwZlljUEV6RFhJL2poaFVXWXBXUSswNmo1di9x?= =?utf-8?B?R1p6cVlxcVZXa1hveEIxQVdLMnNza3psOUZjK1h2SEcyczNQSzV0YWczNGNM?= =?utf-8?B?N1Bmcng4ZHU3ODRMOUZwMUtSMzZDNDJSUTBwYWc1Y2psaVUwanJROVpOS0Rk?= =?utf-8?B?UDJMZkc0SHh0T0VvTVk5NURNaHVFcittVEtwT2thM3gyZGsxMVFzZG1lR1BR?= =?utf-8?B?MHpPUGxnM2pkeXArL2lHZDBiV1VNcXVONCtUZE5yWmR6eFZ3eWNwbW5JaEhp?= =?utf-8?B?TDZKeEVJTHhkNTVrSkhmWGUyTU9aRlVUWkhMYUNzWkhzelliNFhUZ21VazZY?= =?utf-8?B?aDA0LzhnbTg0ZmJsdTRFb3RXbkY0aFJNUlFQbTU5bEVZKzNqZDJsdmN6b1RH?= =?utf-8?B?a0prMWhGdENIQ2Q5RXlLWDcyUS9lVGNhbVRqK0lmYjk4N2E3aWR5Q3ljNDZX?= =?utf-8?B?Q1dSVmxZTDhFeFhQdzBYTHg1aC8valZxMXJYWEVxdTVhL0RHVnJ0elNtRzk0?= =?utf-8?B?UjArRWVYVnlTZVJ1UzYxZHZGSndYcGJITmdxUWRFWEZuU2VMM3lVYU9JZ2Z5?= =?utf-8?B?bW9heDliRy9mWE4veXVMVDRPOWZManQ5T3gzUCs1ck9veFJ4bkhTRnhKd3RV?= =?utf-8?B?WDNpTlNGNVRwM2JyeWRqR3kyQ1V5RXFGK1lUMDBWQWlSdFpHend0ajlHZmFL?= =?utf-8?B?VXRVTERLcEN3bW5OWWp4a3FwYkI0bGFxcUtxQW1HNVZ3aTdTNmdyZEtOMzNm?= =?utf-8?B?aWxwRkNrdnAyR3YvYTNjTXUvVW91d2YyT2VJcjh3cHA5Y2tORHBaWnFmTlE5?= =?utf-8?B?bk5jMWxwcFJPZHJhbzBPYm8rTG9BZnJwODUvUU1BWkZqMFFaVzJQQ1BhVk51?= =?utf-8?B?Mk9pUDl1UDd5eHVCK0tuTjZsMGx4RVpuVXVjWHJ5eVV4cEU3K2xCTnJ6ZE9Y?= =?utf-8?B?Z2hTMkhHc0hTTDFWT1VEZjBDZEFQWDV1NUhvdFVHaTlneWFMbGdrYmRpTUxq?= =?utf-8?B?bHhHMzVDai9HbTFHeWQ0WXduUWJaOUxESUpHYTFGWmtYVURmWFJIVThJT1g4?= =?utf-8?B?SW82WitMOVpJbUFFVGlzaFdEa2prTldPNTRSMjkrV1pLQ1JHaW5JNDI3NG9M?= =?utf-8?B?dGhVN1RMdVRUNXU1MmdPYldYOUpINVJ0ekJRRzRBMCtRMFkyVTlYUnMxbTgy?= =?utf-8?B?KzlFbVpaVTh4UWN5UjRTak1kNXUyWVd2cENmTWY2ckVLM1Q4SDE0WHBKME9v?= =?utf-8?B?ZUNDenlyTjQyM1QwZ0hQWWQ2ME8yN0VVM2RWUkw2dVhqMWg0Q051VXFDR1BZ?= =?utf-8?B?RGVMSTF4Qkw0R2EvL2Z1WDdWRXNJeW9nd003V01ES1dHd2VXZERQeW5HdXNM?= =?utf-8?B?K3d6U1U2em1kQTNYQlU2NHpzYURXTGw5VVlzSzN3SC9Sa3BrdDJnbkc1VDUv?= =?utf-8?B?VEtvSDc3UXVyWmpLd3pzOUxMQUZ5NWxpK0NtQWxCN2o3R3NPOSswaFBWd2tS?= =?utf-8?B?WUxvZ0dmd3JnYS9lRzd3QlNCMWdxWXZ0QkRmR0Nyb1RzRGF1V3kzL1FtT3Zw?= =?utf-8?B?NCtUcG5TS0VYSVY2UHRIQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk92VGdrNVRHaDN4aTdva2JSb0phbWpkcTlhYU5SSm44elcybklUR05DYjJH?= =?utf-8?B?akNpT05hcXBqQmpuck9KUUN2bXBjRHc3N0YzaHBHTHAySEN2cHNEeGVYbFRl?= =?utf-8?B?c0V3OE8rbnlZcmtkQ1VDeVJrTGJOcXRIOEhDaFZtUW9SV3p1eEdGbU53MlJm?= =?utf-8?B?UFc3RGwwK1NqOHRsVDVuQjdEQUdWdnRGMXhHaTFodjArMHBqcE1Cb0NYb0Q0?= =?utf-8?B?VWtyejZNUEZmaXhJYlZDSGRRUjZybHF3RHZMZW5WaXdKVzZ1OHE4NUM0VWZr?= =?utf-8?B?TVl5aHNIN2Fsay9vOW9NMW9LS1JLWnRXbnlkUHBicGwxZkV3aTd6TlRRa2NY?= =?utf-8?B?bFVKZ0hnUFIrRWx4Ym83OERVajdua21Na0lRcW5iTVE3VnR6OG5Qc2pwT2FG?= =?utf-8?B?ODFxd2kzbk9rVWhGOHNtdVRYRWRNaXVZb1kyQ3Vpb2VZbjFoYk04MHljQlZS?= =?utf-8?B?bEJpQ3I4NFVyaFM1UnJWQzJlaU0zS0ZTQ3ZLQzhOdkx5bDAwR0E3Wk5vUEV3?= =?utf-8?B?TTdyWFphZEdrWjRjUGtVZVBKOE9CVWVmNUU4NGFHTlNCazdHQ2hYK2FLT1NZ?= =?utf-8?B?TnpnZnhMYUtkZnpWY0s0VG5RdVNLd294SUdJdmRhYVNoVmRmWVo1QStoVW90?= =?utf-8?B?Tm9zZ0RSNjg2OFdyRG5qV2EySnVYYnZkdWZSQTM0QzRudzdPTGl6WVZBVVhP?= =?utf-8?B?b1I2U3piVnRqSmRRbit0cjg5ckREcVhLSEdoVzZwZDZ1bEhpbWV1eXpMR3hO?= =?utf-8?B?NTNzNzJCVm1ocG5MUng4dnFCVzJMVDM1R2REUXBoZWNXTFVqVlVxQzRqWFYz?= =?utf-8?B?V0dseU44bXVxb1ZSQktEb1lUcGt4NWhsUlBuRXF4dDIvaUVydDA5RlZqcnY3?= =?utf-8?B?QWUyMjhxWHYrQVNrUEM5OGdHSXB1WTBHMklQbHFsOXFxaDRtVjVKVVdLRTVL?= =?utf-8?B?aWVtK0g1emFsdlRIR295M3BCY1UvSGNhT0NVVmtMaU5ZUWI1eDN4YlZQY2pV?= =?utf-8?B?N1lkSHd3RHR6ZWFiODZpWUJWOEJjNmZzTFNXRCsxTmZrckJDOXRwZys3cTlm?= =?utf-8?B?T3pJdmRHNHFTNHVJZ09jdjJFSUFjRDhJSEZ3VVRMcHNDanIzV0xYQ0xuNnU1?= =?utf-8?B?WFJVSmhLeENtekdtbGxQUnN5bkIzZzZPQmRlMHc0bGMrYUJPZVJYN2JPK1JL?= =?utf-8?B?dVRTdWZ4QjBQenBUT3RLK0J5S284NmhZVnMwSnBwV05tOVBCb3VvREpEdmhU?= =?utf-8?B?UW4vZHpIT2NtR25nVEd1bm1qVjdEOXVFZ2cvL1dFWU5LUFgvYStXcFNPRkto?= =?utf-8?B?WkxxTkNvenpJd0R3bWVEd0FoVlVCdEhQVHRtYVdiNWlLTC9PR0ZoZ0ZzdGtH?= =?utf-8?B?aENSd24vK2tsaGZqdU1zS1Y2UE9CaU5Hc0RFRnQvOTdpRFlBRFBUZmU4WVF5?= =?utf-8?B?UkhRZmhRcWUyNFZVbWI5TXpQYzZwQ1hvS3pHZlYyMVV5M0pQM2hJTDZ5Q3RN?= =?utf-8?B?L1FhM0E1R3d2Mnk0NUdjbHdlTWxPek92TkowSy9aQXlsWklrVFRwYUVyeVA2?= =?utf-8?B?Y3N4MkFGSCtVU2pzcTdhTTFTK0MxajdPZWdqbjBkbXhsbE9QSW1acXBuK0Iv?= =?utf-8?B?SFhCdG5VQlkyRXNoYTJua01LZ2hCanB3dlJha1YzalVEbnF1Sld0di8xaTZV?= =?utf-8?B?QXk1cG0xS3NySHlwTEVoNk0wR1YzUVhrMTZhK01pbUk1QzJQUnU4dlRJN0dq?= =?utf-8?B?N05PL2ZMcmVBSHdlbGg1MHNLZU1mMmlUU2ZrbmZ6Q3pneEs4aUkrR1hEa2N2?= =?utf-8?B?REY0am1lZXpNOG9XWUljaUNtaGJ5V2oxenVIQ2l6MmR2ZHVxeEZQTnM3NDFx?= =?utf-8?B?S3Nmb3BsRkVoenZMVFJTaTVDTC93OXQ5bW9vU0I3SVhnV1JFUThnYUNHcWpL?= =?utf-8?B?eFlDOWt5Szd0RFhLOVk1V1o0bzRWWkpVcG5rc00yT3hyVzRUbnNya2hjQ25H?= =?utf-8?B?MVVtWmhBbDV2Vnd1Y29wVXA3OWlUdkVqdVlhK1pkMFRNdmVXMDdGOGo1SEww?= =?utf-8?B?SFRsVUkveVAzTmE0Q21xT0FBV3hhL0w2Z2oza1dZVnRVWHdBc2ZvUTJrYllt?= =?utf-8?Q?835vmqtPn6AB25XuuxYfx6UUt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d774aeb-bd5c-45f1-85d2-08dcdd98e4e8 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2024 19:33:12.7835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CksRsATxETDbxxm/HXsHC9g8OC8FYTekUwE/pdaW9BqUxHRSqKxZjrVo9c/1LMY0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7729 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/24/2024 3:03 AM, Chaoyong He wrote: >> On 6/19/2024 11:11 AM, Chaoyong He wrote: >>> From: Long Wu >>> >>> The Rx packet type offload feature may affect the performance, so add >>> a control flag for applications to turn it on or off. >>> >>> Signed-off-by: Long Wu >>> --- >>> lib/ethdev/rte_ethdev.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index >>> 548fada1c7..be86983e24 100644 >>> --- a/lib/ethdev/rte_ethdev.h >>> +++ b/lib/ethdev/rte_ethdev.h >>> @@ -1555,6 +1555,7 @@ struct rte_eth_conf { #define >>> RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM RTE_BIT64(18) >>> #define RTE_ETH_RX_OFFLOAD_RSS_HASH RTE_BIT64(19) >>> #define RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT RTE_BIT64(20) >>> +#define RTE_ETH_RX_OFFLOAD_PTYPES RTE_BIT64(21) >>> >>> #define RTE_ETH_RX_OFFLOAD_CHECKSUM >> (RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | \ >>> RTE_ETH_RX_OFFLOAD_UDP_CKSUM | \ >> >> Hi Chaoyong, >> >> Instead of having an offload for ptypes, we have APIs for this, >> >> First one is 'rte_eth_dev_get_supported_ptypes()' that application can learn >> the supported packet types. >> >> Second one is more related to above flag, it is 'rte_eth_dev_set_ptypes()' >> which application can set which pytpes is required, it can be set to disable all >> packet type parsing, can be similar to not requesting >> 'RTE_ETH_RX_OFFLOAD_PTYPES'. >> >> With above two APIs, do we still need the offload flag? >> > > At present, the purpose of the ops 'rte_eth_dev_set_ptypes()' is to set the range of packet types to handle. > Yes, and setting 'ptype_mask' to zero should disable packet type parsing. Packet type parsing is an offload, but when we have an API that has finer grained control to what packet type to parse, why not use it instead of having offload flag, which is all on or off configuration. > Of course, we can maintain a flag for each application and driver based on the return value of this ops; > but this is a bit troublesome. > I didn't get your point, why maintain a flag? > So, we hope to follow the example of RSS, in addition to > 'rte_eth_dev_rss_hash_update()' and 'rte_eth_dev_rss_hash_conf_get()', we also want to set a flag for > the ptype function similar to RTE_ETH_RX_OFFLOAD_RSS_HASH. > >> >> Another concern with adding new offload flag is backward compatibility, all >> existing drivers that support packet type parsing should be updated to list this >> offload flag as capability. Also they need to be updated to configure packet >> parsing based on user requested offload configuration. >> > > If you agree with this design suggestion, we will adapt all the related code to ptypes for each PMDs and 'test-pmd' applications in the next patch. > Do you think this okay? > >> Briefly, we can't just introduce a new offload flag for an existing capability and >> update only one driver, all drivers needs to be updated.