[dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Allain Legacy]

The AVP devices are only supported on Intel 64-bit architectures so
adjusting the defconfig attributes accordingly.

Fixes: c5ab4707ba97 ("net/avp: support driver registration")

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
---
 config/common_linuxapp                        | 1 -
 config/defconfig_i686-native-linuxapp-gcc     | 5 -----
 config/defconfig_i686-native-linuxapp-icc     | 5 -----
 config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
 config/defconfig_x86_64-native-linuxapp-gcc   | 6 ++++++
 config/defconfig_x86_64-native-linuxapp-icc   | 5 +++++
 config/defconfig_x86_x32-native-linuxapp-gcc  | 5 -----
 7 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/config/common_linuxapp b/config/common_linuxapp
index b3cf41b01..d03a60a2e 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -44,7 +44,6 @@ CONFIG_RTE_LIBRTE_VHOST=y
 CONFIG_RTE_LIBRTE_PMD_VHOST=y
 CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
 CONFIG_RTE_LIBRTE_PMD_TAP=y
-CONFIG_RTE_LIBRTE_AVP_PMD=y
 CONFIG_RTE_LIBRTE_NFP_PMD=y
 CONFIG_RTE_LIBRTE_POWER=y
 CONFIG_RTE_VIRTIO_USER=y
diff --git a/config/defconfig_i686-native-linuxapp-gcc b/config/defconfig_i686-native-linuxapp-gcc
index 9847bdb6c..745c4011f 100644
--- a/config/defconfig_i686-native-linuxapp-gcc
+++ b/config/defconfig_i686-native-linuxapp-gcc
@@ -75,8 +75,3 @@ CONFIG_RTE_LIBRTE_PMD_KASUMI=n
 # ZUC PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_PMD_ZUC=n
-
-#
-# AVP PMD is not supported on 32-bit
-#
-CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/config/defconfig_i686-native-linuxapp-icc b/config/defconfig_i686-native-linuxapp-icc
index 269e88e95..50a3008fc 100644
--- a/config/defconfig_i686-native-linuxapp-icc
+++ b/config/defconfig_i686-native-linuxapp-icc
@@ -75,8 +75,3 @@ CONFIG_RTE_LIBRTE_PMD_KASUMI=n
 # ZUC PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_PMD_ZUC=n
-
-#
-# AVP PMD is not supported on 32-bit
-#
-CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/config/defconfig_x86_64-native-linuxapp-clang b/config/defconfig_x86_64-native-linuxapp-clang
index 7b1102fde..012c066c0 100644
--- a/config/defconfig_x86_64-native-linuxapp-clang
+++ b/config/defconfig_x86_64-native-linuxapp-clang
@@ -41,3 +41,8 @@ CONFIG_RTE_ARCH_64=y
 
 CONFIG_RTE_TOOLCHAIN="clang"
 CONFIG_RTE_TOOLCHAIN_CLANG=y
+
+#
+# AVP PMD is only supported on Intel 64-bit machines
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=y
diff --git a/config/defconfig_x86_64-native-linuxapp-gcc b/config/defconfig_x86_64-native-linuxapp-gcc
index e69a37e0e..11fff7d82 100644
--- a/config/defconfig_x86_64-native-linuxapp-gcc
+++ b/config/defconfig_x86_64-native-linuxapp-gcc
@@ -41,3 +41,9 @@ CONFIG_RTE_ARCH_64=y
 
 CONFIG_RTE_TOOLCHAIN="gcc"
 CONFIG_RTE_TOOLCHAIN_GCC=y
+
+#
+# AVP PMD is only supported on Intel 64-bit machines
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=y
+
diff --git a/config/defconfig_x86_64-native-linuxapp-icc b/config/defconfig_x86_64-native-linuxapp-icc
index 872d1a1b3..8281fa145 100644
--- a/config/defconfig_x86_64-native-linuxapp-icc
+++ b/config/defconfig_x86_64-native-linuxapp-icc
@@ -46,3 +46,8 @@ CONFIG_RTE_TOOLCHAIN_ICC=y
 # Solarflare PMD build is not supported using icc toolchain
 #
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
+
+#
+# AVP PMD is only supported on Intel 64-bit machines
+#
+CONFIG_RTE_LIBRTE_AVP_PMD=y
diff --git a/config/defconfig_x86_x32-native-linuxapp-gcc b/config/defconfig_x86_x32-native-linuxapp-gcc
index 19573cb50..3e55c5cac 100644
--- a/config/defconfig_x86_x32-native-linuxapp-gcc
+++ b/config/defconfig_x86_x32-native-linuxapp-gcc
@@ -50,8 +50,3 @@ CONFIG_RTE_LIBRTE_KNI=n
 # Solarflare PMD is not supported on 32-bit
 #
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
-
-#
-# AVP PMD is not supported on 32-bit
-#
-CONFIG_RTE_LIBRTE_AVP_PMD=n
-- 
2.12.1

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Ferruh Yigit]

On 4/4/2017 5:36 PM, Allain Legacy wrote:
> The AVP devices are only supported on Intel 64-bit architectures so
> adjusting the defconfig attributes accordingly.
> 
> Fixes: c5ab4707ba97 ("net/avp: support driver registration")
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
>  config/common_linuxapp                        | 1 -
>  config/defconfig_i686-native-linuxapp-gcc     | 5 -----
>  config/defconfig_i686-native-linuxapp-icc     | 5 -----
>  config/defconfig_x86_64-native-linuxapp-clang | 5 +++++

Right now compiler config files only have compiler and architecture
configs, although it is OK to update them, to be consistent with what
other PMDs did, what do you think:

Keep AVP config enabled in "common_linuxapp"

Disable AVP in following configs:
defconfig_arm64-armv8a-linuxapp-gcc
defconfig_arm-armv7a-linuxapp-gcc
defconfig_ppc_64-power8-linuxapp-gcc

>  config/defconfig_x86_64-native-linuxapp-gcc   | 6 ++++++
>  config/defconfig_x86_64-native-linuxapp-icc   | 5 +++++
>  config/defconfig_x86_x32-native-linuxapp-gcc  | 5 -----
>  7 files changed, 16 insertions(+), 16 deletions(-)
> 
<...>

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Legacy, Allain]

> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Tuesday, April 04, 2017 1:12 PM
<...>
> 
> Right now compiler config files only have compiler and architecture configs,
> although it is OK to update them, to be consistent with what other PMDs did,
> what do you think:
> 
> Keep AVP config enabled in "common_linuxapp"
> 
> Disable AVP in following configs:
> defconfig_arm64-armv8a-linuxapp-gcc
> defconfig_arm-armv7a-linuxapp-gcc
> defconfig_ppc_64-power8-linuxapp-gcc

If that is your preference I can update the patch but either way a compiler config file is going to be changed.   I did it the current way so that if a new architecture came along that they would not need to know to set AVP=n in their file. 

Do you still want me to align to your suggestion? 

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Ferruh Yigit]

On 4/4/2017 6:17 PM, Legacy, Allain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Tuesday, April 04, 2017 1:12 PM
> <...>
>>
>> Right now compiler config files only have compiler and architecture configs,
>> although it is OK to update them, to be consistent with what other PMDs did,
>> what do you think:
>>
>> Keep AVP config enabled in "common_linuxapp"
>>
>> Disable AVP in following configs:
>> defconfig_arm64-armv8a-linuxapp-gcc
>> defconfig_arm-armv7a-linuxapp-gcc
>> defconfig_ppc_64-power8-linuxapp-gcc
> 
> If that is your preference I can update the patch but either way a compiler config file is going to be changed.   
> I did it the current way so that if a new architecture came along that they would not need to know to set AVP=n in their file.

Indeed, this makes sense.

> 
> Do you still want me to align to your suggestion?

I still believe good to be consistent with current usage. They all can
be fixed later, for example when a new architecture added, in one go.

Thanks,
ferruh

[dpdk-dev] [PATCH v2] config: compile avp driver only on intel 64 bit

[Allain Legacy]

The AVP devices are only supported on Intel 64-bit architectures so
adjusting the defconfig attributes accordingly.

Fixes: 0485859868a9 ("net/avp: support driver registration")

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
---
 config/defconfig_arm-armv7a-linuxapp-gcc    | 1 +
 config/defconfig_arm64-armv8a-linuxapp-gcc  | 1 +
 config/defconfig_ppc_64-power8-linuxapp-gcc | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc b/config/defconfig_arm-armv7a-linuxapp-gcc
index d9bd2a839..44004a70a 100644
--- a/config/defconfig_arm-armv7a-linuxapp-gcc
+++ b/config/defconfig_arm-armv7a-linuxapp-gcc
@@ -75,3 +75,4 @@ CONFIG_RTE_LIBRTE_PMD_XENVIRT=n
 CONFIG_RTE_LIBRTE_PMD_BNX2X=n
 CONFIG_RTE_LIBRTE_QEDE_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
+CONFIG_RTE_LIBRTE_AVP_PMD=n
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index aef5431d2..65888cef1 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -46,5 +46,6 @@ CONFIG_RTE_EAL_IGB_UIO=n
 
 CONFIG_RTE_LIBRTE_FM10K_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
+CONFIG_RTE_LIBRTE_AVP_PMD=n
 
 CONFIG_RTE_SCHED_VECTOR=n
diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc
index ceddd4118..71e4c3532 100644
--- a/config/defconfig_ppc_64-power8-linuxapp-gcc
+++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
@@ -55,4 +55,4 @@ CONFIG_RTE_LIBRTE_PMD_BOND=n
 CONFIG_RTE_LIBRTE_ENIC_PMD=n
 CONFIG_RTE_LIBRTE_FM10K_PMD=n
 CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
-
+CONFIG_RTE_LIBRTE_AVP_PMD=n
-- 
2.12.1

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Bruce Richardson]

On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote:
> On 4/4/2017 5:36 PM, Allain Legacy wrote:
> > The AVP devices are only supported on Intel 64-bit architectures so
> > adjusting the defconfig attributes accordingly.
> > 
> > Fixes: c5ab4707ba97 ("net/avp: support driver registration")
> > 
> > Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> > ---
> >  config/common_linuxapp                        | 1 -
> >  config/defconfig_i686-native-linuxapp-gcc     | 5 -----
> >  config/defconfig_i686-native-linuxapp-icc     | 5 -----
> >  config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
> 
> Right now compiler config files only have compiler and architecture
> configs, although it is OK to update them, to be consistent with what
> other PMDs did, what do you think:
> 
> Keep AVP config enabled in "common_linuxapp"
> 
> Disable AVP in following configs:
> defconfig_arm64-armv8a-linuxapp-gcc
> defconfig_arm-armv7a-linuxapp-gcc
> defconfig_ppc_64-power8-linuxapp-gcc
> 

I actually disagree with that, and I think the approach proposed is
better, given that it's only one target type that is supported.

However, I think we should have an AVP config option in common base, set
to "n", so that we at least there have an entry to indicate it exists.

/Bruce

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Thomas Monjalon]

2017-04-05 09:23, Bruce Richardson:
> On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote:
> > On 4/4/2017 5:36 PM, Allain Legacy wrote:
> > > The AVP devices are only supported on Intel 64-bit architectures so
> > > adjusting the defconfig attributes accordingly.
> > > 
> > > Fixes: c5ab4707ba97 ("net/avp: support driver registration")
> > > 
> > > Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> > > ---
> > >  config/common_linuxapp                        | 1 -
> > >  config/defconfig_i686-native-linuxapp-gcc     | 5 -----
> > >  config/defconfig_i686-native-linuxapp-icc     | 5 -----
> > >  config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
> > 
> > Right now compiler config files only have compiler and architecture
> > configs, although it is OK to update them, to be consistent with what
> > other PMDs did, what do you think:
> > 
> > Keep AVP config enabled in "common_linuxapp"
> > 
> > Disable AVP in following configs:
> > defconfig_arm64-armv8a-linuxapp-gcc
> > defconfig_arm-armv7a-linuxapp-gcc
> > defconfig_ppc_64-power8-linuxapp-gcc
> > 
> 
> I actually disagree with that, and I think the approach proposed is
> better, given that it's only one target type that is supported.
> 
> However, I think we should have an AVP config option in common base, set
> to "n", so that we at least there have an entry to indicate it exists.

Yes, seems reasonnable

Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit

[Ferruh Yigit]

On 4/5/2017 9:23 AM, Bruce Richardson wrote:
> On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote:
>> On 4/4/2017 5:36 PM, Allain Legacy wrote:
>>> The AVP devices are only supported on Intel 64-bit architectures so
>>> adjusting the defconfig attributes accordingly.
>>>
>>> Fixes: c5ab4707ba97 ("net/avp: support driver registration")
>>>
>>> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
>>> ---
>>>  config/common_linuxapp                        | 1 -
>>>  config/defconfig_i686-native-linuxapp-gcc     | 5 -----
>>>  config/defconfig_i686-native-linuxapp-icc     | 5 -----
>>>  config/defconfig_x86_64-native-linuxapp-clang | 5 +++++
>>
>> Right now compiler config files only have compiler and architecture
>> configs, although it is OK to update them, to be consistent with what
>> other PMDs did, what do you think:
>>
>> Keep AVP config enabled in "common_linuxapp"
>>
>> Disable AVP in following configs:
>> defconfig_arm64-armv8a-linuxapp-gcc
>> defconfig_arm-armv7a-linuxapp-gcc
>> defconfig_ppc_64-power8-linuxapp-gcc
>>
> 
> I actually disagree with that, and I think the approach proposed is
> better, given that it's only one target type that is supported.

Agree that it is better, but other PMDs are doing what I suggested, so I
am for AVP follow the same, and fix them all later when required.

> 
> However, I think we should have an AVP config option in common base, set
> to "n", so that we at least there have an entry to indicate it exists.
> 
> /Bruce
> 

Re: [dpdk-dev] [PATCH v2] config: compile avp driver only on intel 64 bit

[Ferruh Yigit]

On 4/4/2017 6:37 PM, Allain Legacy wrote:
> The AVP devices are only supported on Intel 64-bit architectures so
> adjusting the defconfig attributes accordingly.
> 
> Fixes: 0485859868a9 ("net/avp: support driver registration")
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>

Applied to dpdk-next-net/master, thanks.