From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id D88D81DB1 for ; Wed, 5 Apr 2017 10:58:49 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id w43so4755049wrb.0 for ; Wed, 05 Apr 2017 01:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=fjLWg1dahVMmHPKYYOe46pqSIlM87PL4DN1+EzpH8d0=; b=DdutKPXo72/3ikzXoq+QMM+ccJT8CFjmqFy/THXhER/lirTSKJCGFn/Zr30E6wviJs kQ2wE60Yl4xJxkix3mwvei6v1iQZehddpKf2jfwUw9TqUTxCzzk7Ncl1A5swGL/nIQkH hKBrNanwEYZ7slyHfjKetUc2296mjg18y8NMAsBXMYl+BzqL8SBl2FheM2sQ4EhQ7e7s ieOsk4fh6Bg1FbLTaAR8m+sLNh+wbHfFCL913ssqBMaMi1JQ5v0nbuGD3P8BVlU3KmwF F6XPoNaS/jHIiwNfN8sKRg0h+z7Iny7WYXAWVIZIp8F4psWHnXA/DXfJ6J1oilIaSgE+ gDzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=fjLWg1dahVMmHPKYYOe46pqSIlM87PL4DN1+EzpH8d0=; b=mxN59MUC4Lh3hxnqGEZpcb159ydO6lG7pHeXelDcUtLwexbEK49MTL+AF7T46tfTgb cjfRARZiEG+ceSNg4UtJKPp0vLqogukB1lLkpw3jShpMYVraGFoUYjpL/eE4Q/DPSspS n9VvmNhMqZ4YD4C/zeyDcfbMRt+3sykoZ+ouFxMetn0PiE3I3f7xXYopSDYeHImyOJsH xhLhrz6CGHeR0Vy+I9yvWTeXaqZ3fJDm2PhJODkqxyQNpoYfkBOE79TrjtZAOVH6A81+ jNKiWG4D6fxtCI4zN/wb/y0q5joK3LkDyVO9y7pVz4QP0UXlsI0ozz0tYMWKlIn7YH6F rQzg== X-Gm-Message-State: AFeK/H1fPBrBNoRv+JNZX7NDsTl+R7SxiSiJFJEzvtct6dJ7aPjHFXsMLayUMvAzbOm3iqSD X-Received: by 10.223.160.5 with SMTP id k5mr26371619wrk.123.1491382729555; Wed, 05 Apr 2017 01:58:49 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id z88sm22226905wrb.1.2017.04.05.01.58.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 01:58:48 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson , Ferruh Yigit , Allain Legacy Cc: dev@dpdk.org Date: Wed, 05 Apr 2017 10:58:47 +0200 Message-ID: <8825815.qbYC4VjRtT@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> References: <20170404163654.86100-1-allain.legacy@windriver.com> <4712ffa9-b81c-bdef-ccc0-ae508d5b327d@intel.com> <20170405082308.GA19612@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] config: compile avp driver only on intel 64 bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 08:58:50 -0000 2017-04-05 09:23, Bruce Richardson: > On Tue, Apr 04, 2017 at 06:12:12PM +0100, Ferruh Yigit wrote: > > On 4/4/2017 5:36 PM, Allain Legacy wrote: > > > The AVP devices are only supported on Intel 64-bit architectures so > > > adjusting the defconfig attributes accordingly. > > > > > > Fixes: c5ab4707ba97 ("net/avp: support driver registration") > > > > > > Signed-off-by: Allain Legacy > > > --- > > > config/common_linuxapp | 1 - > > > config/defconfig_i686-native-linuxapp-gcc | 5 ----- > > > config/defconfig_i686-native-linuxapp-icc | 5 ----- > > > config/defconfig_x86_64-native-linuxapp-clang | 5 +++++ > > > > Right now compiler config files only have compiler and architecture > > configs, although it is OK to update them, to be consistent with what > > other PMDs did, what do you think: > > > > Keep AVP config enabled in "common_linuxapp" > > > > Disable AVP in following configs: > > defconfig_arm64-armv8a-linuxapp-gcc > > defconfig_arm-armv7a-linuxapp-gcc > > defconfig_ppc_64-power8-linuxapp-gcc > > > > I actually disagree with that, and I think the approach proposed is > better, given that it's only one target type that is supported. > > However, I think we should have an AVP config option in common base, set > to "n", so that we at least there have an entry to indicate it exists. Yes, seems reasonnable