From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EDBFA0548; Mon, 27 Sep 2021 14:23:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AB64410DA; Mon, 27 Sep 2021 14:23:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6F60A40E3C for ; Mon, 27 Sep 2021 14:23:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="224520947" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="224520947" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 05:23:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="537681644" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 27 Sep 2021 05:23:18 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 05:23:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 05:23:18 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 05:23:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aIHp4+enA71pK7IPzJDD2hghzWA+6UaDUjUnTbAvAdLEUHf6TdfZDn2P8GDJR5d33fAJg7a/+D7yZ9m7cdLGEtQtYh99eNbkrHXC6DxVGXrM323b2sfurYCQ5/vmERXbrZ7m7AxcB7jZAAxzxGKU6pObQdB7lwjVC4i2KN7x5sfvxmvF/6JFNnAf6qrXgTTa3MQxWuDzJyJE/6RFMnKtZ4/JcHQT7eK1JJt5Re7rKKbGLBAjvq6R/HBywKv2Eu/4z218KK0wbHOG0bAESfu0a+XhxhjzfPkaMNCCAXaL+7fXhIVcex3JG0jdMlybgaZcVCItVLuBIPdaNl8UO+Myrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7Kkkva+daRkb9HRU0rG5JnsQAypEb1ODUBB5Ip0QKEU=; b=COLSUy4gnkTRUtD5EII7QG4/R0GPvgpaCOBaWMdz0iQMOkq3X2RK4VD1/nYXUPLhaJbIwYlRmEg4XpJ39UiNQE4nO6ZJtbsH5F9svC5XwqYGAv/+9kik4xLLQfhBTuhtQTfBJPhgacH1HaX67vj5S5W9fhtdybEILQZb5Rm3if3drl0EUsDLF/6ZenAzQrr0YY+SMtssT8sui+k4VMo6bULE1p+y8131s7wlo9J1kdKs7MSqQhCj8zT2dEDNbbkTOAKoHwICpzff+4DLcQ0AKZU+3lny1hqvJlVDjzT/Mhx1kkPhBHqC8tEiucR0X3b5Gda/1hhc/JyRFKAAaGR1yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Kkkva+daRkb9HRU0rG5JnsQAypEb1ODUBB5Ip0QKEU=; b=kttbHXF69Un9v8F9omKY/nkydYgrI3cgS83wkR2O6/XZ9LXEbcRso4KaQTroKe5od4rbP97/zBwzh6rl+eqe5wpoMeh4opDKGzi3ynMDwBpD8EeAb1uW9DPT3qYRA+enVY143O4ZLvZwcpXW9dhb2hVxMz8yW+iaT5fPzUl2HXo= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB1247.namprd11.prod.outlook.com (2603:10b6:300:2a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Mon, 27 Sep 2021 12:23:14 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb%9]) with mapi id 15.20.4544.022; Mon, 27 Sep 2021 12:23:14 +0000 To: "Ananyev, Konstantin" , Akhil Goyal , "Doherty, Declan" CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "Medvedkin, Vladimir" , "Richardson, Bruce" , "Zhang, Roy Fan" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "Sinha, Abhijit" , "Buckley, Daniel M" , "marchana@marvell.com" , "ktejasree@marvell.com" , "matan@nvidia.com" References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210917091747.1528262-1-radu.nicolau@intel.com> <20210917091747.1528262-4-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <882c5cee-671f-f18e-4b24-52a4479d916f@intel.com> Date: Mon, 27 Sep 2021 13:23:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6PR0601CA0044.eurprd06.prod.outlook.com (2603:10a6:4:17::30) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6PR0601CA0044.eurprd06.prod.outlook.com (2603:10a6:4:17::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 12:23:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 171326b7-4e2f-4a52-bb16-08d981b193dd X-MS-TrafficTypeDiagnostic: MWHPR11MB1247: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D6a44ubaNAg02DzQdnnzEV+Nx+zU950X76s9B/oZEknMqAU9rp2ZZe/v/zS5PA5klI0OFBtE7fDPD1iex5gokmy/Wtw7reNEVk1qfxYwY68ZNq8WIJrLffEq7jnIGQPY2tal7LN9fRBu7qhNUSzGk3E3BYnsrGCbOXGYjT6VdTBYm2N33EISlCuRnLYO2RYRlTJiVSpxS5hJjZf/F1RTy532YK7eeAT1AvncfwZxIoe02oU5iDq124anPXs+XDdAGCcyQqfHPOpJW4kGs1DVCbDJsQt1EjsN7gW8tF9gj9kanhyPyD4t8slLEeWoEzZUgQi11UCnPczXSr/uI24khnOiIgG4gAhR6QWILgcRPcnSPKBNHX7STkCAS+P7Puc14zdVn1iCXVJjROAcdC66UwL1cEUiV76OIbypPNTJCssY3iw2fhsxu8UQQeapJWB8gE0IpZ7m1jMeRMjaTP/9PvirNvNfZqjeUBrZtJYOIiKPqdkAxgd+z9MwqSnhIcGLarJOp4PpJVzOsv7OphagRZaF6FhoUJxSeqKln6d0dBC/DUFGOs/JDqlXLApezLtplZR8m1kkpN1GaObs9wi247zs1rs8lgu2BheHqxo/t1pbCE7AxRuHrxnzYN+1nBGDFWxPhP2jry9HMLO9IxgjimwnCeQznTbinajdWeCadeGTe1YLXzCkZ82WIz6zZvvQFWYI5EoMNZxb6RNEEnk6UFR6k21twwIfvw4I/EmOJoDAZ7kgYSMaOShABLtb59u1 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6636002)(15650500001)(31686004)(36756003)(316002)(2906002)(8676002)(66556008)(6486002)(4326008)(55236004)(86362001)(26005)(83380400001)(54906003)(66476007)(110136005)(31696002)(53546011)(6666004)(956004)(508600001)(66946007)(8936002)(2616005)(186003)(16576012)(5660300002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amNWUzlwcWJkUy81RXFIR2ZrWFlZOFRHY1h4V3JtUVNXL3ROSytvcjNWbWt1?= =?utf-8?B?cC9MOUZUNTVwSHVwV2VNSG1GaXExZDhOSGdZeTdSRGJGSC94dmlkdURIWEFD?= =?utf-8?B?WElURzlrYWR0WGlQdFhDbjg5anZqKzlPeGVqd0c5NmxxWXpTRjQ5VmgxSnRy?= =?utf-8?B?S2w1NXVWQVRpelhXb0FQbDJzSzJkYXZ1cFZjSTYyQmJ1bmhXWm5wbGtISGlE?= =?utf-8?B?b0ZjTVpPUzZWRWhOeXVFQnF1a05ieUEycnJUOFVUNFBPU3VGY2pZMk9GTWJl?= =?utf-8?B?OVo3UE5mbU9WcmJHT3c3OW9LMG1rQzNlYnlab3JFUk0zbFJuZisvV1hrUWVZ?= =?utf-8?B?MzNtWFM1QWtRRWV2Q2R1d0UwTjdabkpoUncyckFBNVk2d290SDU2UWhyVEZM?= =?utf-8?B?UDd6SXpSWGRLUy94c2VHOEJwd1AvWEMwQTZISVdvUzVmOHYwZlNQTVNOYkpO?= =?utf-8?B?eTg5UUpwT1pnOFp1bjYvUFp2SWZkQUdMbnNmSjQyTTNBTXB5NU42K1NnbDJC?= =?utf-8?B?SE9ZOUhRN3BiWGZGMnRPQmVtZXlFYlVDZG8rWHJwQmx5QUJNTE5tYkdCYVM3?= =?utf-8?B?OXlaSk5EVEE4YXN3VGtKVGdGRGxUWHpBUlJIUGhMMHJkN1dpSHArSGpOUzVp?= =?utf-8?B?cFJ1Mjc1WFlyNHl1OUZZZHZYdUVRUGdSL1VZdGVnWjZMd3htVTBoc0l3aFpG?= =?utf-8?B?OGREVngvbGliNDc0ZG45MmpnSGtsZlNPSkRJRHFFT20zemlXd2s2aUdlWHIw?= =?utf-8?B?cHhnT1JGMVZyMGxodzV1UW1qUTg5VkZLQkhvMGIrdlZoM0dqTnUvUFdJN05v?= =?utf-8?B?Z1RGSUxFd0pSK2NlbGFJQzg0VzRSR3NPZFZ1MWdIaEMwNDkrYUFFeWlTWUNa?= =?utf-8?B?Q1hUVVM1N1ovcHZNU0l1VDJKZUtUSVZ3M1Z1eVd0aWg4bU1EcExWVmdFQ3hG?= =?utf-8?B?QzlCTUFNRkRsRERGQXVWZFNCNUlKSnBhYVZKYk5iSldWQ2k5ajNEUjM5SUly?= =?utf-8?B?NVJWL2hDTno1U0ovaVliRWRSQXpsVXErWE5lbXB0RmVIaHNwVkxPY09Qdisv?= =?utf-8?B?ZFBsbko5a210dDJ2VFJNdnZRZ3AySUxXTjJqZmJSMTByd20yemVsQkxISiti?= =?utf-8?B?dmYxaEFMTGgyZ0RvTXpuaUNZWEtWb1I0V3Q5YkNlSEJzczc0ZjFYNitaRURC?= =?utf-8?B?bC9za0cvZ0VITGg5M1JXZVlzaU0rSHhPQXl1VHZsbDk3L1pQR1MxKzlmQUxT?= =?utf-8?B?eHZYenVSUmk0WU9FSjlkeG1LVUsveFlSOHdkSysvaUxXT0hHZWZQbXF3empx?= =?utf-8?B?VWtnQ0tDbHIyTEhDdmdvTzFLYjE3aExPRE9nYTg0aWVMNFBnT1czbW92VDZG?= =?utf-8?B?S0lFQ3dDVW9KNXJCQ1gybnJYbTRMUDlnZkhucWV4VU0rUFRBaTk0NWwrNExH?= =?utf-8?B?ZmhMK05oei9JeE9TdWgvYzQ1d3AwUzFvbzUwZEdNM3Q2N0pSZzJya1dCdnlO?= =?utf-8?B?eEluMGV3WUJscGtLaE9oN1ZSK3dWM2xUSGxheVJyeEV0VS9ZWUFJNERUekRy?= =?utf-8?B?aTNPWGYwOTE0bTh4MlM3dHBEb0xYY2ZjR253V3kvY1NIYjcrU05ZSjJMREJL?= =?utf-8?B?RWQvaUFmUXdkVWd3ZTZtS2x5SExFMkdQZ2FRS29qNkRTRkxLcFpGZzRwUzV3?= =?utf-8?B?Ylo3WXlaNDJMaURBNVhNQVhwVXRsejlDNThzbENDYkNHbmJ0SXRmcDJzVG5I?= =?utf-8?Q?KTOg6GUJgRi5NApqQY6MrviCimBYD8HxYcyz+Lw?= X-MS-Exchange-CrossTenant-Network-Message-Id: 171326b7-4e2f-4a52-bb16-08d981b193dd X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 12:23:14.1384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XAV6Mvb9UlNV7JPF+rqBm2WSOVQeDPJUbx2rsvBe9rO/llnkSbEPFT6i+fcCgG5fGP2tVBE/hUCkHxiu6K+deA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1247 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 03/10] security: add ESN field to ipsec_xform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 1:46 PM, Ananyev, Konstantin wrote: >> Update ipsec_xform definition to include ESN field. >> This allows the application to control the ESN starting value. >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> Signed-off-by: Abhijit Sinha >> Signed-off-by: Daniel Martin Buckley >> Acked-by: Fan Zhang >> Acked-by: Anoob Joseph >> --- >> lib/security/rte_security.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h >> index 84ba1b08f8..1bd09e3cc2 100644 >> --- a/lib/security/rte_security.h >> +++ b/lib/security/rte_security.h >> @@ -240,6 +240,14 @@ struct rte_security_ipsec_xform { >> */ >> uint32_t mss; >> /**< IPsec payload Maximum Segment Size */ >> + union { >> + uint64_t value; >> + struct { >> + uint32_t low; >> + uint32_t hi; > Do we really need low/hi here? > As I remember ESN is 64bit value, no? The low and high halves are managed differently so I think for better consistency it's easier to have them as such.