From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: fix relpath.sh output when build dir is a symlink
Date: Tue, 12 May 2015 14:26:07 +0200 [thread overview]
Message-ID: <8836878.0IVNKqqCXa@xps13> (raw)
In-Reply-To: <554889E6.6080509@netinsight.net>
2015-05-05 11:14, Simon Kågström:
> On 2015-05-05 11:00, Olivier MATZ wrote:
> > On 05/05/2015 11:00 AM, Olivier Matz wrote:
> >> The script relpath.sh return the relative path of the first directory
> >> from the second directory. It is used to generate relative symlinks,
> >> which can be useful if the build directory is embedded in the dpdk
> >> directory: the whole dpdk can be moved without breaking the links,
> >> which is helpful for an installation.
> >>
> >> In case the build directory is a symlink, the script was not generating
> >> the proper relative path. Fix this by calling "readlink -f" on the
> >> arguments.
> >
> > Can you have a try with this patch?
>
> Yes, this fixes my build issue, thanks!
>
> Verified-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Applied, thanks
prev parent reply other threads:[~2015-05-12 12:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 12:42 [dpdk-dev] build issue with out-of-tree builds and multiple mounts Simon Kågström
2015-05-04 12:48 ` Olivier MATZ
2015-05-04 12:55 ` Simon Kågström
2015-05-05 9:00 ` [dpdk-dev] [PATCH] scripts: fix relpath.sh output when build dir is a symlink Olivier Matz
2015-05-05 9:00 ` Olivier MATZ
2015-05-05 9:14 ` Simon Kågström
2015-05-12 12:26 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8836878.0IVNKqqCXa@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).