From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8FBB77CB6
 for <dev@dpdk.org>; Thu, 26 Apr 2018 16:26:18 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1913621AAA;
 Thu, 26 Apr 2018 10:26:18 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Thu, 26 Apr 2018 10:26:18 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=S+0+tD24wXYhgMlUfbBV4HMmO5
 DZiVHmH3pkViUlTj0=; b=CDzOqLe5y73m9rfhoqGkEQurYIotPCsK7NAqJOBpmS
 /7sudPIjOT4P8K0MtqtTt2kBTwtmzTuYfqHOzgGpf4yycH4YgMsjuI7wLZ8pb6Xy
 YS507ReaS4Cp5hT/qRV4nbvZBe6M2okiyBL9o89TuAu24FvKcbU5fn5dRYk5uyWa
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=S+0+tD
 24wXYhgMlUfbBV4HMmO5DZiVHmH3pkViUlTj0=; b=Glf1kskks4vvro5uIqSqiq
 /tGN2oatxEEKvKeh2vKCG9FqelOdlm2no1zg1l7zbNzO0HcQQLgPcFKsS/JTCNLh
 nT2cQjSZR2KlUoCoiuTRmGqpWwYSKEaPDpBG6G9KvEtIs1cv2G8IuxpPy5bpmIV/
 ZuCMnc38WGHWP+VjsxR60noAxJmTGDQ7NdQBcZ71JoG92SFs5hMTC7q/o2iPLuhM
 Bn26I11VsdCe4BHm/bdj4C3Hhh5ma19E4KHUw3m5VPV+2i8JgPACE65dM5P4RuGF
 iI90ubfhFDr6cZowXD5p3ISjWuxVMQnXHBwioNBVogZYg+NO+VAZgSwwPL8Sq3Nw
 ==
X-ME-Sender: <xms:ieHhWpayCrJAo4xUrXbqT1LcD9G8Bcnh-WKLAdZjbPSHHX6id3Avww>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1DF35E4412;
 Thu, 26 Apr 2018 10:26:17 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Thu, 26 Apr 2018 16:26:15 +0200
Message-ID: <8839871.5oN85zmXV5@xps>
In-Reply-To: <4382683.Iya79JGdae@xps>
References: <20180416130605.6509-1-declan.doherty@intel.com>
 <20180426104105.18342-3-declan.doherty@intel.com> <4382683.Iya79JGdae@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v8 2/9] ethdev: add switch identifier
	parameter to port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2018 14:26:18 -0000

26/04/2018 14:02, Thomas Monjalon:
> 26/04/2018 12:40, Declan Doherty:
> > Introduces a new port attribute to ethdev port's which denotes the
> > switch domain a port belongs to. By default all port's switch
> > identifiers are set to RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID. Ports
> > which supported the concept of switch domains can be configured with
> > the same switch domain id.
> > 
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> 
> It's very well detailed now :)
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

One miss: you forgot to remove the deprecation notice in this patch.