* [dpdk-dev] [PATCH] ethdev: fix missing function in map file
@ 2018-07-13 8:24 Nelio Laranjeiro
2018-07-13 8:52 ` De Lara Guarch, Pablo
2018-07-13 9:11 ` Nelio Laranjeiro
0 siblings, 2 replies; 5+ messages in thread
From: Nelio Laranjeiro @ 2018-07-13 8:24 UTC (permalink / raw)
To: dev, Thomas Monjalon
Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
lib/librte_ethdev/rte_ethdev_version.map | 1 +
lib/librte_ethdev/rte_flow_driver.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index 9a0d12d41..0af8731b6 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -251,4 +251,5 @@ EXPERIMENTAL {
rte_mtr_policer_actions_update;
rte_mtr_stats_read;
rte_mtr_stats_update;
+ rte_flow_expand_rss;
};
diff --git a/lib/librte_ethdev/rte_flow_driver.h b/lib/librte_ethdev/rte_flow_driver.h
index ca675f6d3..141d4acac 100644
--- a/lib/librte_ethdev/rte_flow_driver.h
+++ b/lib/librte_ethdev/rte_flow_driver.h
@@ -169,7 +169,7 @@ struct rte_flow_expand_rss {
*
* -E2BIG: graph-depth @p graph is too deep.
*/
-int
+int __rte_experimental
rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
const struct rte_flow_item *pattern, uint64_t types,
const struct rte_flow_expand_node graph[],
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
2018-07-13 8:24 [dpdk-dev] [PATCH] ethdev: fix missing function in map file Nelio Laranjeiro
@ 2018-07-13 8:52 ` De Lara Guarch, Pablo
2018-07-13 9:09 ` Nélio Laranjeiro
2018-07-13 9:11 ` Nelio Laranjeiro
1 sibling, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-13 8:52 UTC (permalink / raw)
To: Nelio Laranjeiro, dev, Thomas Monjalon
Hi Nelio,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Friday, July 13, 2018 9:25 AM
> To: dev@dpdk.org; Thomas Monjalon <thomasm@mellanox.com>
> Subject: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
>
> Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
> lib/librte_ethdev/rte_ethdev_version.map | 1 +
> lib/librte_ethdev/rte_flow_driver.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev_version.map
> b/lib/librte_ethdev/rte_ethdev_version.map
> index 9a0d12d41..0af8731b6 100644
> --- a/lib/librte_ethdev/rte_ethdev_version.map
> +++ b/lib/librte_ethdev/rte_ethdev_version.map
> @@ -251,4 +251,5 @@ EXPERIMENTAL {
> rte_mtr_policer_actions_update;
> rte_mtr_stats_read;
> rte_mtr_stats_update;
> + rte_flow_expand_rss;
This list is in alphabetical order.
> };
> diff --git a/lib/librte_ethdev/rte_flow_driver.h
> b/lib/librte_ethdev/rte_flow_driver.h
> index ca675f6d3..141d4acac 100644
> --- a/lib/librte_ethdev/rte_flow_driver.h
> +++ b/lib/librte_ethdev/rte_flow_driver.h
> @@ -169,7 +169,7 @@ struct rte_flow_expand_rss {
> *
> * -E2BIG: graph-depth @p graph is too deep.
> */
> -int
> +int __rte_experimental
The implementation in the .c file should also have the experimental tag.
> rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
> const struct rte_flow_item *pattern, uint64_t types,
> const struct rte_flow_expand_node graph[],
> --
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
2018-07-13 8:52 ` De Lara Guarch, Pablo
@ 2018-07-13 9:09 ` Nélio Laranjeiro
0 siblings, 0 replies; 5+ messages in thread
From: Nélio Laranjeiro @ 2018-07-13 9:09 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Thomas Monjalon
Hi Pablo,
On Fri, Jul 13, 2018 at 08:52:07AM +0000, De Lara Guarch, Pablo wrote:
> Hi Nelio,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nelio Laranjeiro
> > Sent: Friday, July 13, 2018 9:25 AM
> > To: dev@dpdk.org; Thomas Monjalon <thomasm@mellanox.com>
> > Subject: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
> >
> > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > ---
> > lib/librte_ethdev/rte_ethdev_version.map | 1 +
> > lib/librte_ethdev/rte_flow_driver.h | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev_version.map
> > b/lib/librte_ethdev/rte_ethdev_version.map
> > index 9a0d12d41..0af8731b6 100644
> > --- a/lib/librte_ethdev/rte_ethdev_version.map
> > +++ b/lib/librte_ethdev/rte_ethdev_version.map
> > @@ -251,4 +251,5 @@ EXPERIMENTAL {
> > rte_mtr_policer_actions_update;
> > rte_mtr_stats_read;
> > rte_mtr_stats_update;
> > + rte_flow_expand_rss;
>
> This list is in alphabetical order.
> > };
> > diff --git a/lib/librte_ethdev/rte_flow_driver.h
> > b/lib/librte_ethdev/rte_flow_driver.h
> > index ca675f6d3..141d4acac 100644
> > --- a/lib/librte_ethdev/rte_flow_driver.h
> > +++ b/lib/librte_ethdev/rte_flow_driver.h
> > @@ -169,7 +169,7 @@ struct rte_flow_expand_rss {
> > *
> > * -E2BIG: graph-depth @p graph is too deep.
> > */
> > -int
> > +int __rte_experimental
>
> The implementation in the .c file should also have the experimental tag.
>
> > rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
> > const struct rte_flow_item *pattern, uint64_t types,
> > const struct rte_flow_expand_node graph[],
> > --
Will fix both point in a v2.
Thanks,
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] ethdev: fix missing function in map file
2018-07-13 8:24 [dpdk-dev] [PATCH] ethdev: fix missing function in map file Nelio Laranjeiro
2018-07-13 8:52 ` De Lara Guarch, Pablo
@ 2018-07-13 9:11 ` Nelio Laranjeiro
2018-07-13 13:54 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Nelio Laranjeiro @ 2018-07-13 9:11 UTC (permalink / raw)
To: dev, Thomas Monjalon
Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Changes in v2:
- add missing documentation.
- add missing __rte_experimental in source file.
- update the order in map file.
---
lib/librte_ethdev/rte_ethdev_version.map | 1 +
lib/librte_ethdev/rte_flow.c | 2 +-
lib/librte_ethdev/rte_flow_driver.h | 3 ++-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
index 9a0d12d41..38f117f01 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -239,6 +239,7 @@ EXPERIMENTAL {
rte_eth_dev_tx_offload_name;
rte_eth_switch_domain_alloc;
rte_eth_switch_domain_free;
+ rte_flow_expand_rss;
rte_mtr_capabilities_get;
rte_mtr_create;
rte_mtr_destroy;
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index e06cc2193..cff4b5209 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -531,7 +531,7 @@ rte_flow_copy(struct rte_flow_desc *desc, size_t len,
* Expand RSS flows into several possible flows according to the RSS hash
* fields requested and the driver capabilities.
*/
-int
+int __rte_experimental
rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
const struct rte_flow_item *pattern, uint64_t types,
const struct rte_flow_expand_node graph[],
diff --git a/lib/librte_ethdev/rte_flow_driver.h b/lib/librte_ethdev/rte_flow_driver.h
index ca675f6d3..4d8908226 100644
--- a/lib/librte_ethdev/rte_flow_driver.h
+++ b/lib/librte_ethdev/rte_flow_driver.h
@@ -148,6 +148,7 @@ struct rte_flow_expand_rss {
/**
* Expand RSS flows into several possible flows according to the RSS hash
* fields requested and the driver capabilities.
+ * @b EXPERIMENTAL: this API may change without prior notice
*
* @param[out] buf
* Buffer to store the result expansion.
@@ -169,7 +170,7 @@ struct rte_flow_expand_rss {
*
* -E2BIG: graph-depth @p graph is too deep.
*/
-int
+int __rte_experimental
rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
const struct rte_flow_item *pattern, uint64_t types,
const struct rte_flow_expand_node graph[],
--
2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix missing function in map file
2018-07-13 9:11 ` Nelio Laranjeiro
@ 2018-07-13 13:54 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-07-13 13:54 UTC (permalink / raw)
To: Nelio Laranjeiro; +Cc: dev
13/07/2018 11:11, Nelio Laranjeiro:
> Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> --
>
> Changes in v2:
>
> - add missing documentation.
> - add missing __rte_experimental in source file.
> - update the order in map file.
> ---
> --- a/lib/librte_ethdev/rte_flow_driver.h
> +++ b/lib/librte_ethdev/rte_flow_driver.h
> @@ -148,6 +148,7 @@ struct rte_flow_expand_rss {
> /**
> * Expand RSS flows into several possible flows according to the RSS hash
> * fields requested and the driver capabilities.
> + * @b EXPERIMENTAL: this API may change without prior notice
Blank line missing to make it appear on a new line.
Applied with following log:
Add rte_flow_expand_rss in map file and tag it as experimental.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-13 13:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 8:24 [dpdk-dev] [PATCH] ethdev: fix missing function in map file Nelio Laranjeiro
2018-07-13 8:52 ` De Lara Guarch, Pablo
2018-07-13 9:09 ` Nélio Laranjeiro
2018-07-13 9:11 ` Nelio Laranjeiro
2018-07-13 13:54 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).