From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id D114BC3BE
 for <dev@dpdk.org>; Mon,  3 Aug 2015 17:50:29 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so141772110wib.1
 for <dev@dpdk.org>; Mon, 03 Aug 2015 08:50:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=1j95Voe8Y9bZfirDiTdlGUDcPUIjpkaMkV5oPjM15uY=;
 b=XGF+4FgMhAmTN69pupWcD44uwbyrn4j/fOBXUv3W1ug+OPfnNTx8Uh6N0sJWBRb2sb
 a160o5ixfsuI498GBnFIucFGb1YjK2yWrWtku1iUubyvej2qTelwig/DKgr6NyyC7bCh
 08QsU9/4/mEj9SC7x6aSOWPdv7I9038CkQqBexyqD2P2RHu/u6AKn/XgCpd9OcuF/laf
 JLA1eSbBX6sK/JVNMifXcR5RjK2n97C28GD8tW/M1BTtZTocLB+VNuYsysybwpc8sc3u
 o93vrCGpH2mDpCCs9Ld9N2FbTCiyAw/p4R0AQjjIBEY15zP8rKnCPS5X2sSr++JcsoVR
 ULHg==
X-Gm-Message-State: ALoCoQl4CcXfo325NycREIBJMLQsh7vJEkpcD/ZjzUayfFuOav4EuNmQCi4lngWqF4xv7B5IO7ZA
X-Received: by 10.194.175.65 with SMTP id by1mr38987537wjc.152.1438617029705; 
 Mon, 03 Aug 2015 08:50:29 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id lm16sm14195943wic.18.2015.08.03.08.50.28
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 03 Aug 2015 08:50:28 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 03 Aug 2015 17:49:15 +0200
Message-ID: <8853406.AiVMUm1C9c@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438263693-24165-1-git-send-email-thomas.monjalon@6wind.com>
References: <1438263693-24165-1-git-send-email-thomas.monjalon@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix build on FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2015 15:50:30 -0000

Stephen,

> By the way, it seems strange that pi_data is initialized twice:
> 	.pi_data = *(u_int32_t *)buf
> 	memcpy(&pi.pi_data, buf, len);

Please, could you explain why there are 2 initializations of pi_data
in lib/librte_eal/bsdapp/eal/eal_pci.c?