From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7542A426AE; Tue, 3 Oct 2023 14:04:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 014ED4026C; Tue, 3 Oct 2023 14:04:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CC1594026B for ; Tue, 3 Oct 2023 14:04:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696334692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9/o5pbpk47dnUpLEl7DohAdqHgLXcYYC6uyB4S0fT3Y=; b=GhfTgehoO8MxDhAbTDdC6yihzgtbxSe4tR3799orsdLpYPQ/SAbSM/mRePIKXBcHkcQPos 5vrRdVzS1Y4RfCcdGLwruTUqSJp09zqT5YhOqY9e1tJpMX5LG/9jcXfxM7dxqRKp0/bJP1 0EkF18n+GoVnjOnav2zVOkwSaQqE9qs= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-311-_n_2y_jMNvGV9nhEUaMD2g-1; Tue, 03 Oct 2023 08:04:49 -0400 X-MC-Unique: _n_2y_jMNvGV9nhEUaMD2g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ABBBF1C294AA; Tue, 3 Oct 2023 12:04:48 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A388C402D93; Tue, 3 Oct 2023 12:04:47 +0000 (UTC) Message-ID: <8860319a-b944-1b72-b6ed-9cc70b2126f8@redhat.com> Date: Tue, 3 Oct 2023 14:04:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Nicolas Chautru , dev@dpdk.org Cc: hemant.agrawal@nxp.com, david.marchand@redhat.com, hernan.vargas@intel.com References: <20230929163516.3636499-1-nicolas.chautru@intel.com> <20230929163516.3636499-4-nicolas.chautru@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v3 03/12] baseband/acc: remove the 4G SO capability for VRB1 In-Reply-To: <20230929163516.3636499-4-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/23 18:35, Nicolas Chautru wrote: > This removes the specific capability and support of LTE Decoder > Soft Output option on the VRB1 PMD. > > This is triggered as a vendor decision to defeature the related optional > capability so that to avoid theoretical risk of race conditions > impacting the device reliability. That optional APP LLR output is > not impacting the actual decoder hard output. > > Signed-off-by: Nicolas Chautru > --- > doc/guides/bbdevs/vrb1.rst | 4 ---- > drivers/baseband/acc/rte_vrb_pmd.c | 10 ++++++---- > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/doc/guides/bbdevs/vrb1.rst b/doc/guides/bbdevs/vrb1.rst > index 9c48d30964..fdefb20651 100644 > --- a/doc/guides/bbdevs/vrb1.rst > +++ b/doc/guides/bbdevs/vrb1.rst > @@ -71,11 +71,7 @@ The Intel vRAN Boost v1.0 PMD supports the following bbdev capabilities: > - ``RTE_BBDEV_TURBO_EARLY_TERMINATION``: set early termination feature. > - ``RTE_BBDEV_TURBO_DEC_SCATTER_GATHER``: supports scatter-gather for input/output data. > - ``RTE_BBDEV_TURBO_HALF_ITERATION_EVEN``: set half iteration granularity. > - - ``RTE_BBDEV_TURBO_SOFT_OUTPUT``: set the APP LLR soft output. > - - ``RTE_BBDEV_TURBO_EQUALIZER``: set the turbo equalizer feature. > - - ``RTE_BBDEV_TURBO_SOFT_OUT_SATURATE``: set the soft output saturation. > - ``RTE_BBDEV_TURBO_CONTINUE_CRC_MATCH``: set to run an extra odd iteration after CRC match. > - - ``RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT``: set if negative APP LLR output supported. > - ``RTE_BBDEV_TURBO_MAP_DEC``: supports flexible parallel MAP engine decoding. > > * For the FFT operation: > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index c5a74bae11..f11882f90e 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -1025,15 +1025,11 @@ vrb_dev_info_get(struct rte_bbdev *dev, struct rte_bbdev_driver_info *dev_info) > RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE | > RTE_BBDEV_TURBO_CRC_TYPE_24B | > RTE_BBDEV_TURBO_DEC_CRC_24B_DROP | > - RTE_BBDEV_TURBO_EQUALIZER | > - RTE_BBDEV_TURBO_SOFT_OUT_SATURATE | > RTE_BBDEV_TURBO_HALF_ITERATION_EVEN | > RTE_BBDEV_TURBO_CONTINUE_CRC_MATCH | > - RTE_BBDEV_TURBO_SOFT_OUTPUT | > RTE_BBDEV_TURBO_EARLY_TERMINATION | > RTE_BBDEV_TURBO_DEC_INTERRUPTS | > RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN | > - RTE_BBDEV_TURBO_NEG_LLR_1_BIT_SOFT_OUT | > RTE_BBDEV_TURBO_MAP_DEC | > RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP | > RTE_BBDEV_TURBO_DEC_SCATTER_GATHER, > @@ -1982,6 +1978,12 @@ enqueue_dec_one_op_cb(struct acc_queue *q, struct rte_bbdev_dec_op *op, > struct rte_mbuf *input, *h_output_head, *h_output, > *s_output_head, *s_output; > > + if ((q->d->device_variant == VRB1_VARIANT) && > + (check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_SOFT_OUTPUT))) { > + /* SO not supported for VRB1. */ > + return -EPERM; > + } > + A better option would be to have a pointer on the device capabilities in the acc_device struct, doing so would be more future-proof. Maybe it could be considered? But in the mean time, it addresses this specific issue: Reviewed-by: Maxime Coquelin Thanks, Maxime > desc = acc_desc(q, total_enqueued_cbs); > vrb_fcw_td_fill(op, &desc->req.fcw_td); >