From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E212A0C47; Tue, 26 Oct 2021 02:30:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2E0240A4B; Tue, 26 Oct 2021 02:30:29 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id F3C0E4003E for ; Tue, 26 Oct 2021 02:30:27 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HdXfg15hbzbnML for ; Tue, 26 Oct 2021 08:25:47 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 08:30:24 +0800 Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 08:30:24 +0800 To: Bruce Richardson , CC: Andrew Rybchenko References: <20211020134840.2421686-1-bruce.richardson@intel.com> <20211020142601.157649-1-bruce.richardson@intel.com> From: fengchengwen Message-ID: <8864a5f5-d4db-d7bd-2333-db54b86e4415@huawei.com> Date: Tue, 26 Oct 2021 08:30:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20211020142601.157649-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2021/10/20 22:26, Bruce Richardson wrote: > Since we allow line lengths of up to 100, and the CI checkpatches job > only check for that amount, the rest of our tooling and docs should > reflect this reality. Therefore we can: > > * adjust the editorconfig to use that value, to save editors (e.g. vim) > from automatically wrapping lines at 80 characters when typing. > [Since python checkers all seem to expect 79 character lines max, add > for python only a 79-char max line length.] > > * change the default line length setting in checkpatches script to 100 > so as it matches CI and pre-merge checks. > > * update the docs to clarify that while 80 chars is recommended, up to > 100 characters is acceptable. > > Signed-off-by: Bruce Richardson Acked-by: Chengwen Feng