From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 993B5A00BE; Tue, 29 Oct 2019 04:12:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 440B71BECE; Tue, 29 Oct 2019 04:12:40 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9CE131BE97 for ; Tue, 29 Oct 2019 04:12:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 20:12:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="198242534" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 28 Oct 2019 20:12:37 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 28 Oct 2019 20:12:36 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Oct 2019 20:12:36 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Oct 2019 20:12:36 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Tue, 29 Oct 2019 11:12:35 +0800 From: "Min, JiaqiX" To: "Ye, Xiaolong" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size Thread-Index: AQHVjWbUYaxsven5JkOHoXqmBTZ8nKdvN3WAgAG1JtA= Date: Tue, 29 Oct 2019 03:12:34 +0000 Message-ID: <88691F3C94B94D4584B3478B96DE5B740B06B869@SHSMSX101.ccr.corp.intel.com> References: <20191024190818.36524-1-jiaqix.min@intel.com> <20191028155453.37207-1-jiaqix.min@intel.com> <20191028084627.GA12923@intel.com> In-Reply-To: <20191028084627.GA12923@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTkzYjhlOGUtYWFiMC00OWIxLWExYmQtMzJkZTQwMDcxODcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9lZGNwR0JLcHJRVHl3aXVFbWRoY1dqWHlKNmJqVXJkRlN2UVdMeG02WTRTMTRMTlRtZFc4aDA2VzFEZVQ1SXcifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaolong, > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, October 28, 2019 4:46 PM > To: Min, JiaqiX > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size >=20 > On 10/28, Min JiaqiX wrote: > >Max frame size is not set to HW, so packets above the MTU do not get > >dropped by HW. The patch fixed the issue. > > > >Fixes: ae2bdd0219cb ("net/ice: support MTU setting") >=20 > We should set max frame size to HW in the beginning when the driver was > introduced, so the fix commit should be 50370662b727 ("net/ice: support > device and queue ops") Modify commit message in patch v3. >=20 > Fix this while merging. >=20 > >Cc: stable@dpdk.org > > > >Signed-off-by: Min JiaqiX > >--- > >v2: > >* Changed commit message. > >--- > > drivers/net/ice/ice_ethdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > >diff --git a/drivers/net/ice/ice_ethdev.c > >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644 > >--- a/drivers/net/ice/ice_ethdev.c > >+++ b/drivers/net/ice/ice_ethdev.c > >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev) > > > > pf->adapter_stopped =3D false; > > > >+ /* Set the max frame size */ > >+ ice_aq_set_mac_cfg(hw, > >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL); > >+ >=20 > Why set the max frame size to HW in start ops, not in init stage like in = i40e? > and what if max_rx_pkt_len hasn't been set? >=20 max_rx_pkt_len need to be set to HW when set mtu , init stage won't be cal= led when open port again. Appendix: Steps for using Example/ethtool to set mtu: EthApp>stop 0 EthApp>mtu 0 200 EthApp>open 0 >=20 > Thanks, > Xiaolong >=20 >=20 > > return 0; > > > > /* stop the started queues if failed to start all queues */ > >-- > >2.17.1 > > >=20 > Reviewed-by: Xiaolong Ye >=20 > Applied to dpdk-next-net-intel. Thanks.