DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min, JiaqiX" <jiaqix.min@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
Date: Wed, 30 Oct 2019 06:40:30 +0000	[thread overview]
Message-ID: <88691F3C94B94D4584B3478B96DE5B740B06C633@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191030052155.GE11315@intel.com>

Hi, Xiaolong

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Wednesday, October 30, 2019 1:22 PM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
> 
> Hi, Jiaqi
> 
> On 10/29, Min JiaqiX wrote:
> >Max frame size is not set to HW, so packets above the MTU do not get
> >dropped by HW. The patch fixed the issue.
> >
> >Fixes: 50370662b727 ("net/ice: support device and queue ops")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> 
> Sorry, the Reviewed-by was given by accident in V1.

Reviewed-by in next patch will be removed.
> 
> >---
> >v3:
> >* Changed Fixes line.
> >v2:
> >* Changed commit message.
> >---
> > drivers/net/ice/ice_ethdev.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
> >
> > 	pf->adapter_stopped = false;
> >
> >+	/* Set the max frame size */
> >+	ice_aq_set_mac_cfg(hw,
> >+		pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
> >+
> 
> As I commented in V2, what if user doesn't set mtu, then the
> max_rx_pkt_len would be 0, do we need a default max frame value in this
> case?
Agree.  Add check if 0 and default max frame value in this case to next patch.

> 
> Thanks,
> Xiaolong
> 
> > 	return 0;
> >
> > 	/* stop the started queues if failed to start all queues */
> >--
> >2.17.1
> >

  reply	other threads:[~2019-10-30  6:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 19:08 [dpdk-dev] [PATCH] net/ice: set " Min JiaqiX
2019-10-25  3:06 ` Ye Xiaolong
2019-10-25  3:39   ` Min, JiaqiX
2019-10-25  9:43     ` Kevin Traynor
2019-10-28  5:29     ` Ye Xiaolong
2019-10-28 15:54 ` [dpdk-dev] [PATCH v2] net/ice: fix setting " Min JiaqiX
2019-10-28  8:46   ` Ye Xiaolong
2019-10-29  2:05     ` Ye Xiaolong
2019-10-29  3:12     ` Min, JiaqiX
2019-10-29  5:07       ` Ye Xiaolong
2019-10-30  6:34         ` Min, JiaqiX
2019-10-29 12:54   ` [dpdk-dev] [PATCH v3] " Min JiaqiX
2019-10-30  5:21     ` Ye Xiaolong
2019-10-30  6:40       ` Min, JiaqiX [this message]
2019-10-30 10:04     ` [dpdk-dev] [PATCH v4] " Min JiaqiX
2019-11-04  2:56       ` Ye Xiaolong
2019-11-04  7:05         ` Min, JiaqiX
2019-11-04 15:33       ` [dpdk-dev] [PATCH v5] " Min JiaqiX
2019-11-05  2:22         ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88691F3C94B94D4584B3478B96DE5B740B06C633@SHSMSX101.ccr.corp.intel.com \
    --to=jiaqix.min@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).