From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Xuan Ding <xuan.ding@intel.com>, <dev@dpdk.org>,
<maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>
Cc: <jiayu.hu@intel.com>, <bruce.richardson@intel.com>,
"techboard@dpdk.org" <techboard@dpdk.org>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce change in dma mapping/unmapping
Date: Thu, 26 Aug 2021 10:29:53 +0100 [thread overview]
Message-ID: <886efb65-32aa-adb9-63de-9ca41d87ac4b@intel.com> (raw)
In-Reply-To: <8aef3f20-8edf-7e6a-5e59-f325a2d3383a@intel.com>
On 8/25/2021 12:47 PM, Burakov, Anatoly wrote:
> On 25-Aug-21 12:27 PM, Xuan Ding wrote:
>> Currently, the VFIO subsystem will compact adjacent DMA regions for the
>> purposes of saving space in the internal list of mappings. This has a
>> side effect of compacting two separate mappings that just happen to be
>> adjacent in memory. Since VFIO implementation on IA platforms also does
>> not allow partial unmapping of memory mapped for DMA, the current DPDK
>> VFIO implementation will prevent unmapping of accidentally adjacent
>> maps even though it could have been unmapped [1].
>>
>> The proper fix for this issue is to change the VFIO DMA mapping API to
>> also include page size, and always map memory page-by-page.
>>
>> [1] https://mails.dpdk.org/archives/dev/2021-July/213493.html
>>
>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 76a4abfd6b..272ffa993e 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -287,3 +287,6 @@ Deprecation Notices
>> reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other
>> information from the crypto/security operation. This field will be used to
>> communicate events such as soft expiry with IPsec in lookaside mode.
>> +
>> + * vfio: the functions `rte_vfio_container_dma_map` and
>> `rte_vfio_container_dma_unmap`
>> + will be amended to include page size. This change is targeted for DPDK 21.11.
>>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
Techboard decision was to add a new API, instead of updating existing ones, to
not break the apps using this API.
@Xuan, @Anatoly, can you please confirm if this will solve your problem?
next prev parent reply other threads:[~2021-08-26 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 11:27 Xuan Ding
2021-08-25 11:47 ` Burakov, Anatoly
2021-08-26 9:29 ` Ferruh Yigit [this message]
2021-08-26 9:46 ` Burakov, Anatoly
2021-08-26 10:09 ` Bruce Richardson
2021-08-26 10:14 ` Burakov, Anatoly
2021-08-31 13:42 ` Ding, Xuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886efb65-32aa-adb9-63de-9ca41d87ac4b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=techboard@dpdk.org \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).