From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 1ADBD2B84
 for <dev@dpdk.org>; Wed, 29 Jun 2016 18:40:14 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id f126so189018614wma.1
 for <dev@dpdk.org>; Wed, 29 Jun 2016 09:40:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=vKAF1ua4ZdaxmRtMvAVUrxQtYmuZjnUIgJxbhMxqmuU=;
 b=ByWDm3u1nOSvu7s7OcRPDkVllR5JT/F+O9xCGBjaUdMjFqDs/vANQkBUKm9sRIholw
 dipc7l9fHxya1FyDt9SY8MwInXfa0JpTsSXe9N7Bzyz48L4yQE9nsXZCjiyss9h/u1/j
 APD3fuKz7Gv/s0J1VBrA7ZzY2gDO4IOHnYIy82UHBjYSP7Qx4sbOO9QUDbcbVVoTGDVV
 /atR/mz7f/T/JLCqCpOMYzlXzRl4itWWGNC04qXlJmSvxGChEXY9CUj3yJdGmuS3s65n
 DwKIet2+JC8FJ4v6U/Q9StGSOcTpLQ1RvECj3qJs5Hrfq8C6NuD3dr+u448FtK3Aqkpq
 vzpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=vKAF1ua4ZdaxmRtMvAVUrxQtYmuZjnUIgJxbhMxqmuU=;
 b=Rs4YgKdeku3r/PK9Uz546hjtn4WovXg4GKA4ET1xpa9GrgL9wvCGD6KtfoRGVxR2D3
 OVmDP3tqjqmpsMr+oSh958ed6gG3z7jq5hMa3S1Ns1zTNEymbYoolS6n9N7Nwu74b4xE
 l9D+0Qmfa0BI0bVA548ZGK2NbjKuVToJdN+CNZE0h8FCske1LLMyhPJbs+HgPfwf4i0w
 ncX2zCCH/hs7h0SvkgH+MVmwp3Xh4xYkNfoDFckOkcLl7ZwCjjKKdgMgC534lij+Y3yW
 KeR0jvJQ9RXf5d41BwlRgIB+zqIomanTjh16WDW+/v+R3WMk8yTD06e3pAzzIA2GGeV/
 UuBw==
X-Gm-Message-State: ALyK8tIIAoN/eV7/oxVhlIxxCVX4pIfDFlbQWB+6N4j590JEQ6Z8n0oqJFV3yMPCU6l//bju
X-Received: by 10.194.109.232 with SMTP id hv8mr9513825wjb.115.1467218413763; 
 Wed, 29 Jun 2016 09:40:13 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id b187sm5026984wmg.15.2016.06.29.09.40.12
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 29 Jun 2016 09:40:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>
Date: Wed, 29 Jun 2016 18:40:08 +0200
Message-ID: <8870166.MVVViF2IlQ@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <d37183a6-41d1-4a0f-ba47-f44b4cca89ad@intel.com>
References: <5773EB79.1090509@6wind.com>
 <d37183a6-41d1-4a0f-ba47-f44b4cca89ad@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] xstats performance
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 16:40:14 -0000

2016-06-29 17:03, Remy Horton:
> On 29/06/2016 16:38, Olivier MATZ wrote:
> > And assume that the id field in rte_eth_xstat corresponds to
> > the index in the rte_eth_xstat_name table?
> 
> It was an assumption I wanted to avoid setting in stone, even though at 
> the moment it is actually true in implementation.
> 
> The mappings are driver-specific but I wanted to leave open, amoung 
> other things, the possibility of string-id mappings being standardised 
> across all drivers. For that to work drivers would have to be able to 
> use a set of ids that may contain gaps.

I don't think it is possible to standardize stats ids, for two reasons:
- it is hard to maintain and avoid conflicts between drivers
- the drivers would have to lookup the names which degrades performance

I think the idea of Olivier would improve the performance of stats retrieval,
which was the idea of this rework :)
Unfortunately we need someone available to fix it quickly for RC2.